about summary refs log tree commit homepage
path: root/lib/PublicInbox/Feed.pm
diff options
context:
space:
mode:
Diffstat (limited to 'lib/PublicInbox/Feed.pm')
-rw-r--r--lib/PublicInbox/Feed.pm106
1 files changed, 39 insertions, 67 deletions
diff --git a/lib/PublicInbox/Feed.pm b/lib/PublicInbox/Feed.pm
index c32e7bde..b373a1eb 100644
--- a/lib/PublicInbox/Feed.pm
+++ b/lib/PublicInbox/Feed.pm
@@ -8,19 +8,18 @@ use warnings;
 use PublicInbox::MIME;
 use PublicInbox::View;
 use PublicInbox::WwwAtomStream;
+use PublicInbox::SearchMsg; # this loads w/o Search::Xapian
 
 # main function
 sub generate {
         my ($ctx) = @_;
-        my @paths;
-        each_recent_blob($ctx, sub { push @paths, $_[0] });
-        return _no_thread() unless @paths;
+        my $msgs = recent_msgs($ctx);
+        return _no_thread() unless @$msgs;
 
         my $ibx = $ctx->{-inbox};
         PublicInbox::WwwAtomStream->response($ctx, 200, sub {
-                while (my $path = shift @paths) {
-                        my $mime = do_cat_mail($ibx, $path) or next;
-                        return $mime;
+                while (my $smsg = shift @$msgs) {
+                        $ibx->smsg_mime($smsg) and return $smsg;
                 }
         });
 }
@@ -28,18 +27,16 @@ sub generate {
 sub generate_thread_atom {
         my ($ctx) = @_;
         my $mid = $ctx->{mid};
-        my $res = $ctx->{srch}->get_thread($mid);
-        return _no_thread() unless $res->{total};
+        my $msgs = $ctx->{srch}->get_thread($mid);
+        return _no_thread() unless @$msgs;
 
         my $ibx = $ctx->{-inbox};
         my $html_url = $ibx->base_url($ctx->{env});
         $html_url .= PublicInbox::Hval->new_msgid($mid)->{href};
         $ctx->{-html_url} = $html_url;
-        my $msgs = $res->{msgs};
         PublicInbox::WwwAtomStream->response($ctx, 200, sub {
-                while (my $msg = shift @$msgs) {
-                        $msg = $ibx->msg_by_smsg($msg) and
-                                return PublicInbox::MIME->new($msg);
+                while (my $smsg = shift @$msgs) {
+                        $ibx->smsg_mime($smsg) and return $smsg;
                 }
         });
 }
@@ -63,27 +60,22 @@ sub generate_html_index {
 
 sub new_html {
         my ($ctx) = @_;
-        my @paths;
-        my (undef, $last) = each_recent_blob($ctx, sub {
-                my ($path, $commit, $ts, $u, $subj) = @_;
-                $ctx->{first} ||= $commit;
-                push @paths, $path;
-        });
-        if (!@paths) {
+        my $msgs = recent_msgs($ctx);
+        if (!@$msgs) {
                 return [404, ['Content-Type', 'text/plain'],
                         ["No messages, yet\n"] ];
         }
         $ctx->{-html_tip} = '<pre>';
         $ctx->{-upfx} = '';
         $ctx->{-hr} = 1;
+        my $ibx = $ctx->{-inbox};
         PublicInbox::WwwStream->response($ctx, 200, sub {
-                while (my $path = shift @paths) {
-                        my $m = do_cat_mail($ctx->{-inbox}, $path) or next;
-                        my $more = scalar @paths;
-                        my $s = PublicInbox::View::index_entry($m, $ctx, $more);
-                        return $s;
+                while (my $smsg = shift @$msgs) {
+                        my $m = $ibx->smsg_mime($smsg) or next;
+                        my $more = scalar @$msgs;
+                        return PublicInbox::View::index_entry($m, $ctx, $more);
                 }
-                new_html_footer($ctx, $last);
+                PublicInbox::View::pagination_footer($ctx, './new.html');
         });
 }
 
@@ -93,30 +85,23 @@ sub _no_thread () {
         [404, ['Content-Type', 'text/plain'], ["No feed found for thread\n"]];
 }
 
-sub new_html_footer {
-        my ($ctx, $last) = @_;
-        my $qp = delete $ctx->{qp} or return;
-        my $old_r = $qp->{r};
-        my $latest = '';
-        my $next = '    ';
-
-        if ($last) {
-                $next = qq!<a\nhref="?r=$last"\nrel=next>next</a>!;
+sub recent_msgs {
+        my ($ctx) = @_;
+        my $ibx = $ctx->{-inbox};
+        my $max = $ibx->{feedmax};
+        my $qp = $ctx->{qp};
+        my $v = $ibx->{version} || 1;
+        if ($v > 2) {
+                die "BUG: unsupported inbox version: $v\n";
         }
-        if ($old_r) {
-                $latest = qq! <a\nhref='./new.html'>latest</a>!;
+        if (my $srch = $ibx->search) {
+                return PublicInbox::View::paginate_recent($ctx, $max);
         }
-        "<hr><pre>page: $next$latest</pre>";
-}
 
-sub each_recent_blob {
-        my ($ctx, $cb) = @_;
-        my $max = $ctx->{-inbox}->{feedmax};
         my $hex = '[a-f0-9]';
-        my $addmsg = qr!^:000000 100644 \S+ \S+ A\t(${hex}{2}/${hex}{38})$!;
-        my $delmsg = qr!^:100644 000000 \S+ \S+ D\t(${hex}{2}/${hex}{38})$!;
+        my $addmsg = qr!^:000000 100644 \S+ (\S+) A\t${hex}{2}/${hex}{38}$!;
+        my $delmsg = qr!^:100644 000000 (\S+) \S+ D\t(${hex}{2}/${hex}{38})$!;
         my $refhex = qr/(?:HEAD|${hex}{4,40})(?:~\d+)?/;
-        my $qp = $ctx->{qp};
 
         # revision ranges may be specified
         my $range = 'HEAD';
@@ -128,54 +113,41 @@ sub each_recent_blob {
         # get recent messages
         # we could use git log -z, but, we already know ssoma will not
         # leave us with filenames with spaces in them..
-        my $log = $ctx->{-inbox}->git->popen(qw/log
+        my $log = $ibx->git->popen(qw/log
                                 --no-notes --no-color --raw -r
-                                --abbrev=16 --abbrev-commit/,
-                                "--format=%h%x00%ct%x00%an%x00%s%x00",
-                                $range);
+                                --no-abbrev --abbrev-commit/,
+                                "--format=%H", $range);
         my %deleted; # only an optimization at this point
         my $last;
-        my $nr = 0;
-        my ($cur_commit, $first_commit, $last_commit);
-        my ($ts, $subj, $u);
+        my $last_commit;
         local $/ = "\n";
+        my @oids;
         while (defined(my $line = <$log>)) {
                 if ($line =~ /$addmsg/o) {
                         my $add = $1;
                         next if $deleted{$add}; # optimization-only
-                        $cb->($add, $cur_commit, $ts, $u, $subj) and $nr++;
-                        if ($nr >= $max) {
+                        push @oids, $add;
+                        if (scalar(@oids) >= $max) {
                                 $last = 1;
                                 last;
                         }
                 } elsif ($line =~ /$delmsg/o) {
                         $deleted{$1} = 1;
-                } elsif ($line =~ /^${hex}{7,40}/o) {
-                        ($cur_commit, $ts, $u, $subj) = split("\0", $line);
-                        unless (defined $first_commit) {
-                                $first_commit = $cur_commit;
-                        }
                 }
         }
 
         if ($last) {
                 local $/ = "\n";
                 while (my $line = <$log>) {
-                        if ($line =~ /^(${hex}{7,40})/o) {
+                        if ($line =~ /^(${hex}{7,40})/) {
                                 $last_commit = $1;
                                 last;
                         }
                 }
         }
 
-        # for pagination
-        ($first_commit, $last_commit);
-}
-
-sub do_cat_mail {
-        my ($ibx, $path) = @_;
-        my $mime = eval { $ibx->msg_by_path($path) } or return;
-        PublicInbox::MIME->new($mime);
+        $ctx->{next_page} = "r=$last_commit" if $last_commit;
+        [ map { bless {blob => $_ }, 'PublicInbox::SearchMsg' } @oids ];
 }
 
 1;