diff options
| -rw-r--r-- | lib/PublicInbox/Address.pm | 9 | ||||
| -rw-r--r-- | t/address.t | 5 |
2 files changed, 11 insertions, 3 deletions
diff --git a/lib/PublicInbox/Address.pm b/lib/PublicInbox/Address.pm index 433b36eb..c23a5d62 100644 --- a/lib/PublicInbox/Address.pm +++ b/lib/PublicInbox/Address.pm @@ -4,12 +4,15 @@ package PublicInbox::Address; use strict; use warnings; -sub xs_emails { map { $_->address() } parse_email_addresses($_[0]) } +sub xs_emails { + grep { defined } map { $_->address() } parse_email_addresses($_[0]) +} sub xs_names { - map { + grep { defined } map { my $n = $_->name; - $n = $_->user if $n eq $_->address; + my $addr = $_->address; + $n = $_->user if defined($addr) && $n eq $addr; $n; } parse_email_addresses($_[0]); } diff --git a/t/address.t b/t/address.t index e7c0d6a8..1f20702a 100644 --- a/t/address.t +++ b/t/address.t @@ -38,6 +38,11 @@ sub test_pkg { @names = $names->('"Quote Unneeded" <user@example.com>'); is_deeply(['Quote Unneeded'], \@names, 'extra quotes dropped'); + + my @emails = $emails->('Local User <user>'); + is_deeply([], \@emails , 'no address for local address'); + @names = $emails->('Local User <user>'); + is_deeply([], \@names, 'no address, no name'); } test_pkg('PublicInbox::Address'); |