about summary refs log tree commit homepage
path: root/t
diff options
context:
space:
mode:
authorEric Wong <e@80x24.org>2019-06-14 10:09:13 +0000
committerEric Wong <e@80x24.org>2019-06-15 17:37:35 +0000
commit2cc052a06358ee293574d2d8aaa8c38c1a1026d7 (patch)
tree5d20f8b89f3e9abf21b26ec67073fe992c34650b /t
parentf47a3a53d69c576a1a58ae46c1ea62f7447e6aba (diff)
downloadpublic-inbox-2cc052a06358ee293574d2d8aaa8c38c1a1026d7.tar.gz
I found myself tempted to switch to HTTP::Tiny, here, since
it's distributed with Perl since 5.14, unlike Net::HTTP
(which AFAIK was never a part of Perl proper).

But we really want to use Net::HTTP, here, since it's
lower-level and allows us to trigger server-side buffering
by not reading the entity body.
Diffstat (limited to 't')
-rw-r--r--t/git-http-backend.t5
1 files changed, 5 insertions, 0 deletions
diff --git a/t/git-http-backend.t b/t/git-http-backend.t
index 5ac0a4a5..fc2d5462 100644
--- a/t/git-http-backend.t
+++ b/t/git-http-backend.t
@@ -1,5 +1,8 @@
 # Copyright (C) 2016-2018 all contributors <meta@public-inbox.org>
 # License: AGPL-3.0+ <https://www.gnu.org/licenses/agpl-3.0.txt>
+#
+# Ensure buffering behavior in -httpd doesn't cause runaway memory use
+# or data corruption
 use strict;
 use warnings;
 use Test::More;
@@ -77,6 +80,8 @@ SKIP: {
         my ($code, $mess, %h) = $http->read_response_headers;
         is(200, $code, 'got 200 success for pack');
         is($max, $h{'Content-Length'}, 'got expected Content-Length for pack');
+
+        # no $http->read_entity_body, here, since we want to force buffering
         foreach my $i (1..3) {
                 sleep 1;
                 my $diff = $get_maxrss->() - $mem_a;