diff options
author | Eric W. Biederman <ebiederm@xmission.com> | 2018-07-30 00:04:45 -0500 |
---|---|---|
committer | Eric Wong <e@80x24.org> | 2018-07-30 08:06:42 +0000 |
commit | 8e0e850859fc9572cf201111728eaa621eace451 (patch) | |
tree | a0551ea7ecc6b0fd3c7b0ca25deafe6a1d33f546 /lib | |
parent | 466df3e029fecdabac373d73989c7fceebe6ae28 (diff) | |
download | public-inbox-8e0e850859fc9572cf201111728eaa621eace451.tar.gz |
While playing with git fast export I discovered that mixing <> and read would give inconsistent results. I tracked the issue down to using sysread in ProcessPipe instead of plain read. If it is desirable to use readline I can't see how using sysread can work as readline to be efficient needs to use buffered I/O. Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com>
Diffstat (limited to 'lib')
-rw-r--r-- | lib/PublicInbox/ProcessPipe.pm | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/lib/PublicInbox/ProcessPipe.pm b/lib/PublicInbox/ProcessPipe.pm index 7bb6ddee..2769e064 100644 --- a/lib/PublicInbox/ProcessPipe.pm +++ b/lib/PublicInbox/ProcessPipe.pm @@ -11,7 +11,7 @@ sub TIEHANDLE { bless { pid => $pid, fh => $fh }, $class; } -sub READ { sysread($_[0]->{fh}, $_[1], $_[2], $_[3] || 0) } +sub READ { read($_[0]->{fh}, $_[1], $_[2], $_[3] || 0) } sub READLINE { readline($_[0]->{fh}) } |