diff options
author | Eric Wong <e@yhbt.net> | 2020-04-03 21:06:20 +0000 |
---|---|---|
committer | Eric Wong <e@yhbt.net> | 2020-04-03 21:46:55 +0000 |
commit | 1a02e2d367b71eca9fc8093ce83fcae50873003d (patch) | |
tree | 99012da5753e87dca4293258d5e160d87b217b07 /lib/PublicInbox/View.pm | |
parent | fc92ce8845ac5f09939722537624fa48441f7c0b (diff) | |
download | public-inbox-1a02e2d367b71eca9fc8093ce83fcae50873003d.tar.gz |
These seem mostly harmless since Perl will just truncate the match and start a new one on a newline boundary in our case. The only downside is we'd end up with redundant <span> tags in HTML. Limiting the number of line matched ourselves with `{1,$NUM}' doesn't seem prudent since lines vary in length, so we continue to defer the job of limiting matches to the Perl regexp engine. I've noticed this warning in practice on 100K+ line patches to locale data.
Diffstat (limited to 'lib/PublicInbox/View.pm')
-rw-r--r-- | lib/PublicInbox/View.pm | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/lib/PublicInbox/View.pm b/lib/PublicInbox/View.pm index c42654b6..70c10604 100644 --- a/lib/PublicInbox/View.pm +++ b/lib/PublicInbox/View.pm @@ -576,7 +576,7 @@ sub add_text_body { # callback for msg_iter $s .= "\n" unless $s =~ /\n\z/s; # split off quoted and unquoted blocks: - my @sections = split(/((?:^>[^\n]*\n)+)/sm, $s); + my @sections = PublicInbox::MsgIter::split_quotes($s); $s = ''; my $rv = $ctx->{obuf}; if (defined($fn) || $depth > 0 || $err) { |