user/dev discussion of public-inbox itself
 help / color / Atom feed
From: Ali Alnubani <alialnu@mellanox.com>
To: Eric Wong <e@80x24.org>
Cc: "meta@public-inbox.org" <meta@public-inbox.org>
Subject: RE: [PATCH] searchview: avoid displaying full paths on errors
Date: Tue, 25 Jun 2019 07:33:51 +0000
Message-ID: <DB6PR0501MB2167E55E268AA2BCA3D7EA2DD7E30@DB6PR0501MB2167.eurprd05.prod.outlook.com> (raw)
In-Reply-To: <20190625063705.tugph4uyh3vetlkj@dcvr>

Thanks for the patch Eric.
I apologize for taking so long to update mine.

> -----Original Message-----
> From: Eric Wong <e@80x24.org>
> Sent: Tuesday, June 25, 2019 9:37 AM
> To: Ali Alnubani <alialnu@mellanox.com>
> Cc: meta@public-inbox.org
> Subject: [PATCH] searchview: avoid displaying full paths on errors
> 
> Displaying full path names of installed modules could expose unnecessary
> information about user home directory names or other potentially sensitive
> information.  However, displaying a module name could still be useful for
> diagnosing problems, so map full paths to the relevant part of the path name
> which is relevant to the package name.
> 
> Reported-by: Ali Alnubani <alialnu@mellanox.com>
> 
<removed>
> ---
>  lib/PublicInbox/SearchView.pm | 18 ++++++++++++++++++
>  1 file changed, 18 insertions(+)
> 
> diff --git a/lib/PublicInbox/SearchView.pm b/lib/PublicInbox/SearchView.pm
> index 6f07279b..a8b66dda 100644
> --- a/lib/PublicInbox/SearchView.pm
> +++ b/lib/PublicInbox/SearchView.pm
> @@ -15,6 +15,7 @@ use PublicInbox::MIME;  require PublicInbox::Git;
> require PublicInbox::SearchThread;  our $LIM = 200;
> +my %rmap_inc;
> 
>  sub noop {}
> 
> @@ -138,10 +139,27 @@ sub mset_summary {
>  	*noop;
>  }
> 
> +# shorten "/full/path/to/Foo/Bar.pm" to "Foo/Bar.pm" so error #
> +messages don't reveal FS layout info in case people use non-standard #
> +installation paths sub path2inc ($) {
> +	my $full = $_[0];
> +	if (my $short = $rmap_inc{$full}) {
> +		return $short;
> +	} elsif (!scalar(keys %rmap_inc) && -e $full) {
> +		%rmap_inc = map {; "$INC{$_}" => $_ } keys %INC;
> +		# fall back to basename as last resort
> +		$rmap_inc{$full} // (split('/', $full))[-1];
> +	} else {
> +		$full;
> +	}
> +}
> +
>  sub err_txt {
>  	my ($ctx, $err) = @_;
>  	my $u = $ctx->{-inbox}->base_url($ctx->{env}) . '_/text/help/';
>  	$err =~ s/^\s*Exception:\s*//; # bad word to show users :P
> +	$err =~ s!(\S+)!path2inc($1)!sge;
>  	$err = ascii_html($err);
>  	"\nBad query: <b>$err</b>\n" .
>  		qq{See <a\nhref="$u">$u</a> for help on using search};
> --
> EW

Thanks,
Ali

  reply index

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-11 19:38 [RFC] searchview: don't be too verbose about bad queries Eric Wong
2019-06-12  8:36 ` Ali Alnubani
2019-06-12 17:18   ` Eric Wong
2019-06-25  6:37     ` [PATCH] searchview: avoid displaying full paths on errors Eric Wong
2019-06-25  7:33       ` Ali Alnubani [this message]
2019-06-26  6:35         ` Eric Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://public-inbox.org/README

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DB6PR0501MB2167E55E268AA2BCA3D7EA2DD7E30@DB6PR0501MB2167.eurprd05.prod.outlook.com \
    --to=alialnu@mellanox.com \
    --cc=e@80x24.org \
    --cc=meta@public-inbox.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

user/dev discussion of public-inbox itself

Archives are clonable:
	git clone --mirror http://public-inbox.org/meta
	git clone --mirror http://czquwvybam4bgbro.onion/meta
	git clone --mirror http://hjrcffqmbrq6wope.onion/meta
	git clone --mirror http://ou63pmih66umazou.onion/meta

Example config snippet for mirrors

Newsgroups are available over NNTP:
	nntp://news.public-inbox.org/inbox.comp.mail.public-inbox.meta
	nntp://ou63pmih66umazou.onion/inbox.comp.mail.public-inbox.meta
	nntp://czquwvybam4bgbro.onion/inbox.comp.mail.public-inbox.meta
	nntp://hjrcffqmbrq6wope.onion/inbox.comp.mail.public-inbox.meta
	nntp://news.gmane.io/gmane.mail.public-inbox.general

 note: .onion URLs require Tor: https://www.torproject.org/

AGPL code for this site: git clone https://public-inbox.org/public-inbox.git