user/dev discussion of public-inbox itself
 help / color / Atom feed
From: Eric Wong <e@80x24.org>
To: Ali Alnubani <alialnu@mellanox.com>
Cc: meta@public-inbox.org
Subject: Re: [PATCH] searchview: avoid displaying full paths on errors
Date: Wed, 26 Jun 2019 06:35:04 +0000
Message-ID: <20190626063504.opzyiqyuhtgcfuwo@dcvr> (raw)
In-Reply-To: <DB6PR0501MB2167E55E268AA2BCA3D7EA2DD7E30@DB6PR0501MB2167.eurprd05.prod.outlook.com>

Ali Alnubani <alialnu@mellanox.com> wrote:
> Thanks for the patch Eric.
> I apologize for taking so long to update mine.

No worries.  Pushed as c19a4e88f49ba3496751c4b87ebcfa0f6b47f0ce

> >  sub err_txt {
> >  	my ($ctx, $err) = @_;
> >  	my $u = $ctx->{-inbox}->base_url($ctx->{env}) . '_/text/help/';
> >  	$err =~ s/^\s*Exception:\s*//; # bad word to show users :P
> > +	$err =~ s!(\S+)!path2inc($1)!sge;

One potential issue is this won't match paths if somebody has
spaces in their installation paths.  But I suppose few
distros or users building their own Perl are that strange...

      reply index

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-11 19:38 [RFC] searchview: don't be too verbose about bad queries Eric Wong
2019-06-12  8:36 ` Ali Alnubani
2019-06-12 17:18   ` Eric Wong
2019-06-25  6:37     ` [PATCH] searchview: avoid displaying full paths on errors Eric Wong
2019-06-25  7:33       ` Ali Alnubani
2019-06-26  6:35         ` Eric Wong [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://public-inbox.org/README

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190626063504.opzyiqyuhtgcfuwo@dcvr \
    --to=e@80x24.org \
    --cc=alialnu@mellanox.com \
    --cc=meta@public-inbox.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

user/dev discussion of public-inbox itself

Archives are clonable:
	git clone --mirror http://public-inbox.org/meta
	git clone --mirror http://czquwvybam4bgbro.onion/meta
	git clone --mirror http://hjrcffqmbrq6wope.onion/meta
	git clone --mirror http://ou63pmih66umazou.onion/meta

Example config snippet for mirrors

Newsgroups are available over NNTP:
	nntp://news.public-inbox.org/inbox.comp.mail.public-inbox.meta
	nntp://ou63pmih66umazou.onion/inbox.comp.mail.public-inbox.meta
	nntp://czquwvybam4bgbro.onion/inbox.comp.mail.public-inbox.meta
	nntp://hjrcffqmbrq6wope.onion/inbox.comp.mail.public-inbox.meta
	nntp://news.gmane.io/gmane.mail.public-inbox.general

 note: .onion URLs require Tor: https://www.torproject.org/

AGPL code for this site: git clone https://public-inbox.org/public-inbox.git