[PATCH] searchidx: correct warning for over-vivification

[PATCH] searchidx: correct warning for over-vivification

[Eric Wong (Contractor, The Linux Foundation)]

We will vivify multiple ghosts if a message has multiple
Message-IDs.
---
 lib/PublicInbox/SearchIdx.pm | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/lib/PublicInbox/SearchIdx.pm b/lib/PublicInbox/SearchIdx.pm
index a234c8c..c75a4ce 100644
--- a/lib/PublicInbox/SearchIdx.pm
+++ b/lib/PublicInbox/SearchIdx.pm
@@ -544,9 +544,9 @@ sub link_and_save {
 	$doc->add_boolean_term('XPATH' . $xpath) if defined $xpath;
 	$doc->add_boolean_term('Q' . $_) foreach @$mids;
 
-	my $vivified = 0;
 	$self->{skel} and die "Should not have read-only skel here\n";;
 	foreach my $mid (@$mids) {
+		my $vivified = 0;
 		$self->each_smsg_by_mid($mid, sub {
 			my ($cur) = @_;
 			my $type = $cur->type;
@@ -568,10 +568,8 @@ sub link_and_save {
 			++$vivified;
 			1;
 		});
-	}
-	if ($vivified > 1) {
-		my $id = '<'.join('> <', @$mids).'>';
-		warn "BUG: vivified multiple ($vivified) ghosts for $id\n";
+		$vivified > 1 and warn
+			"BUG: vivified multiple ($vivified) ghosts for $mid\n";
 	}
 	# not really important, but we return any vivified ghost docid, here:
 	return $doc_id if defined $doc_id;
-- 
EW