From: Junio C Hamano <gitster@pobox.com>
To: Eric Sunshine <sunshine@sunshineco.com>
Cc: Pratyush Yadav <me@yadavpratyush.com>,
Git List <git@vger.kernel.org>,
Jonathan Gilbert <JonathanG@iqmetrix.com>
Subject: Re: [PATCH v1 0/2] git-gui: reduce Tcl version requirement from 8.6 to 8.5
Date: Mon, 16 Mar 2020 08:48:15 -0700 [thread overview]
Message-ID: <xmqqwo7k8fnk.fsf@gitster.c.googlers.com> (raw)
In-Reply-To: <CAPig+cRXD_bjUL6=daEAx7VnAy_nw9bao6rLK9xwTCYJSk48Qw@mail.gmail.com> (Eric Sunshine's message of "Sun, 15 Mar 2020 14:54:07 -0400")
Eric Sunshine <sunshine@sunshineco.com> writes:
> On Sat, Mar 14, 2020 at 9:47 PM Pratyush Yadav <me@yadavpratyush.com> wrote:
>> Some MacOS distributions ship with Tcl 8.5. This means we can't use
>> TclOO. So, use our homegrown class.tcl instead.
>
> It should be mentioned that this patch series fixes a regression in
> Git v2.25 in which git-gui could not even be launched on Mac OS. The
> problem was reported here[1] a couple months ago.
>
> I performed some rudimentary testing of this patch series on Mac OS,
> and it appears to be working as expected; it certainly fixes the
> problem of git-gui not launching on Mac OS. (I did notice a
> misbehavior related to the original patch which caused git-gui to be
> unusable on Mac OS in v2.25, but I suspect that misbehavior is not
> related to or caused by this patch series, thus shouldn't prevent its
> acceptance.)
I was actually hesitant to see this kind of change for the first
time this late in the cycle (the code may work with old Tcl/Tk but
do we know it does with newer ones?)
I'll pull git-gui updates when Pratyush tells me to, which would
happen before the final (scheduled on 22nd). I'll trust git-gui
maintainer's decision to include these changes in it, or to cook
longer to wait for the 2.27 cycle. Comments like yours that help
Pratyush make the right judgment is greatly appreciated.
Thanks.
next prev parent reply other threads:[~2020-03-16 15:48 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-14 22:41 [PATCH v1 0/2] git-gui: reduce Tcl version requirement from 8.6 to 8.5 Pratyush Yadav
2020-03-14 22:41 ` [PATCH v1 1/2] " Pratyush Yadav
2020-03-14 22:41 ` [PATCH v1 2/2] git-gui: create a new namespace for chord script evaluation Pratyush Yadav
2020-03-15 18:54 ` [PATCH v1 0/2] git-gui: reduce Tcl version requirement from 8.6 to 8.5 Eric Sunshine
2020-03-16 15:48 ` Junio C Hamano [this message]
2020-03-17 12:49 ` Pratyush Yadav
2020-03-19 15:25 ` Eric Sunshine
2020-03-17 13:29 ` [PATCH v2 " Pratyush Yadav
2020-03-17 13:29 ` [PATCH v2 1/2] " Pratyush Yadav
2020-03-17 13:29 ` [PATCH v2 2/2] git-gui: create a new namespace for chord script evaluation Pratyush Yadav
2020-03-19 15:22 ` [PATCH v2 0/2] git-gui: reduce Tcl version requirement from 8.6 to 8.5 Eric Sunshine
2020-03-19 16:05 ` Pratyush Yadav
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqwo7k8fnk.fsf@gitster.c.googlers.com \
--to=gitster@pobox.com \
--cc=JonathanG@iqmetrix.com \
--cc=git@vger.kernel.org \
--cc=me@yadavpratyush.com \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).