git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Pratyush Yadav <me@yadavpratyush.com>
To: <git@vger.kernel.org>
Cc: Jonathan Gilbert <JonathanG@iQmetrix.com>,
	Eric Sunshine <sunshine@sunshineco.com>,
	Pratyush Yadav <me@yadavpratyush.com>
Subject: [PATCH v2 0/2] git-gui: reduce Tcl version requirement from 8.6 to 8.5
Date: Tue, 17 Mar 2020 18:59:19 +0530	[thread overview]
Message-ID: <20200317132921.7222-1-me@yadavpratyush.com> (raw)
In-Reply-To: <20200314224159.14174-1-me@yadavpratyush.com>

Hi,

Some MacOS distributions ship with Tcl 8.5. This means we can't use
TclOO. So, use our homegrown class.tcl instead.

While here, fix a potential variable name collision by creating a
separate namespace for a chord's script evaluation.

Jonathan,

Can you please test the patches the same way you tested your original
series just to be sure we don't break anything? A review would also be
nice.

Changes in v2:
- Add a note _after_ checking if the user agreed to the deletion.
  Otherwise, if the user denies, two "zombie" notes are left lying
  around which will never be activated. This means that the chord won't
  complete and the index won't be unlocked, leading to git-gui becoming
  frozen.

Pratyush Yadav (2):
  git-gui: reduce Tcl version requirement from 8.6 to 8.5
  git-gui: create a new namespace for chord script evaluation

 git-gui.sh    |  4 ++--
 lib/chord.tcl | 56 +++++++++++++++++++++++++--------------------------
 lib/index.tcl | 10 +++++----
 3 files changed, 35 insertions(+), 35 deletions(-)

--
2.26.0.rc1.11.g30e9940356


  parent reply	other threads:[~2020-03-17 13:29 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-14 22:41 [PATCH v1 0/2] git-gui: reduce Tcl version requirement from 8.6 to 8.5 Pratyush Yadav
2020-03-14 22:41 ` [PATCH v1 1/2] " Pratyush Yadav
2020-03-14 22:41 ` [PATCH v1 2/2] git-gui: create a new namespace for chord script evaluation Pratyush Yadav
2020-03-15 18:54 ` [PATCH v1 0/2] git-gui: reduce Tcl version requirement from 8.6 to 8.5 Eric Sunshine
2020-03-16 15:48   ` Junio C Hamano
2020-03-17 12:49     ` Pratyush Yadav
2020-03-19 15:25       ` Eric Sunshine
2020-03-17 13:29 ` Pratyush Yadav [this message]
2020-03-17 13:29   ` [PATCH v2 1/2] " Pratyush Yadav
2020-03-17 13:29   ` [PATCH v2 2/2] git-gui: create a new namespace for chord script evaluation Pratyush Yadav
2020-03-19 15:22   ` [PATCH v2 0/2] git-gui: reduce Tcl version requirement from 8.6 to 8.5 Eric Sunshine
2020-03-19 16:05     ` Pratyush Yadav

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200317132921.7222-1-me@yadavpratyush.com \
    --to=me@yadavpratyush.com \
    --cc=JonathanG@iQmetrix.com \
    --cc=git@vger.kernel.org \
    --cc=sunshine@sunshineco.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).