From: Junio C Hamano <gitster@pobox.com>
To: Elijah Newren <newren@gmail.com>
Cc: "Duy Nguyen" <pclouds@gmail.com>,
"Marc Branchaud" <marcnarc@xiplink.com>,
"Robin H. Johnson" <robbat2@gentoo.org>,
"Git Mailing List" <git@vger.kernel.org>,
"Michał Górny" <mgorny@gentoo.org>, "Jeff King" <peff@peff.net>,
"Lars Schneider" <larsxschneider@gmail.com>,
"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Subject: Re: [RFC PATCH] checkout: Force matching mtime between files
Date: Mon, 30 Apr 2018 08:47:07 +0900 [thread overview]
Message-ID: <xmqqtvrtzibo.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <CABPp-BGPA5BVh7NpBeat+9f0-=ryNg61tf1osgKXGLGDBN1U6w@mail.gmail.com> (Elijah Newren's message of "Fri, 27 Apr 2018 14:08:06 -0700")
Elijah Newren <newren@gmail.com> writes:
> Here's a crazy idea -- maybe instead of a list of pathspecs you just
> provide the timestamp of when git checkout started. Then the hook
> could walk the tree, find all files with modification times at least
> that late, and modify them all back to the the timestamp of when the
> git checkout started.
>
> Would that be enough? Is that too crazy?
>
> Sure, people could concurrently edit a file or run another program
> that modified files, but if you're doing that you're already playing
> race games with whether your next incremental build is going to be
> able to be correct. (Some (annoying) IDEs explicitly lock you out
> from editing files during a build to attempt to avoid this very
> problem.)
>
> That does leave one other caveat: If people intentionally do really
> weird stuff with having files with modification timestamps far in the
> future. However, it seems likely that the group of people doing that,
> if non-zero in number, is likely to be dis-joint with the group of
> folks that want this special
> uniform-timestamp-across-files-in-a-checkout behavior.
These two groups may share the same degree of insanity ;-)
But the single timestamp idea certainly sounds workable, except that
care must be taken to make sure we really grab the fs timestamp (it
is not uncommon for ">F; stat F" to yield quite different time from
"date", when the filesystem is on a remote box).
next prev parent reply other threads:[~2018-04-29 23:47 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-13 17:01 [RFC PATCH] checkout: Force matching mtime between files Michał Górny
2018-04-23 20:07 ` Robin H. Johnson
2018-04-23 23:41 ` Junio C Hamano
2018-04-25 7:13 ` Robin H. Johnson
2018-04-25 8:48 ` Junio C Hamano
2018-04-25 15:18 ` Marc Branchaud
2018-04-25 20:07 ` Robin H. Johnson
2018-04-26 1:25 ` Junio C Hamano
2018-04-26 14:12 ` Marc Branchaud
2018-04-26 14:46 ` Michał Górny
2018-04-28 14:23 ` Duy Nguyen
2018-04-28 19:35 ` Michał Górny
2018-04-26 16:43 ` Duy Nguyen
2018-04-26 17:48 ` Robin H. Johnson
2018-04-26 18:44 ` Duy Nguyen
2018-04-29 23:56 ` Junio C Hamano
2018-04-30 15:10 ` Duy Nguyen
2018-04-27 17:03 ` Duy Nguyen
2018-04-27 21:08 ` Elijah Newren
2018-04-28 6:08 ` Duy Nguyen
2018-04-29 23:47 ` Junio C Hamano [this message]
2018-04-27 21:08 ` Marc Branchaud
2018-04-28 6:16 ` Duy Nguyen
2018-04-27 17:18 ` Michał Górny
2018-04-27 19:53 ` Ævar Arnfjörð Bjarmason
2018-04-25 8:41 ` Ævar Arnfjörð Bjarmason
2018-04-26 17:15 ` Duy Nguyen
2018-04-26 17:51 ` Robin H. Johnson
2018-04-26 17:53 ` SZEDER Gábor
2018-04-26 18:45 ` Duy Nguyen
2018-04-24 14:41 ` Marc Branchaud
2018-04-25 6:58 ` Robin H. Johnson
2018-04-25 7:13 ` Michał Górny
2018-05-05 18:44 ` Jeff King
2018-05-06 3:37 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqtvrtzibo.fsf@gitster-ct.c.googlers.com \
--to=gitster@pobox.com \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=larsxschneider@gmail.com \
--cc=marcnarc@xiplink.com \
--cc=mgorny@gentoo.org \
--cc=newren@gmail.com \
--cc=pclouds@gmail.com \
--cc=peff@peff.net \
--cc=robbat2@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).