From: "Robin H. Johnson" <robbat2@gentoo.org>
To: "Michał Górny" <mgorny@gentoo.org>,
"Git Mailing List" <git@vger.kernel.org>
Subject: Re: [RFC PATCH] checkout: Force matching mtime between files
Date: Wed, 25 Apr 2018 06:58:51 +0000 [thread overview]
Message-ID: <robbat2-20180425T065446-231760424Z@orbis-terrarum.net> (raw)
In-Reply-To: <20180413170129.15310-1-mgorny@gentoo.org>
[-- Attachment #1: Type: text/plain, Size: 888 bytes --]
On Fri, Apr 13, 2018 at 07:01:29PM +0200, Michał Górny wrote:
> --- a/entry.c
> +++ b/entry.c
> @@ -411,6 +411,7 @@ int checkout_entry(struct cache_entry *ce,
> {
> static struct strbuf path = STRBUF_INIT;
> struct stat st;
> + int ret;
>
> if (topath)
> return write_entry(ce, topath, state, 1);
mgorny: Should the topath case trigger utime as well?
Other questions:
- Would there be be any value in hoisting the utime change into
write_entry's finish block rather than having it in checkout_entry?
- Should mtimes on directories be set if the directory is explicitly
created?
- Maybe using futimens on supported platforms?
--
Robin Hugh Johnson
Gentoo Linux: Dev, Infra Lead, Foundation Treasurer
E-Mail : robbat2@gentoo.org
GnuPG FP : 11ACBA4F 4778E3F6 E4EDF38E B27B944E 34884E85
GnuPG FP : 7D0B3CEB E9B85B1F 825BCECF EE05E6F6 A48F6136
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 1113 bytes --]
next prev parent reply other threads:[~2018-04-25 6:58 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-13 17:01 [RFC PATCH] checkout: Force matching mtime between files Michał Górny
2018-04-23 20:07 ` Robin H. Johnson
2018-04-23 23:41 ` Junio C Hamano
2018-04-25 7:13 ` Robin H. Johnson
2018-04-25 8:48 ` Junio C Hamano
2018-04-25 15:18 ` Marc Branchaud
2018-04-25 20:07 ` Robin H. Johnson
2018-04-26 1:25 ` Junio C Hamano
2018-04-26 14:12 ` Marc Branchaud
2018-04-26 14:46 ` Michał Górny
2018-04-28 14:23 ` Duy Nguyen
2018-04-28 19:35 ` Michał Górny
2018-04-26 16:43 ` Duy Nguyen
2018-04-26 17:48 ` Robin H. Johnson
2018-04-26 18:44 ` Duy Nguyen
2018-04-29 23:56 ` Junio C Hamano
2018-04-30 15:10 ` Duy Nguyen
2018-04-27 17:03 ` Duy Nguyen
2018-04-27 21:08 ` Elijah Newren
2018-04-28 6:08 ` Duy Nguyen
2018-04-29 23:47 ` Junio C Hamano
2018-04-27 21:08 ` Marc Branchaud
2018-04-28 6:16 ` Duy Nguyen
2018-04-27 17:18 ` Michał Górny
2018-04-27 19:53 ` Ævar Arnfjörð Bjarmason
2018-04-25 8:41 ` Ævar Arnfjörð Bjarmason
2018-04-26 17:15 ` Duy Nguyen
2018-04-26 17:51 ` Robin H. Johnson
2018-04-26 17:53 ` SZEDER Gábor
2018-04-26 18:45 ` Duy Nguyen
2018-04-24 14:41 ` Marc Branchaud
2018-04-25 6:58 ` Robin H. Johnson [this message]
2018-04-25 7:13 ` Michał Górny
2018-05-05 18:44 ` Jeff King
2018-05-06 3:37 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=robbat2-20180425T065446-231760424Z@orbis-terrarum.net \
--to=robbat2@gentoo.org \
--cc=git@vger.kernel.org \
--cc=mgorny@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).