From: Junio C Hamano <gitster@pobox.com>
To: Andreas Heiduk <asheiduk@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH v2 2/2] Documentation: Link descriptions of -z to core.quotePath
Date: Tue, 28 Feb 2017 12:51:12 -0800 [thread overview]
Message-ID: <xmqqmvd6jayn.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <1487968676-6126-3-git-send-email-asheiduk@gmail.com> (Andreas Heiduk's message of "Fri, 24 Feb 2017 21:37:56 +0100")
Andreas Heiduk <asheiduk@gmail.com> writes:
> diff --git a/Documentation/diff-options.txt b/Documentation/diff-options.txt
> index e6215c3..7c28e73 100644
> --- a/Documentation/diff-options.txt
> +++ b/Documentation/diff-options.txt
> @@ -192,10 +192,9 @@ ifndef::git-log[]
> given, do not munge pathnames and use NULs as output field terminators.
> endif::git-log[]
> +
> -Without this option, each pathname output will have TAB, LF, double quotes,
> -and backslash characters replaced with `\t`, `\n`, `\"`, and `\\`,
> -respectively, and the pathname will be enclosed in double quotes if
> -any of those replacements occurred.
> +Without this option, pathnames with "unusual" characters are munged as
> +explained for the configuration variable `core.quotePath` (see
> +linkgit:git-config[1]).
Seeing that many other instances call this "quoted", we may want to
be consistent. I can see "munge" in the pre-context, but that one
can stay as is. Under -z, no modification/munging happens. With -z,
a specific kind of modification (called "quote" described in the
documentation for core.quotepath variable) happens. The same
comment applies to the change to Documentation/git-apply.txt
Otherwise the patch looks good.
Thanks.
next prev parent reply other threads:[~2017-02-28 20:53 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-19 22:05 [PATCH] Documentation: Link git-ls-files to core.quotePath variable Andreas Heiduk
2017-02-21 20:48 ` Junio C Hamano
2017-02-22 1:20 ` Andreas Heiduk
2017-02-22 1:38 ` Andreas Heiduk
2017-02-22 12:21 ` Philip Oakley
2017-02-22 21:02 ` Junio C Hamano
2017-02-22 21:08 ` Andreas Heiduk
2017-02-24 20:37 ` [PATCH v2 0/2] " Andreas Heiduk
2017-02-24 20:37 ` [PATCH v2 1/2] Documentation: Improve description for core.quotePath Andreas Heiduk
2017-02-24 21:43 ` Jakub Narębski
2017-02-28 20:55 ` Andreas Heiduk
2017-02-24 20:37 ` [PATCH v2 2/2] Documentation: Link descriptions of -z to core.quotePath Andreas Heiduk
2017-02-24 21:54 ` Jakub Narębski
2017-02-28 21:30 ` Andreas Heiduk
2017-02-28 20:51 ` Junio C Hamano [this message]
2017-02-28 21:13 ` Andreas Heiduk
2017-02-28 21:25 ` Junio C Hamano
2017-02-22 17:41 ` [PATCH] Documentation: Link git-ls-files to core.quotePath variable Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqmvd6jayn.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=asheiduk@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).