From: Andreas Heiduk <asheiduk@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Documentation: Link git-ls-files to core.quotePath variable.
Date: Wed, 22 Feb 2017 02:20:00 +0100 [thread overview]
Message-ID: <61a3e1a7-e70c-cb68-184f-95dff28d1271@gmail.com> (raw)
In-Reply-To: <xmqqh93nfeyj.fsf@gitster.mtv.corp.google.com>
Am 21.02.2017 um 21:48 schrieb Junio C Hamano:
>
> I was waiting for others to comment on this patch but nobody seems
> to be interested. Which is a bit sad, as this may not be a bad
> idea.
>
> If we refer to core.quotePath, the mention of control characters
> being quoted can also be omitted, I think, as that is part of what
> appears in the description of core.quotePath variable.
>
> Alternatively, instead of referring to another page, we can spend
> the additional lines to say what is more interesting to most of the
> readers from that page, e.g.
>
> When `-z` option is not used, a pathname with "unusual" characters
> in it is quoted by enclosing it in a double-quote pair and with
> backslashes the same way strings in C source code are quoted. By
> setting core.quotePath configuration to false, the bytes whose
> values are higher than 0x80 are output verbatim.
>
Without `-z` but with core.quotePath=false the path may still be
surrounded with double-quotes if it contains control characters (and
some more). The documentation in `core.quotePath` mentions this, your
"inline" alternative does not.
I will send second patch. :-)
next prev parent reply other threads:[~2017-02-22 1:20 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-19 22:05 [PATCH] Documentation: Link git-ls-files to core.quotePath variable Andreas Heiduk
2017-02-21 20:48 ` Junio C Hamano
2017-02-22 1:20 ` Andreas Heiduk [this message]
2017-02-22 1:38 ` Andreas Heiduk
2017-02-22 12:21 ` Philip Oakley
2017-02-22 21:02 ` Junio C Hamano
2017-02-22 21:08 ` Andreas Heiduk
2017-02-24 20:37 ` [PATCH v2 0/2] " Andreas Heiduk
2017-02-24 20:37 ` [PATCH v2 1/2] Documentation: Improve description for core.quotePath Andreas Heiduk
2017-02-24 21:43 ` Jakub Narębski
2017-02-28 20:55 ` Andreas Heiduk
2017-02-24 20:37 ` [PATCH v2 2/2] Documentation: Link descriptions of -z to core.quotePath Andreas Heiduk
2017-02-24 21:54 ` Jakub Narębski
2017-02-28 21:30 ` Andreas Heiduk
2017-02-28 20:51 ` Junio C Hamano
2017-02-28 21:13 ` Andreas Heiduk
2017-02-28 21:25 ` Junio C Hamano
2017-02-22 17:41 ` [PATCH] Documentation: Link git-ls-files to core.quotePath variable Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=61a3e1a7-e70c-cb68-184f-95dff28d1271@gmail.com \
--to=asheiduk@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).