git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
* Is cover letter can save changes?
@ 2020-10-20  7:05 fuyao
  2020-10-20 10:23 ` Pratyush Yadav
  0 siblings, 1 reply; 3+ messages in thread
From: fuyao @ 2020-10-20  7:05 UTC (permalink / raw)
  To: git; +Cc: 黄臻炜

Hi:
   i have question about format-patch.

   when use git format-patch with --cover-letter, we add information
   in the cover letter. and then, i must send patch with -v2, the
   information in the cover letter is lost in the v2 patch.

   i found git notes can note things, but it add in patch not
   cover letter. is some operate can do to save in cover letter.

   and the git note record with commit, when amend it can lost note,
   is the rewrite error?
-- 
Nimflorie frostades seda!

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: Is cover letter can save changes?
  2020-10-20  7:05 Is cover letter can save changes? fuyao
@ 2020-10-20 10:23 ` Pratyush Yadav
  2020-10-20 19:21   ` Junio C Hamano
  0 siblings, 1 reply; 3+ messages in thread
From: Pratyush Yadav @ 2020-10-20 10:23 UTC (permalink / raw)
  To: fuyao; +Cc: git, 黄臻炜

On Tue, Oct 20 2020, fuyao wrote:

> Hi:
>    i have question about format-patch.
>
>    when use git format-patch with --cover-letter, we add information
>    in the cover letter. and then, i must send patch with -v2, the
>    information in the cover letter is lost in the v2 patch.
>
>    i found git notes can note things, but it add in patch not
>    cover letter. is some operate can do to save in cover letter.

You can try using `git branch --edit-description <branch_name>` and
write the contents of the cover letter there. Then you can use the
option `--cover-from-description` to use the branch description when
generating the cover letter.

>    and the git note record with commit, when amend it can lost note,
>    is the rewrite error?

Have you set the config `notes.rewriteRef` to your notes ref?

-- 
Regards,
Pratyush Yadav

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: Is cover letter can save changes?
  2020-10-20 10:23 ` Pratyush Yadav
@ 2020-10-20 19:21   ` Junio C Hamano
  0 siblings, 0 replies; 3+ messages in thread
From: Junio C Hamano @ 2020-10-20 19:21 UTC (permalink / raw)
  To: Pratyush Yadav; +Cc: fuyao, git, 黄臻炜

Pratyush Yadav <me@yadavpratyush.com> writes:

> On Tue, Oct 20 2020, fuyao wrote:
>
>> Hi:
>>    i have question about format-patch.
>>
>>    when use git format-patch with --cover-letter, we add information
>>    in the cover letter. and then, i must send patch with -v2, the
>>    information in the cover letter is lost in the v2 patch.
> ...
> You can try using `git branch --edit-description <branch_name>` and
> write the contents of the cover letter there. Then you can use the
> option `--cover-from-description` to use the branch description when
> generating the cover letter.

Another thing people are encouraged to do is to use the -o option to
store iterations of your series on disk, perhaps in the same
directory.  When you edit v2-0000-cover-letter.txt file, you can
then reference the previous one you've already sent easily that way.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-10-20 19:21 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-20  7:05 Is cover letter can save changes? fuyao
2020-10-20 10:23 ` Pratyush Yadav
2020-10-20 19:21   ` Junio C Hamano

Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).