git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "James Shubin via GitGitGadget" <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org, James Shubin <james@shubin.ca>
Subject: Re: [PATCH 1/1] contrib: Add --recursive flag for bash completion
Date: Wed, 13 Nov 2019 12:45:41 +0900	[thread overview]
Message-ID: <xmqqlfskbfru.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <ac8cb233ecea69d46ba5a0af0e63bc7c03963cbf.1573606072.git.gitgitgadget@gmail.com> (James Shubin via GitGitGadget's message of "Wed, 13 Nov 2019 00:47:52 +0000")

"James Shubin via GitGitGadget" <gitgitgadget@gmail.com> writes:

> From: James Shubin <james@shubin.ca>
> Subject: Re: [PATCH 1/1] contrib: Add --recursive flag for bash completion

The title must make it clear which git subcommand learned the
"--recursive" (unless the patch adds it to everything, that is).

    Subject: [PATCH] completion: tab-complete "git svn --recursive"

By the way, it is pointless to send a cover letter for a single
patch topic like this; you may want to tell GGG not to do so.

> This flag was missing from the list, and I use it quite often :)

Makes sense.

Thanks.  Will queue with title updated locally.

>
> Signed-off-by: James Shubin <james@shubin.ca>
> ---
>  contrib/completion/git-completion.bash | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
> index 00fbe6c03d..79fe29ef03 100644
> --- a/contrib/completion/git-completion.bash
> +++ b/contrib/completion/git-completion.bash
> @@ -2843,6 +2843,7 @@ _git_svn ()
>  			--log-window-size= --no-checkout --quiet
>  			--repack-flags --use-log-author --localtime
>  			--add-author-from
> +			--recursive
>  			--ignore-paths= --include-paths= $remote_opts
>  			"
>  		local init_opts="

  reply	other threads:[~2019-11-13  3:45 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-13  0:47 [PATCH 0/1] contrib: Add --recursive flag for bash completion James via GitGitGadget
2019-11-13  0:47 ` [PATCH 1/1] " James Shubin via GitGitGadget
2019-11-13  3:45   ` Junio C Hamano [this message]
2019-11-13 10:17     ` Johannes Schindelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqlfskbfru.fsf@gitster-ct.c.googlers.com \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=gitgitgadget@gmail.com \
    --cc=james@shubin.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).