git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Junio C Hamano <gitster@pobox.com>
Cc: James Shubin via GitGitGadget <gitgitgadget@gmail.com>,
	git@vger.kernel.org, James Shubin <james@shubin.ca>
Subject: Re: [PATCH 1/1] contrib: Add --recursive flag for bash completion
Date: Wed, 13 Nov 2019 11:17:36 +0100 (CET)	[thread overview]
Message-ID: <nycvar.QRO.7.76.6.1911131116170.46@tvgsbejvaqbjf.bet> (raw)
In-Reply-To: <xmqqlfskbfru.fsf@gitster-ct.c.googlers.com>

Hi Junio,

On Wed, 13 Nov 2019, Junio C Hamano wrote:

> "James Shubin via GitGitGadget" <gitgitgadget@gmail.com> writes:
>
> > From: James Shubin <james@shubin.ca>
> > Subject: Re: [PATCH 1/1] contrib: Add --recursive flag for bash completion
>
> The title must make it clear which git subcommand learned the
> "--recursive" (unless the patch adds it to everything, that is).
>
>     Subject: [PATCH] completion: tab-complete "git svn --recursive"
>
> By the way, it is pointless to send a cover letter for a single
> patch topic like this; you may want to tell GGG not to do so.

In this instance, I totally agree. But in this instance, it would also
have made sense to at least scrub the PR description template before
sending. Also, it would have made sense to listen to Emily who suggested
to have another go at the commit message before sending.

Thanks,
Johannes

      reply	other threads:[~2019-11-13 10:18 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-13  0:47 [PATCH 0/1] contrib: Add --recursive flag for bash completion James via GitGitGadget
2019-11-13  0:47 ` [PATCH 1/1] " James Shubin via GitGitGadget
2019-11-13  3:45   ` Junio C Hamano
2019-11-13 10:17     ` Johannes Schindelin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=nycvar.QRO.7.76.6.1911131116170.46@tvgsbejvaqbjf.bet \
    --to=johannes.schindelin@gmx.de \
    --cc=git@vger.kernel.org \
    --cc=gitgitgadget@gmail.com \
    --cc=gitster@pobox.com \
    --cc=james@shubin.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).