* [PATCH 0/1] Avoid segmentation fault in git range-diff when diff.noprefix=true
@ 2019-10-02 18:05 Johannes Schindelin via GitGitGadget
2019-10-02 18:05 ` [PATCH 1/1] range-diff: internally force `diff.noprefix=false` Johannes Schindelin via GitGitGadget
2019-10-02 21:10 ` [PATCH v2 0/1] Avoid segmentation fault in git range-diff when diff.noprefix=true Johannes Schindelin via GitGitGadget
0 siblings, 2 replies; 11+ messages in thread
From: Johannes Schindelin via GitGitGadget @ 2019-10-02 18:05 UTC (permalink / raw)
To: git; +Cc: Johannes Schindelin, Junio C Hamano
This PR was inspired by this bug report:
https://public-inbox.org/git/20191002141615.GB17916@kitsune.suse.cz/T/#me576615d7a151cf2ed46186c482fbd88f9959914
Johannes Schindelin (1):
range-diff: internally force `diff.noprefix=false`
range-diff.c | 3 ++-
t/t3206-range-diff.sh | 4 ++++
2 files changed, 6 insertions(+), 1 deletion(-)
base-commit: bc12974a897308fd3254cf0cc90319078fe45eea
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-373%2Fdscho%2Frange-diff-requires-diff-prefix-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-373/dscho/range-diff-requires-diff-prefix-v1
Pull-Request: https://github.com/gitgitgadget/git/pull/373
--
gitgitgadget
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH 1/1] range-diff: internally force `diff.noprefix=false`
2019-10-02 18:05 [PATCH 0/1] Avoid segmentation fault in git range-diff when diff.noprefix=true Johannes Schindelin via GitGitGadget
@ 2019-10-02 18:05 ` Johannes Schindelin via GitGitGadget
2019-10-02 18:34 ` Eric Sunshine
` (2 more replies)
2019-10-02 21:10 ` [PATCH v2 0/1] Avoid segmentation fault in git range-diff when diff.noprefix=true Johannes Schindelin via GitGitGadget
1 sibling, 3 replies; 11+ messages in thread
From: Johannes Schindelin via GitGitGadget @ 2019-10-02 18:05 UTC (permalink / raw)
To: git; +Cc: Johannes Schindelin, Junio C Hamano, Johannes Schindelin
From: Johannes Schindelin <johannes.schindelin@gmx.de>
When parsing the diffs, `range-diff` expects to see the prefixes `a/`
and `b/` in the diff headers.
These prefixes can be forced off via the config setting
`diff.noprefix=true`. As `range-diff` is not prepared for that
situation, this will cause a segmentation fault.
Let's avoid that by forcing `diff.noprefix=false` just for that all to
`git log` that generates the diffs that `range-diff` wants to parse.
Noticed-by: Michal Suchánek <msuchanek@suse.de>
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
---
range-diff.c | 3 ++-
t/t3206-range-diff.sh | 4 ++++
2 files changed, 6 insertions(+), 1 deletion(-)
diff --git a/range-diff.c b/range-diff.c
index ba1e9a4265..8cc348b4cb 100644
--- a/range-diff.c
+++ b/range-diff.c
@@ -50,7 +50,8 @@ static int read_patches(const char *range, struct string_list *list)
int offset, len;
size_t size;
- argv_array_pushl(&cp.args, "log", "--no-color", "-p", "--no-merges",
+ argv_array_pushl(&cp.args, "-c", "diff.noprefix=false",
+ "log", "--no-color", "-p", "--no-merges",
"--reverse", "--date-order", "--decorate=no",
/*
* Choose indicators that are not used anywhere
diff --git a/t/t3206-range-diff.sh b/t/t3206-range-diff.sh
index 0120f769f1..64b66f2094 100755
--- a/t/t3206-range-diff.sh
+++ b/t/t3206-range-diff.sh
@@ -461,4 +461,8 @@ test_expect_success 'format-patch --range-diff as commentary' '
grep "> 1: .* new message" 0001-*
'
+test_expect_success 'range-diff overrides diff.noprefix internally' '
+ git -c diff.noprefix=true range-diff HEAD^...
+'
+
test_done
--
gitgitgadget
^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [PATCH 1/1] range-diff: internally force `diff.noprefix=false`
2019-10-02 18:05 ` [PATCH 1/1] range-diff: internally force `diff.noprefix=false` Johannes Schindelin via GitGitGadget
@ 2019-10-02 18:34 ` Eric Sunshine
2019-10-02 19:56 ` Michal Suchánek
2019-10-02 20:06 ` Junio C Hamano
2 siblings, 0 replies; 11+ messages in thread
From: Eric Sunshine @ 2019-10-02 18:34 UTC (permalink / raw)
To: Johannes Schindelin via GitGitGadget
Cc: Git List, Johannes Schindelin, Junio C Hamano
On Wed, Oct 2, 2019 at 2:05 PM Johannes Schindelin via GitGitGadget
<gitgitgadget@gmail.com> wrote:
> When parsing the diffs, `range-diff` expects to see the prefixes `a/`
> and `b/` in the diff headers.
>
> These prefixes can be forced off via the config setting
> `diff.noprefix=true`. As `range-diff` is not prepared for that
> situation, this will cause a segmentation fault.
>
> Let's avoid that by forcing `diff.noprefix=false` just for that all to
s/all/call/
> `git log` that generates the diffs that `range-diff` wants to parse.
>
> Noticed-by: Michal Suchánek <msuchanek@suse.de>
s/Noticed/Reported/ perhaps?
> Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 1/1] range-diff: internally force `diff.noprefix=false`
2019-10-02 18:05 ` [PATCH 1/1] range-diff: internally force `diff.noprefix=false` Johannes Schindelin via GitGitGadget
2019-10-02 18:34 ` Eric Sunshine
@ 2019-10-02 19:56 ` Michal Suchánek
2019-10-02 20:06 ` Junio C Hamano
2 siblings, 0 replies; 11+ messages in thread
From: Michal Suchánek @ 2019-10-02 19:56 UTC (permalink / raw)
To: Johannes Schindelin via GitGitGadget
Cc: git, Johannes Schindelin, Junio C Hamano
On Wed, Oct 02, 2019 at 11:05:13AM -0700, Johannes Schindelin via GitGitGadget wrote:
> From: Johannes Schindelin <johannes.schindelin@gmx.de>
>
> When parsing the diffs, `range-diff` expects to see the prefixes `a/`
> and `b/` in the diff headers.
>
> These prefixes can be forced off via the config setting
> `diff.noprefix=true`. As `range-diff` is not prepared for that
> situation, this will cause a segmentation fault.
>
> Let's avoid that by forcing `diff.noprefix=false` just for that all to
> `git log` that generates the diffs that `range-diff` wants to parse.
>
> Noticed-by: Michal Suchánek <msuchanek@suse.de>
> Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Tested-by: Michal Suchánek <msuchanek@suse.de>
Thanks
Michal
> ---
> range-diff.c | 3 ++-
> t/t3206-range-diff.sh | 4 ++++
> 2 files changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/range-diff.c b/range-diff.c
> index ba1e9a4265..8cc348b4cb 100644
> --- a/range-diff.c
> +++ b/range-diff.c
> @@ -50,7 +50,8 @@ static int read_patches(const char *range, struct string_list *list)
> int offset, len;
> size_t size;
>
> - argv_array_pushl(&cp.args, "log", "--no-color", "-p", "--no-merges",
> + argv_array_pushl(&cp.args, "-c", "diff.noprefix=false",
> + "log", "--no-color", "-p", "--no-merges",
> "--reverse", "--date-order", "--decorate=no",
> /*
> * Choose indicators that are not used anywhere
> diff --git a/t/t3206-range-diff.sh b/t/t3206-range-diff.sh
> index 0120f769f1..64b66f2094 100755
> --- a/t/t3206-range-diff.sh
> +++ b/t/t3206-range-diff.sh
> @@ -461,4 +461,8 @@ test_expect_success 'format-patch --range-diff as commentary' '
> grep "> 1: .* new message" 0001-*
> '
>
> +test_expect_success 'range-diff overrides diff.noprefix internally' '
> + git -c diff.noprefix=true range-diff HEAD^...
> +'
> +
> test_done
> --
> gitgitgadget
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 1/1] range-diff: internally force `diff.noprefix=false`
2019-10-02 18:05 ` [PATCH 1/1] range-diff: internally force `diff.noprefix=false` Johannes Schindelin via GitGitGadget
2019-10-02 18:34 ` Eric Sunshine
2019-10-02 19:56 ` Michal Suchánek
@ 2019-10-02 20:06 ` Junio C Hamano
2019-10-02 20:30 ` Johannes Schindelin
2019-10-03 0:41 ` Junio C Hamano
2 siblings, 2 replies; 11+ messages in thread
From: Junio C Hamano @ 2019-10-02 20:06 UTC (permalink / raw)
To: Johannes Schindelin via GitGitGadget; +Cc: git, Johannes Schindelin
"Johannes Schindelin via GitGitGadget" <gitgitgadget@gmail.com>
writes:
> From: Johannes Schindelin <johannes.schindelin@gmx.de>
>
> When parsing the diffs, `range-diff` expects to see the prefixes `a/`
> and `b/` in the diff headers.
If so, passing src/dst prefix as command line option is a much
better solution, I think. diff.noprefix may not stay to be (or it
may already not to be) the only thing how the prefix gets chosen.
> - argv_array_pushl(&cp.args, "log", "--no-color", "-p", "--no-merges",
> + argv_array_pushl(&cp.args, "-c", "diff.noprefix=false",
> + "log", "--no-color", "-p", "--no-merges",
> "--reverse", "--date-order", "--decorate=no",
> /*
> * Choose indicators that are not used anywhere
> diff --git a/t/t3206-range-diff.sh b/t/t3206-range-diff.sh
> index 0120f769f1..64b66f2094 100755
> --- a/t/t3206-range-diff.sh
> +++ b/t/t3206-range-diff.sh
> @@ -461,4 +461,8 @@ test_expect_success 'format-patch --range-diff as commentary' '
> grep "> 1: .* new message" 0001-*
> '
>
> +test_expect_success 'range-diff overrides diff.noprefix internally' '
> + git -c diff.noprefix=true range-diff HEAD^...
> +'
> +
> test_done
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 1/1] range-diff: internally force `diff.noprefix=false`
2019-10-02 20:06 ` Junio C Hamano
@ 2019-10-02 20:30 ` Johannes Schindelin
2019-10-03 0:43 ` Junio C Hamano
2019-10-03 0:41 ` Junio C Hamano
1 sibling, 1 reply; 11+ messages in thread
From: Johannes Schindelin @ 2019-10-02 20:30 UTC (permalink / raw)
To: Junio C Hamano; +Cc: Johannes Schindelin via GitGitGadget, git
Hi Junio,
On Thu, 3 Oct 2019, Junio C Hamano wrote:
> "Johannes Schindelin via GitGitGadget" <gitgitgadget@gmail.com>
> writes:
>
> > From: Johannes Schindelin <johannes.schindelin@gmx.de>
> >
> > When parsing the diffs, `range-diff` expects to see the prefixes `a/`
> > and `b/` in the diff headers.
>
> If so, passing src/dst prefix as command line option is a much better
> solution, I think. diff.noprefix may not stay to be (or it may
> already not to be) the only thing how the prefix gets chosen.
Good point.
While at it, I invert the logic in v2: instead of forcing a prefix, I
now force no prefix (and reduce the strip level from 1 to 0 when parsing
the diff header).
Thanks,
Dscho
>
> > - argv_array_pushl(&cp.args, "log", "--no-color", "-p", "--no-merges",
> > + argv_array_pushl(&cp.args, "-c", "diff.noprefix=false",
> > + "log", "--no-color", "-p", "--no-merges",
> > "--reverse", "--date-order", "--decorate=no",
> > /*
> > * Choose indicators that are not used anywhere
> > diff --git a/t/t3206-range-diff.sh b/t/t3206-range-diff.sh
> > index 0120f769f1..64b66f2094 100755
> > --- a/t/t3206-range-diff.sh
> > +++ b/t/t3206-range-diff.sh
> > @@ -461,4 +461,8 @@ test_expect_success 'format-patch --range-diff as commentary' '
> > grep "> 1: .* new message" 0001-*
> > '
> >
> > +test_expect_success 'range-diff overrides diff.noprefix internally' '
> > + git -c diff.noprefix=true range-diff HEAD^...
> > +'
> > +
> > test_done
>
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH v2 0/1] Avoid segmentation fault in git range-diff when diff.noprefix=true
2019-10-02 18:05 [PATCH 0/1] Avoid segmentation fault in git range-diff when diff.noprefix=true Johannes Schindelin via GitGitGadget
2019-10-02 18:05 ` [PATCH 1/1] range-diff: internally force `diff.noprefix=false` Johannes Schindelin via GitGitGadget
@ 2019-10-02 21:10 ` Johannes Schindelin via GitGitGadget
2019-10-02 21:10 ` [PATCH v2 1/1] range-diff: internally force `diff.noprefix=true` Johannes Schindelin via GitGitGadget
1 sibling, 1 reply; 11+ messages in thread
From: Johannes Schindelin via GitGitGadget @ 2019-10-02 21:10 UTC (permalink / raw)
To: git
Cc: Eric Sunshine, Michal Suchánek, Johannes Schindelin,
Junio C Hamano
This PR was inspired by this bug report:
https://public-inbox.org/git/20191002141615.GB17916@kitsune.suse.cz/T/#me576615d7a151cf2ed46186c482fbd88f9959914
Changes since v1:
* Use a command-line option instead of a command-line config setting.
* Instead of forcing a prefix, force no prefix (and adjust the strip
level).
* Fix typo "all" -> "call" in the commit message (and adjust it to reflect
the other changes since v1, too).
Johannes Schindelin (1):
range-diff: internally force `diff.noprefix=true`
range-diff.c | 3 ++-
t/t3206-range-diff.sh | 4 ++++
2 files changed, 6 insertions(+), 1 deletion(-)
base-commit: bc12974a897308fd3254cf0cc90319078fe45eea
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-373%2Fdscho%2Frange-diff-requires-diff-prefix-v2
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-373/dscho/range-diff-requires-diff-prefix-v2
Pull-Request: https://github.com/gitgitgadget/git/pull/373
Range-diff vs v1:
1: 1f84f92846 ! 1: 9993a607be range-diff: internally force `diff.noprefix=false`
@@ -1,6 +1,6 @@
Author: Johannes Schindelin <johannes.schindelin@gmx.de>
- range-diff: internally force `diff.noprefix=false`
+ range-diff: internally force `diff.noprefix=true`
When parsing the diffs, `range-diff` expects to see the prefixes `a/`
and `b/` in the diff headers.
@@ -9,25 +9,33 @@
`diff.noprefix=true`. As `range-diff` is not prepared for that
situation, this will cause a segmentation fault.
- Let's avoid that by forcing `diff.noprefix=false` just for that all to
- `git log` that generates the diffs that `range-diff` wants to parse.
+ Let's avoid that by passing the `--no-prefix` option to the `git log`
+ process that generates the diffs that `range-diff` wants to parse.
+ And of course expect the output to have no prefixes, then.
- Noticed-by: Michal Suchánek <msuchanek@suse.de>
+ Reported-by: Michal Suchánek <msuchanek@suse.de>
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
diff --git a/range-diff.c b/range-diff.c
--- a/range-diff.c
+++ b/range-diff.c
@@
- int offset, len;
- size_t size;
-- argv_array_pushl(&cp.args, "log", "--no-color", "-p", "--no-merges",
-+ argv_array_pushl(&cp.args, "-c", "diff.noprefix=false",
-+ "log", "--no-color", "-p", "--no-merges",
+ argv_array_pushl(&cp.args, "log", "--no-color", "-p", "--no-merges",
"--reverse", "--date-order", "--decorate=no",
++ "--no-prefix",
/*
* Choose indicators that are not used anywhere
+ * else in diffs, but still look reasonable
+@@
+ if (!util->diff_offset)
+ util->diff_offset = buf.len;
+ line[len - 1] = '\n';
+- len = parse_git_diff_header(&root, &linenr, 1, line,
++ len = parse_git_diff_header(&root, &linenr, 0, line,
+ len, size, &patch);
+ if (len < 0)
+ die(_("could not parse git header '%.*s'"), (int)len, line);
diff --git a/t/t3206-range-diff.sh b/t/t3206-range-diff.sh
--- a/t/t3206-range-diff.sh
--
gitgitgadget
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH v2 1/1] range-diff: internally force `diff.noprefix=true`
2019-10-02 21:10 ` [PATCH v2 0/1] Avoid segmentation fault in git range-diff when diff.noprefix=true Johannes Schindelin via GitGitGadget
@ 2019-10-02 21:10 ` Johannes Schindelin via GitGitGadget
2019-10-03 2:11 ` Junio C Hamano
0 siblings, 1 reply; 11+ messages in thread
From: Johannes Schindelin via GitGitGadget @ 2019-10-02 21:10 UTC (permalink / raw)
To: git
Cc: Eric Sunshine, Michal Suchánek, Johannes Schindelin,
Junio C Hamano, Johannes Schindelin
From: Johannes Schindelin <johannes.schindelin@gmx.de>
When parsing the diffs, `range-diff` expects to see the prefixes `a/`
and `b/` in the diff headers.
These prefixes can be forced off via the config setting
`diff.noprefix=true`. As `range-diff` is not prepared for that
situation, this will cause a segmentation fault.
Let's avoid that by passing the `--no-prefix` option to the `git log`
process that generates the diffs that `range-diff` wants to parse.
And of course expect the output to have no prefixes, then.
Reported-by: Michal Suchánek <msuchanek@suse.de>
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
---
range-diff.c | 3 ++-
t/t3206-range-diff.sh | 4 ++++
2 files changed, 6 insertions(+), 1 deletion(-)
diff --git a/range-diff.c b/range-diff.c
index ba1e9a4265..f2fc1e02c2 100644
--- a/range-diff.c
+++ b/range-diff.c
@@ -52,6 +52,7 @@ static int read_patches(const char *range, struct string_list *list)
argv_array_pushl(&cp.args, "log", "--no-color", "-p", "--no-merges",
"--reverse", "--date-order", "--decorate=no",
+ "--no-prefix",
/*
* Choose indicators that are not used anywhere
* else in diffs, but still look reasonable
@@ -111,7 +112,7 @@ static int read_patches(const char *range, struct string_list *list)
if (!util->diff_offset)
util->diff_offset = buf.len;
line[len - 1] = '\n';
- len = parse_git_diff_header(&root, &linenr, 1, line,
+ len = parse_git_diff_header(&root, &linenr, 0, line,
len, size, &patch);
if (len < 0)
die(_("could not parse git header '%.*s'"), (int)len, line);
diff --git a/t/t3206-range-diff.sh b/t/t3206-range-diff.sh
index 0120f769f1..64b66f2094 100755
--- a/t/t3206-range-diff.sh
+++ b/t/t3206-range-diff.sh
@@ -461,4 +461,8 @@ test_expect_success 'format-patch --range-diff as commentary' '
grep "> 1: .* new message" 0001-*
'
+test_expect_success 'range-diff overrides diff.noprefix internally' '
+ git -c diff.noprefix=true range-diff HEAD^...
+'
+
test_done
--
gitgitgadget
^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [PATCH 1/1] range-diff: internally force `diff.noprefix=false`
2019-10-02 20:06 ` Junio C Hamano
2019-10-02 20:30 ` Johannes Schindelin
@ 2019-10-03 0:41 ` Junio C Hamano
1 sibling, 0 replies; 11+ messages in thread
From: Junio C Hamano @ 2019-10-03 0:41 UTC (permalink / raw)
To: Johannes Schindelin via GitGitGadget; +Cc: git, Johannes Schindelin
Junio C Hamano <gitster@pobox.com> writes:
> "Johannes Schindelin via GitGitGadget" <gitgitgadget@gmail.com>
> writes:
>
>> From: Johannes Schindelin <johannes.schindelin@gmx.de>
>>
>> When parsing the diffs, `range-diff` expects to see the prefixes `a/`
>> and `b/` in the diff headers.
>
> If so, passing src/dst prefix as command line option is a much
> better solution, I think. diff.noprefix may not stay to be (or it
> may already not to be) the only thing how the prefix gets chosen.
That is, "--src-prefix=a/ --dst-prefix=b/", so that configuration
variables yet to be invented for setting prefixes different from a/
and b/ can also be overridden, not just diff.noprefix (ancient Git
used l/ and k/ as src and dst prefix, IIRC).
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 1/1] range-diff: internally force `diff.noprefix=false`
2019-10-02 20:30 ` Johannes Schindelin
@ 2019-10-03 0:43 ` Junio C Hamano
0 siblings, 0 replies; 11+ messages in thread
From: Junio C Hamano @ 2019-10-03 0:43 UTC (permalink / raw)
To: Johannes Schindelin; +Cc: Johannes Schindelin via GitGitGadget, git
Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> While at it, I invert the logic in v2: instead of forcing a prefix, I
> now force no prefix (and reduce the strip level from 1 to 0 when parsing
> the diff header).
Ah, that approach would also work and may be conceptually cleaner
than requiring a/ and b/ prefix and forcing them.
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v2 1/1] range-diff: internally force `diff.noprefix=true`
2019-10-02 21:10 ` [PATCH v2 1/1] range-diff: internally force `diff.noprefix=true` Johannes Schindelin via GitGitGadget
@ 2019-10-03 2:11 ` Junio C Hamano
0 siblings, 0 replies; 11+ messages in thread
From: Junio C Hamano @ 2019-10-03 2:11 UTC (permalink / raw)
To: Johannes Schindelin via GitGitGadget
Cc: git, Eric Sunshine, Michal Suchánek, Johannes Schindelin
"Johannes Schindelin via GitGitGadget" <gitgitgadget@gmail.com>
writes:
> From: Johannes Schindelin <johannes.schindelin@gmx.de>
>
> When parsing the diffs, `range-diff` expects to see the prefixes `a/`
> and `b/` in the diff headers.
>
> These prefixes can be forced off via the config setting
> `diff.noprefix=true`. As `range-diff` is not prepared for that
> situation, this will cause a segmentation fault.
>
> Let's avoid that by passing the `--no-prefix` option to the `git log`
> process that generates the diffs that `range-diff` wants to parse.
> And of course expect the output to have no prefixes, then.
Looks good. Thanks.
^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2019-10-03 2:11 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-02 18:05 [PATCH 0/1] Avoid segmentation fault in git range-diff when diff.noprefix=true Johannes Schindelin via GitGitGadget
2019-10-02 18:05 ` [PATCH 1/1] range-diff: internally force `diff.noprefix=false` Johannes Schindelin via GitGitGadget
2019-10-02 18:34 ` Eric Sunshine
2019-10-02 19:56 ` Michal Suchánek
2019-10-02 20:06 ` Junio C Hamano
2019-10-02 20:30 ` Johannes Schindelin
2019-10-03 0:43 ` Junio C Hamano
2019-10-03 0:41 ` Junio C Hamano
2019-10-02 21:10 ` [PATCH v2 0/1] Avoid segmentation fault in git range-diff when diff.noprefix=true Johannes Schindelin via GitGitGadget
2019-10-02 21:10 ` [PATCH v2 1/1] range-diff: internally force `diff.noprefix=true` Johannes Schindelin via GitGitGadget
2019-10-03 2:11 ` Junio C Hamano
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).