From: Johannes Schindelin <johannes.schindelin@gmx.de>
To: git@vger.kernel.org
Cc: "Jakub Bereżański" <kuba@berezanscy.pl>,
"Junio C Hamano" <gitster@pobox.com>,
"Karsten Blees" <blees@dcon.de>,
"Pat Thoyts" <patthoyts@users.sourceforge.net>,
"David Aguilar" <davvid@gmail.com>
Subject: [PATCH 1/2] t0302: check helper can handle empty credentials
Date: Mon, 30 Oct 2017 18:20:12 +0100 (CET) [thread overview]
Message-ID: <e055913ec27fc3feb3f017747560f454f6817a0b.1509383993.git.johannes.schindelin@gmx.de> (raw)
In-Reply-To: <cover.1509383993.git.johannes.schindelin@gmx.de>
[-- Attachment #1: Type: text/plain, Size: 1183 bytes --]
From: =?UTF-8?q?Jakub=20Bere=C5=BCa=C5=84ski?= <kuba@berezanscy.pl>
Make sure the helper does not crash when blank username and password is
provided. If the helper can save such credentials, it should be able to
read them back.
Signed-off-by: Jakub Bereżański <kuba@berezanscy.pl>
---
t/lib-credential.sh | 19 +++++++++++++++++++
1 file changed, 19 insertions(+)
diff --git a/t/lib-credential.sh b/t/lib-credential.sh
index d8e41f7ddd1..937b831ea67 100755
--- a/t/lib-credential.sh
+++ b/t/lib-credential.sh
@@ -44,6 +44,7 @@ helper_test_clean() {
reject $1 https example.com user2
reject $1 http path.tld user
reject $1 https timeout.tld user
+ reject $1 https sso.tld
}
reject() {
@@ -250,6 +251,24 @@ helper_test() {
password=pass2
EOF
'
+
+ test_expect_success "helper ($HELPER) can store empty username" '
+ check approve $HELPER <<-\EOF &&
+ protocol=https
+ host=sso.tld
+ username=
+ password=
+ EOF
+ check fill $HELPER <<-\EOF
+ protocol=https
+ host=sso.tld
+ --
+ protocol=https
+ host=sso.tld
+ username=
+ password=
+ EOF
+ '
}
helper_test_timeout() {
--
2.15.0.windows.1
next prev parent reply other threads:[~2017-10-30 17:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-30 17:20 [PATCH 0/2] wincred: learn to handle "empty credentials" Johannes Schindelin
2017-10-30 17:20 ` Johannes Schindelin [this message]
2017-10-30 18:27 ` [PATCH 1/2] t0302: check helper can handle empty credentials Jeff King
2017-10-31 17:16 ` Johannes Schindelin
2017-10-30 17:20 ` [PATCH 2/2] wincred: handle empty username/password correctly Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e055913ec27fc3feb3f017747560f454f6817a0b.1509383993.git.johannes.schindelin@gmx.de \
--to=johannes.schindelin@gmx.de \
--cc=blees@dcon.de \
--cc=davvid@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=kuba@berezanscy.pl \
--cc=patthoyts@users.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).