From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Jeff King <peff@peff.net>
Cc: git@vger.kernel.org, "Jakub Bereżański" <kuba@berezanscy.pl>,
"Junio C Hamano" <gitster@pobox.com>,
"Karsten Blees" <blees@dcon.de>,
"Pat Thoyts" <patthoyts@users.sourceforge.net>,
"David Aguilar" <davvid@gmail.com>
Subject: Re: [PATCH 1/2] t0302: check helper can handle empty credentials
Date: Tue, 31 Oct 2017 18:16:17 +0100 (CET) [thread overview]
Message-ID: <alpine.DEB.2.21.1.1710311814260.6482@virtualbox> (raw)
In-Reply-To: <20171030182718.oyzhjffd6jd4wslu@sigill.intra.peff.net>
Hi Peff,
On Mon, 30 Oct 2017, Jeff King wrote:
> On Mon, Oct 30, 2017 at 06:20:12PM +0100, Johannes Schindelin wrote:
>
> > Subject: Re: [PATCH 1/2] t0302: check helper can handle empty credentials
>
> I guess we really care about t0303 here (which tests external helpers).
> This patch adds the test to lib-credential, so it hits the "cache" and
> "store" helpers, too. Which seems to pass, so I guess that's OK (I have
> to admit that as the author of those tools, I wasn't sure how they'd
> react).
>
> > Make sure the helper does not crash when blank username and password is
> > provided. If the helper can save such credentials, it should be able to
> > read them back.
>
> I worry that some third-party helpers might not be able to represent
> this case and would fail the test. This has been around for years no
> Windows, but probably hasn't ever been run with osxkeychain or
> libsecret. I'd be OK with taking this as-is, though, and waiting to see
> if anybody complains. At that point we'll know if the right solution is
> enhancing that helper, or providing a way to optionally skip this test.
Okay. If you change your mind, please let me know, I would try to set
aside some time to adjust the patch in that event.
> (Though I have no idea if anybody actually runs t0303 against
> custom-built helpers in the first place. The process is pretty manual
> for now, though the Makefiles in contrib/credential could probably at
> least provide a "make test").
Right... I am not aware of any attempts to run those tests against Git
Credential Manager for Windows, for example...
Ciao,
Dscho
next prev parent reply other threads:[~2017-10-31 17:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-30 17:20 [PATCH 0/2] wincred: learn to handle "empty credentials" Johannes Schindelin
2017-10-30 17:20 ` [PATCH 1/2] t0302: check helper can handle empty credentials Johannes Schindelin
2017-10-30 18:27 ` Jeff King
2017-10-31 17:16 ` Johannes Schindelin [this message]
2017-10-30 17:20 ` [PATCH 2/2] wincred: handle empty username/password correctly Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.1.1710311814260.6482@virtualbox \
--to=johannes.schindelin@gmx.de \
--cc=blees@dcon.de \
--cc=davvid@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=kuba@berezanscy.pl \
--cc=patthoyts@users.sourceforge.net \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).