From: Johannes Sixt <j6t@kdbg.org>
To: Thomas Gummerer <t.gummerer@gmail.com>
Cc: Git Mailing List <git@vger.kernel.org>
Subject: [PATCH tg/add-chmod+x-fix 1/2] t3700-add: create subdirectory gently
Date: Tue, 20 Sep 2016 08:16:11 +0200 [thread overview]
Message-ID: <cee3c784-8f03-c524-2f67-d35cb3755a41@kdbg.org> (raw)
The subdirectory 'sub' is created early in the test file. Later, a test
case removes it during its clean-up actions. However, this test case is
protected by POSIXPERM. Consequently, 'sub' remains when the POSIXPERM
prerequisite is not satisfied. Later, a recently introduced test case
creates 'sub' again. Use -p with mkdir so that it does not fail if 'sub'
already exists.
Signed-off-by: Johannes Sixt <j6t@kdbg.org>
---
t/t3700-add.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/t/t3700-add.sh b/t/t3700-add.sh
index 0a962a6..16ab2da 100755
--- a/t/t3700-add.sh
+++ b/t/t3700-add.sh
@@ -380,7 +380,7 @@ test_expect_success 'no file status change if no pathspec is given' '
'
test_expect_success 'no file status change if no pathspec is given in subdir' '
- mkdir sub &&
+ mkdir -p sub &&
(
cd sub &&
>sub-foo1 &&
--
2.10.0.85.gea34e30
next reply other threads:[~2016-09-20 6:16 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-20 6:16 Johannes Sixt [this message]
2016-09-20 6:18 ` [PATCH tg/add-chmod+x-fix 2/2] t3700-add: protect one --chmod=+x test with POSIXPERM Johannes Sixt
2016-09-20 19:34 ` Thomas Gummerer
2016-09-21 18:12 ` Junio C Hamano
2016-09-21 20:47 ` Johannes Sixt
2016-09-21 20:47 ` Junio C Hamano
2016-09-21 20:58 ` Johannes Sixt
2016-09-21 21:12 ` Junio C Hamano
2016-09-22 5:06 ` Johannes Sixt
2016-09-22 21:01 ` Thomas Gummerer
2016-09-20 19:28 ` [PATCH tg/add-chmod+x-fix 1/2] t3700-add: create subdirectory gently Thomas Gummerer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cee3c784-8f03-c524-2f67-d35cb3755a41@kdbg.org \
--to=j6t@kdbg.org \
--cc=git@vger.kernel.org \
--cc=t.gummerer@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).