From: Johannes Sixt <j6t@kdbg.org>
To: Junio C Hamano <gitster@pobox.com>,
Thomas Gummerer <t.gummerer@gmail.com>
Cc: Git Mailing List <git@vger.kernel.org>
Subject: Re: [PATCH tg/add-chmod+x-fix 2/2] t3700-add: protect one --chmod=+x test with POSIXPERM
Date: Wed, 21 Sep 2016 22:47:37 +0200 [thread overview]
Message-ID: <8b612559-ce78-db7d-235f-61b5f78720e4@kdbg.org> (raw)
In-Reply-To: <xmqqtwd986ml.fsf@gitster.mtv.corp.google.com>
Am 21.09.2016 um 20:12 schrieb Junio C Hamano:
> Thomas Gummerer <t.gummerer@gmail.com> writes:
>
>>> I am surprised that add --chmod=+x changes only the index, but not
>>> the file on disk!?!
>>
>> I *think* --chmod is mainly thought of as a convenience for git users
>> on a filesystem that doesn't have an executable flag. So it was
>> introduced this way as the permissions on the file system don't matter
>> in that case.
OK.
>> A change of that behaviour may make sense for this
>> though.
Hm, git-add is for moving content from the worktree to the index. I
don't think it should change the worktree. I should not have been surprised.
It should probably not even introduce a change in the index that it does
not see in the worktree, but, hey, git-add is a reasonable porcelain
substitute for the --chmod task that otherwise git-update-index would
have to do.
> Perhaps we shouldn't even test this, then?
If I am right that git-add should not change the worktree, it should be
tested. But 'git status -s' is probably the wrong tool for the reasons
you gave (it could accidentally detect a change due to content
difference instead of a file mode difference). At any rate, such a test
must be protected with POSIXPERM.
-- Hannes
next prev parent reply other threads:[~2016-09-21 20:47 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-20 6:16 [PATCH tg/add-chmod+x-fix 1/2] t3700-add: create subdirectory gently Johannes Sixt
2016-09-20 6:18 ` [PATCH tg/add-chmod+x-fix 2/2] t3700-add: protect one --chmod=+x test with POSIXPERM Johannes Sixt
2016-09-20 19:34 ` Thomas Gummerer
2016-09-21 18:12 ` Junio C Hamano
2016-09-21 20:47 ` Johannes Sixt [this message]
2016-09-21 20:47 ` Junio C Hamano
2016-09-21 20:58 ` Johannes Sixt
2016-09-21 21:12 ` Junio C Hamano
2016-09-22 5:06 ` Johannes Sixt
2016-09-22 21:01 ` Thomas Gummerer
2016-09-20 19:28 ` [PATCH tg/add-chmod+x-fix 1/2] t3700-add: create subdirectory gently Thomas Gummerer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8b612559-ce78-db7d-235f-61b5f78720e4@kdbg.org \
--to=j6t@kdbg.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=t.gummerer@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).