* Why is there still git-rebase--am.sh?
@ 2019-06-02 11:04 Alban Gruin
2019-06-02 11:19 ` Philip Oakley
0 siblings, 1 reply; 2+ messages in thread
From: Alban Gruin @ 2019-06-02 11:04 UTC (permalink / raw)
To: Git Mailing List, Johannes Schindelin,
Ævar Arnfjörð Bjarmason
Hi,
I was wandering in rebase’s source code, and found out that even though
run_specific_rebase() no longer calls git-rebase--am.sh since 21853626ea
("built-in rebase: call `git am` directly", 2019-01-18), this commit did not
remove the code to call it. I guess it was an oversight.
Now that git-legacy-rebase.sh is gone (since d03ebd411c, "rebase: remove the
rebase.useBuiltin setting", 2019-03-18), I would expect this file to be
completely removed, too.
May I send a patch to remove git-rebase--am.sh, or is there a reason to keep
it?
Cheers,
Alban
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: Why is there still git-rebase--am.sh?
2019-06-02 11:04 Why is there still git-rebase--am.sh? Alban Gruin
@ 2019-06-02 11:19 ` Philip Oakley
0 siblings, 0 replies; 2+ messages in thread
From: Philip Oakley @ 2019-06-02 11:19 UTC (permalink / raw)
To: Alban Gruin, Git Mailing List, Johannes Schindelin,
Ævar Arnfjörð Bjarmason
Hi Alban,
On 02/06/2019 12:04, Alban Gruin wrote:
> Hi,
>
> I was wandering in rebase’s source code, and found out that even though
> run_specific_rebase() no longer calls git-rebase--am.sh since 21853626ea
> ("built-in rebase: call `git am` directly", 2019-01-18), this commit did not
> remove the code to call it. I guess it was an oversight.
>
> Now that git-legacy-rebase.sh is gone (since d03ebd411c, "rebase: remove the
> rebase.useBuiltin setting", 2019-03-18), I would expect this file to be
> completely removed, too.
>
> May I send a patch to remove git-rebase--am.sh, or is there a reason to keep
> it?
>
>
What's cooking (May 2019, #05; Thu, 30) has it in js/rebase-cleanup
(2019-05-15) 5 commits, and will be cooked in next.
Philip
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-06-02 11:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-02 11:04 Why is there still git-rebase--am.sh? Alban Gruin
2019-06-02 11:19 ` Philip Oakley
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).