From: Eric Sunshine <sunshine@sunshineco.com>
To: Shourya Shukla <shouryashukla.oo@gmail.com>
Cc: "Git List" <git@vger.kernel.org>,
"Nguyễn Thái Ngọc Duy" <pclouds@gmail.com>,
"Jonathan Müller" <jonathanmueller.dev@gmail.com>
Subject: Re: [PATCH 1/8] worktree: factor out repeated string literal
Date: Mon, 8 Jun 2020 17:41:46 -0400 [thread overview]
Message-ID: <CAPig+cTRsyPWGb1J+28dWESKqK84RQr-yhZEmTf1=mtkmO4Y0w@mail.gmail.com> (raw)
In-Reply-To: <20200608193834.GA4196@konoha>
On Mon, Jun 8, 2020 at 3:38 PM Shourya Shukla
<shouryashukla.oo@gmail.com> wrote:
> On 08/06 02:23, Eric Sunshine wrote:
> > Although this change seems to increase the "sentence lego quotient", it
> > should be reasonably safe, as the reason for removal is a distinct
> > clause, not strictly related to the prefix. Moreover, the "worktrees" in
> > "Removing worktrees/%s:" is a path literal which ought not be localized,
> > so by factoring it out, we can more easily avoid exposing that path
> > fragment to translators.
>
> Could you explain the above paragraph just a bit more? The English is
> confusing me a bit.
Which part is confusing you? The "sentence lego" bit or the bit about
not wanting translators touching a path literal? Or something else?
The path element bit is easy: A literal path, such as
".git/worktrees/foo" should not be translated to a user's local
language.
Sentence lego refers to the process of composing text from several
pieces. Doing so can make it difficult for a translator to localize it
to a particular language because the standalone pieces don't
necessarily provide sufficient context for a proper translation. For
instance, this example is from [1]:
Translatable strings should be entire sentences. It is often not
possible to translate single verbs or adjectives in a
substitutable way.
printf ("File %s is %s protected", filename, rw ? "write" : "read");
Most translators will not look at the source and will thus only see
the string "File %s is %s protected", which is
unintelligible. Change this to
printf (rw ? "File %s is write protected" :
"File %s is read protected", filename);
This way the translator will not only understand the message, she
will also be able to find the appropriate grammatical
construction. A French translator for example translates "write
protected" like "protected against writing".
[1]: https://www.gnu.org/software/gettext/manual/html_node/Preparing-Strings.html
next prev parent reply other threads:[~2020-06-08 21:42 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-08 6:23 [PATCH 0/8] worktree: tighten duplicate path detection Eric Sunshine
2020-06-08 6:23 ` [PATCH 1/8] worktree: factor out repeated string literal Eric Sunshine
2020-06-08 19:38 ` Shourya Shukla
2020-06-08 21:41 ` Eric Sunshine [this message]
2020-06-08 6:23 ` [PATCH 2/8] worktree: prune corrupted worktree even if locked Eric Sunshine
2020-06-08 21:23 ` Junio C Hamano
2020-06-09 17:34 ` Eric Sunshine
2020-06-08 6:23 ` [PATCH 3/8] worktree: give "should be pruned?" function more meaningful name Eric Sunshine
2020-06-08 21:25 ` Junio C Hamano
2020-06-08 6:23 ` [PATCH 4/8] worktree: make high-level pruning re-usable Eric Sunshine
2020-06-08 21:29 ` Junio C Hamano
2020-06-08 6:23 ` [PATCH 5/8] worktree: prune duplicate entries referencing same worktree path Eric Sunshine
2020-06-08 6:23 ` [PATCH 6/8] worktree: prune linked worktree referencing main " Eric Sunshine
2020-06-08 21:59 ` Junio C Hamano
2020-06-09 17:38 ` Eric Sunshine
2020-06-08 6:23 ` [PATCH 7/8] worktree: generalize candidate worktree path validation Eric Sunshine
2020-06-08 22:02 ` Junio C Hamano
2020-06-08 6:23 ` [PATCH 8/8] worktree: make "move" refuse to move atop missing registered worktree Eric Sunshine
2020-06-08 15:19 ` Eric Sunshine
2020-06-08 22:06 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPig+cTRsyPWGb1J+28dWESKqK84RQr-yhZEmTf1=mtkmO4Y0w@mail.gmail.com' \
--to=sunshine@sunshineco.com \
--cc=git@vger.kernel.org \
--cc=jonathanmueller.dev@gmail.com \
--cc=pclouds@gmail.com \
--cc=shouryashukla.oo@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).