From: Shourya Shukla <shouryashukla.oo@gmail.com>
To: Eric Sunshine <sunshine@sunshineco.com>
Cc: git@vger.kernel.org, pclouds@gmail.com, jonathanmueller.dev@gmail.com
Subject: Re: [PATCH 1/8] worktree: factor out repeated string literal
Date: Tue, 9 Jun 2020 01:08:34 +0530 [thread overview]
Message-ID: <20200608193834.GA4196@konoha> (raw)
In-Reply-To: <20200608062356.40264-2-sunshine@sunshineco.com>
On 08/06 02:23, Eric Sunshine wrote:
Hello Eric!
> Although this change seems to increase the "sentence lego quotient", it
> should be reasonably safe, as the reason for removal is a distinct
> clause, not strictly related to the prefix. Moreover, the "worktrees" in
> "Removing worktrees/%s:" is a path literal which ought not be localized,
> so by factoring it out, we can more easily avoid exposing that path
> fragment to translators.
Could you explain the above paragraph just a bit more? The English is
confusing me a bit.
next prev parent reply other threads:[~2020-06-08 19:38 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-08 6:23 [PATCH 0/8] worktree: tighten duplicate path detection Eric Sunshine
2020-06-08 6:23 ` [PATCH 1/8] worktree: factor out repeated string literal Eric Sunshine
2020-06-08 19:38 ` Shourya Shukla [this message]
2020-06-08 21:41 ` Eric Sunshine
2020-06-08 6:23 ` [PATCH 2/8] worktree: prune corrupted worktree even if locked Eric Sunshine
2020-06-08 21:23 ` Junio C Hamano
2020-06-09 17:34 ` Eric Sunshine
2020-06-08 6:23 ` [PATCH 3/8] worktree: give "should be pruned?" function more meaningful name Eric Sunshine
2020-06-08 21:25 ` Junio C Hamano
2020-06-08 6:23 ` [PATCH 4/8] worktree: make high-level pruning re-usable Eric Sunshine
2020-06-08 21:29 ` Junio C Hamano
2020-06-08 6:23 ` [PATCH 5/8] worktree: prune duplicate entries referencing same worktree path Eric Sunshine
2020-06-08 6:23 ` [PATCH 6/8] worktree: prune linked worktree referencing main " Eric Sunshine
2020-06-08 21:59 ` Junio C Hamano
2020-06-09 17:38 ` Eric Sunshine
2020-06-08 6:23 ` [PATCH 7/8] worktree: generalize candidate worktree path validation Eric Sunshine
2020-06-08 22:02 ` Junio C Hamano
2020-06-08 6:23 ` [PATCH 8/8] worktree: make "move" refuse to move atop missing registered worktree Eric Sunshine
2020-06-08 15:19 ` Eric Sunshine
2020-06-08 22:06 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200608193834.GA4196@konoha \
--to=shouryashukla.oo@gmail.com \
--cc=git@vger.kernel.org \
--cc=jonathanmueller.dev@gmail.com \
--cc=pclouds@gmail.com \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).