From: Eric Sunshine <sunshine@sunshineco.com>
To: Jeff King <peff@peff.net>
Cc: Git List <git@vger.kernel.org>, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH] doc/Makefile: remove tmp-doc-diff on "make clean"
Date: Thu, 30 Aug 2018 16:34:43 -0400 [thread overview]
Message-ID: <CAPig+cRXEegGwm3QiyEZqkVN1NYv5xAAYRuAKHUE8n-g9m6jqw@mail.gmail.com> (raw)
In-Reply-To: <20180830195546.GA22407@sigill.intra.peff.net>
On Thu, Aug 30, 2018 at 3:55 PM Jeff King <peff@peff.net> wrote:
> The tmp-doc-diff directory isn't strictly a build product of
> the Makefile, since it's only present if you manually run
> the doc-diff script. But anybody running "make clean" would
> probably want it to go away.
>
> Suggested-by: Eric Sunshine <sunshine@sunshineco.com>
> Signed-off-by: Jeff King <peff@peff.net>
> ---
> diff --git a/Documentation/Makefile b/Documentation/Makefile
> @@ -332,6 +332,7 @@ clean:
> $(RM) manpage-base-url.xsl
> + $(RM) -r tmp-doc-diff
Taking into consideration that people might be surprised and alarmed
to find "git worktree list" showing a worktree they didn't explicitly
create, would it make sense to do something like this?
clean:
...
-git worktree remove -f tmp-doc-diff 2>/dev/null
$(RM) -r tmp-doc-diff
next prev parent reply other threads:[~2018-08-30 20:34 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-30 8:12 [PATCH] doc-diff: always use oids inside worktree Jeff King
2018-08-30 9:12 ` Eric Sunshine
2018-08-30 19:55 ` [PATCH] doc/Makefile: remove tmp-doc-diff on "make clean" Jeff King
2018-08-30 20:34 ` Eric Sunshine [this message]
2018-08-30 20:36 ` Eric Sunshine
2018-08-30 20:52 ` Jeff King
2018-08-31 6:33 ` [PATCH 0/3] doc-diff: add "clean" mode & fix portability problem Eric Sunshine
2018-08-31 6:33 ` [PATCH 1/3] doc-diff: fix non-portable 'man' invocation Eric Sunshine
2018-08-31 19:49 ` Jeff King
2018-08-31 6:33 ` [PATCH 2/3] doc-diff: add --clean mode to remove temporary working gunk Eric Sunshine
2018-08-31 20:01 ` Jeff King
2018-08-31 21:24 ` Eric Sunshine
2018-08-31 6:33 ` [PATCH 3/3] doc/Makefile: drop doc-diff worktree and temporary files on "make clean" Eric Sunshine
2018-08-31 20:07 ` Jeff King
2018-08-31 21:37 ` Eric Sunshine
2018-09-17 18:32 ` Jonathan Nieder
2018-09-17 19:36 ` Junio C Hamano
2018-09-17 19:42 ` Jonathan Nieder
2018-09-17 19:48 ` Junio C Hamano
2018-09-17 19:55 ` Jonathan Nieder
2018-09-18 17:38 ` Jeff King
2018-09-17 20:43 ` Eric Sunshine
2018-09-17 20:52 ` Eric Sunshine
2018-08-31 18:49 ` [PATCH 0/3] doc-diff: add "clean" mode & fix portability problem Junio C Hamano
2018-08-31 20:08 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPig+cRXEegGwm3QiyEZqkVN1NYv5xAAYRuAKHUE8n-g9m6jqw@mail.gmail.com \
--to=sunshine@sunshineco.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).