From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: Jonathan Nieder <jrnieder@gmail.com>,
Eric Sunshine <sunshine@sunshineco.com>,
git@vger.kernel.org
Subject: Re: [PATCH 3/3] doc/Makefile: drop doc-diff worktree and temporary files on "make clean"
Date: Tue, 18 Sep 2018 13:38:10 -0400 [thread overview]
Message-ID: <20180918173810.GF15470@sigill.intra.peff.net> (raw)
In-Reply-To: <xmqqy3bz6h24.fsf@gitster-ct.c.googlers.com>
On Mon, Sep 17, 2018 at 12:48:51PM -0700, Junio C Hamano wrote:
> Jonathan Nieder <jrnieder@gmail.com> writes:
>
> > I'd rather that we revert this change altogether. I have nothing
> > against a convenient command to do this kind of non build related
> > cleanup, but it shouldn't be spelled as "make clean".
>
> OK, let's do this for now as I wanted to merge the remainder to
> 'master' today.
>
> -- >8 --
> Subject: Revert "doc/Makefile: drop doc-diff worktree and temporary files on "make clean""
>
> This reverts commit 6f924265a0bf6efa677e9a684cebdde958e5ba06, which
> started to require that we have an executable git available in order
> to say "make clean", which gives us a chicken-and-egg problem.
>
> Having to have Git installed, or be in a repository, in order to be
> able to run an optional "doc-diff" tool is fine. Requiring either
> in order to run "make clean" is a different story.
Yeah, this seems like the best solution. We started with "can we just rm
-rf the temporary directory as part of 'make clean'", which is totally
sensible and matches the other bits there. But then it got more
complicated. :)
People who use doc-diff can still use "doc-diff --clean", so I don't
think much is lost.
Thanks.
-Peff
next prev parent reply other threads:[~2018-09-18 17:38 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-30 8:12 [PATCH] doc-diff: always use oids inside worktree Jeff King
2018-08-30 9:12 ` Eric Sunshine
2018-08-30 19:55 ` [PATCH] doc/Makefile: remove tmp-doc-diff on "make clean" Jeff King
2018-08-30 20:34 ` Eric Sunshine
2018-08-30 20:36 ` Eric Sunshine
2018-08-30 20:52 ` Jeff King
2018-08-31 6:33 ` [PATCH 0/3] doc-diff: add "clean" mode & fix portability problem Eric Sunshine
2018-08-31 6:33 ` [PATCH 1/3] doc-diff: fix non-portable 'man' invocation Eric Sunshine
2018-08-31 19:49 ` Jeff King
2018-08-31 6:33 ` [PATCH 2/3] doc-diff: add --clean mode to remove temporary working gunk Eric Sunshine
2018-08-31 20:01 ` Jeff King
2018-08-31 21:24 ` Eric Sunshine
2018-08-31 6:33 ` [PATCH 3/3] doc/Makefile: drop doc-diff worktree and temporary files on "make clean" Eric Sunshine
2018-08-31 20:07 ` Jeff King
2018-08-31 21:37 ` Eric Sunshine
2018-09-17 18:32 ` Jonathan Nieder
2018-09-17 19:36 ` Junio C Hamano
2018-09-17 19:42 ` Jonathan Nieder
2018-09-17 19:48 ` Junio C Hamano
2018-09-17 19:55 ` Jonathan Nieder
2018-09-18 17:38 ` Jeff King [this message]
2018-09-17 20:43 ` Eric Sunshine
2018-09-17 20:52 ` Eric Sunshine
2018-08-31 18:49 ` [PATCH 0/3] doc-diff: add "clean" mode & fix portability problem Junio C Hamano
2018-08-31 20:08 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180918173810.GF15470@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jrnieder@gmail.com \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).