* Regression in git ls-files, or bug in completion?
@ 2020-03-22 23:39 Felipe Contreras
2020-03-28 13:25 ` Felipe Contreras
0 siblings, 1 reply; 4+ messages in thread
From: Felipe Contreras @ 2020-03-22 23:39 UTC (permalink / raw)
To: Git; +Cc: Elijah Newren, Junio C Hamano
Hi,
I noticed a possible regression caused by commit b9670c1f5e (dir: fix
checks on common prefix directory).
What is supposed to be the output of this?
git init
mkdir simple-dir
touch simple-dir/empty
git -C simple-dir ls-files --other --directory
Before it was "empty", now it is "./".
This causes bash's completion to be botched; "git add simple-dir/"
adds "simple-dir/./".
Cheers.
--
Felipe Contreras
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Regression in git ls-files, or bug in completion?
2020-03-22 23:39 Regression in git ls-files, or bug in completion? Felipe Contreras
@ 2020-03-28 13:25 ` Felipe Contreras
2020-03-28 17:22 ` Elijah Newren
0 siblings, 1 reply; 4+ messages in thread
From: Felipe Contreras @ 2020-03-28 13:25 UTC (permalink / raw)
To: Git; +Cc: Elijah Newren, Junio C Hamano
On Sun, Mar 22, 2020 at 5:39 PM Felipe Contreras
<felipe.contreras@gmail.com> wrote:
> I noticed a possible regression caused by commit b9670c1f5e (dir: fix
> checks on common prefix directory).
> Before it was "empty", now it is "./".
I guess you don't care about this regression.
--
Felipe Contreras
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Regression in git ls-files, or bug in completion?
2020-03-28 13:25 ` Felipe Contreras
@ 2020-03-28 17:22 ` Elijah Newren
2020-03-31 22:54 ` Felipe Contreras
0 siblings, 1 reply; 4+ messages in thread
From: Elijah Newren @ 2020-03-28 17:22 UTC (permalink / raw)
To: Felipe Contreras; +Cc: Git, Junio C Hamano
On Sat, Mar 28, 2020 at 6:25 AM Felipe Contreras
<felipe.contreras@gmail.com> wrote:
>
> On Sun, Mar 22, 2020 at 5:39 PM Felipe Contreras
> <felipe.contreras@gmail.com> wrote:
>
> > I noticed a possible regression caused by commit b9670c1f5e (dir: fix
> > checks on common prefix directory).
>
> > Before it was "empty", now it is "./".
>
> I guess you don't care about this regression.
Sorry for being slow to get back to you; it wasn't that I didn't care
(I marked the message as important to return to) but that I was
focused on 2.26 regressions and other fixes I've been promising for
months. I'm working on a fix for this 2.25 regression, but note that
it's going to depend on this series:
https://lore.kernel.org/git/pull.700.v4.git.git.1585258061.gitgitgadget@gmail.com/
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Regression in git ls-files, or bug in completion?
2020-03-28 17:22 ` Elijah Newren
@ 2020-03-31 22:54 ` Felipe Contreras
0 siblings, 0 replies; 4+ messages in thread
From: Felipe Contreras @ 2020-03-31 22:54 UTC (permalink / raw)
To: Elijah Newren; +Cc: Git, Junio C Hamano
On Sat, Mar 28, 2020 at 11:22 AM Elijah Newren <newren@gmail.com> wrote:
>
> On Sat, Mar 28, 2020 at 6:25 AM Felipe Contreras
> <felipe.contreras@gmail.com> wrote:
> >
> > On Sun, Mar 22, 2020 at 5:39 PM Felipe Contreras
> > <felipe.contreras@gmail.com> wrote:
> >
> > > I noticed a possible regression caused by commit b9670c1f5e (dir: fix
> > > checks on common prefix directory).
> >
> > > Before it was "empty", now it is "./".
> >
> > I guess you don't care about this regression.
>
> Sorry for being slow to get back to you; it wasn't that I didn't care
> (I marked the message as important to return to) but that I was
> focused on 2.26 regressions and other fixes I've been promising for
> months. I'm working on a fix for this 2.25 regression, but note that
> it's going to depend on this series:
> https://lore.kernel.org/git/pull.700.v4.git.git.1585258061.gitgitgadget@gmail.com/
I see. Please let me know when you have something ready to test.
--
Felipe Contreras
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-03-31 22:54 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-22 23:39 Regression in git ls-files, or bug in completion? Felipe Contreras
2020-03-28 13:25 ` Felipe Contreras
2020-03-28 17:22 ` Elijah Newren
2020-03-31 22:54 ` Felipe Contreras
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).