From: Bryan Turner <bturner@atlassian.com>
To: Jeff King <peff@peff.net>
Cc: "Git Users" <git@vger.kernel.org>, "René Scharfe" <l.s.r@web.de>
Subject: Re: [PATCH 07/18] link_alt_odb_entry: handle normalize_path errors
Date: Tue, 8 Nov 2016 11:27:41 -0800 [thread overview]
Message-ID: <CAGyf7-HVUN-kHhmccoYUVVDE_xJt1UsiE8bxZiADsW5GFGr+OA@mail.gmail.com> (raw)
In-Reply-To: <20161108053333.jta7bmqsyvy2ijoh@sigill.intra.peff.net>
>
>> Is there anything I can do to help? I'm happy to test out changes.
>
> The patch at the end of his mail obviously passes the newly-added tests
> for me, but please confirm that it fixes your test suite.
>
> I gather your suite is about noticing behavior changes between different
> versions. For cases where we know there is an obvious right behavior, it
> would be nice if you could contribute them as patches to git's test
> suite. This case was overlooked because there was no test coverage at
> all.
>
> Barring that, running your suite and giving easily-reproducible problem
> reports is valuable. The earlier the better. So I am happy to see this
> on -rc0, and not on the final release. Periodically running it on
> "master" during the development cycle would have caught it even sooner.
I've applied your patch to the tip of the 2.11.0-rc0 tag (just to make
sure I don't accidentally pick up anything else on master; I'll test
that separately) and my full test suite passes without issue.
I'm going to investigate whether I can setup a version of this build
that runs "periodically" (I'm not sure what that period will be)
against git/git master. I've got a lot of the infrastructure in place,
but I'm going to need to automate a few things to make it really
viable.
As for contributing extensions to the test suite, that's a good idea.
I need to fast track getting a development environment setup.
next prev parent reply other threads:[~2016-11-08 19:27 UTC|newest]
Thread overview: 84+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-03 20:33 [PATCH 0/18] alternate object database cleanups Jeff King
2016-10-03 20:33 ` [PATCH 01/18] t5613: drop reachable_via function Jeff King
2016-10-04 5:48 ` Jacob Keller
2016-10-04 13:43 ` Jeff King
2016-10-03 20:33 ` [PATCH 02/18] t5613: drop test_valid_repo function Jeff King
2016-10-04 5:50 ` Jacob Keller
2016-10-03 20:34 ` [PATCH 03/18] t5613: use test_must_fail Jeff King
2016-10-04 5:51 ` Jacob Keller
2016-10-03 20:34 ` [PATCH 04/18] t5613: whitespace/style cleanups Jeff King
2016-10-04 5:52 ` Jacob Keller
2016-10-04 13:47 ` Jeff King
2016-10-04 20:41 ` Jacob Keller
2016-10-03 20:34 ` [PATCH 05/18] t5613: do not chdir in main process Jeff King
2016-10-04 5:54 ` Jacob Keller
2016-10-04 21:00 ` Junio C Hamano
2016-10-03 20:34 ` [PATCH 06/18] t5613: clarify "too deep" recursion tests Jeff King
2016-10-04 5:57 ` Jacob Keller
2016-10-04 13:48 ` Jeff King
2016-10-04 20:44 ` Jacob Keller
2016-10-04 20:49 ` Jeff King
2016-10-04 20:52 ` Jacob Keller
2016-10-04 20:55 ` Jeff King
2016-10-04 20:58 ` Stefan Beller
2016-10-04 21:00 ` Jeff King
2016-10-05 13:58 ` Jakub Narębski
2016-10-05 14:40 ` Jeff King
2016-10-05 16:14 ` Junio C Hamano
2016-10-05 16:47 ` Jacob Keller
2016-10-04 21:43 ` Jacob Keller
2016-10-04 21:49 ` Jeff King
2016-10-04 21:50 ` Jacob Keller
2016-10-03 20:34 ` [PATCH 07/18] link_alt_odb_entry: handle normalize_path errors Jeff King
2016-10-04 6:01 ` Jacob Keller
2016-10-04 21:08 ` Junio C Hamano
2016-10-05 18:47 ` René Scharfe
2016-10-05 19:04 ` Jeff King
2016-11-07 23:42 ` Bryan Turner
2016-11-08 0:30 ` Jeff King
2016-11-08 1:12 ` Bryan Turner
2016-11-08 5:33 ` Jeff King
2016-11-08 19:27 ` Bryan Turner [this message]
2016-10-03 20:34 ` [PATCH 08/18] link_alt_odb_entry: refactor string handling Jeff King
2016-10-04 6:05 ` Jacob Keller
2016-10-04 13:53 ` Jeff King
2016-10-04 20:46 ` Jacob Keller
2016-10-04 21:18 ` Junio C Hamano
2016-10-03 20:35 ` [PATCH 09/18] alternates: provide helper for adding to alternates list Jeff King
2016-10-04 6:07 ` Jacob Keller
2016-10-03 20:35 ` [PATCH 10/18] alternates: provide helper for allocating alternate Jeff King
2016-10-04 6:09 ` Jacob Keller
2016-10-03 20:35 ` [PATCH 11/18] alternates: encapsulate alt->base munging Jeff King
2016-10-03 20:35 ` [PATCH 12/18] alternates: use a separate scratch space Jeff King
2016-10-04 6:12 ` Jacob Keller
2016-10-04 21:29 ` Junio C Hamano
2016-10-04 21:32 ` Jeff King
2016-10-04 21:49 ` Junio C Hamano
2016-10-04 21:51 ` Jeff King
2016-10-03 20:35 ` [PATCH 13/18] fill_sha1_file: write "boring" characters Jeff King
2016-10-04 6:13 ` Jacob Keller
2016-10-04 21:46 ` Junio C Hamano
2016-10-04 21:48 ` Jeff King
2016-10-04 21:49 ` Jacob Keller
2016-10-05 19:35 ` Junio C Hamano
2016-10-03 20:36 ` [PATCH 14/18] alternates: store scratch buffer as strbuf Jeff King
2016-10-03 20:36 ` [PATCH 15/18] fill_sha1_file: write into a strbuf Jeff King
2016-10-04 6:44 ` Jacob Keller
2016-10-03 20:36 ` [PATCH 16/18] count-objects: report alternates via verbose mode Jeff King
2016-10-04 6:46 ` Jacob Keller
2016-10-04 13:56 ` Jeff King
2016-10-05 14:23 ` Jakub Narębski
2016-10-05 18:47 ` René Scharfe
2016-10-03 20:36 ` [PATCH 17/18] sha1_file: always allow relative paths to alternates Jeff King
2016-10-04 6:50 ` Jacob Keller
2016-10-04 14:00 ` Jeff King
2016-10-03 20:36 ` [PATCH 18/18] alternates: use fspathcmp to detect duplicates Jeff King
2016-10-04 6:51 ` Jacob Keller
2016-10-04 14:10 ` Jeff King
2016-10-04 21:42 ` Junio C Hamano
2016-10-05 2:34 ` Aaron Schrab
2016-10-05 3:54 ` Jeff King
2016-10-04 5:47 ` [PATCH 0/18] alternate object database cleanups Jacob Keller
2016-10-04 13:41 ` Jeff King
2016-10-04 20:40 ` Jacob Keller
2016-10-05 18:47 ` René Scharfe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAGyf7-HVUN-kHhmccoYUVVDE_xJt1UsiE8bxZiADsW5GFGr+OA@mail.gmail.com \
--to=bturner@atlassian.com \
--cc=git@vger.kernel.org \
--cc=l.s.r@web.de \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).