From: Jacob Keller <jacob.keller@gmail.com>
To: Jeff King <peff@peff.net>
Cc: "Git mailing list" <git@vger.kernel.org>, "René Scharfe" <l.s.r@web.de>
Subject: Re: [PATCH 0/18] alternate object database cleanups
Date: Mon, 3 Oct 2016 22:47:31 -0700 [thread overview]
Message-ID: <CA+P7+xob7ohj1MxuLGGLwwJyi4RfqUTeLkbw86u+VvbU=uEyAw@mail.gmail.com> (raw)
In-Reply-To: <20161003203321.rj5jepviwo57uhqw@sigill.intra.peff.net>
On Mon, Oct 3, 2016 at 1:33 PM, Jeff King <peff@peff.net> wrote:
> This series is the result of René nerd-sniping me with the claim that we
> could "easily" teach count-objects to print out the list of alternates
> in:
>
> http://public-inbox.org/git/c27dc1a4-3c7a-2866-d9d8-f5d3eb161650@web.de/
>
Hah. Nerd snipes are fun.
> My real goal is just patch 17, which is needed for the quarantine series
> in that thread. But along the way there were quite a few opportunities
> for cleanups along with a few minor bugfixes (in patches 7 and 18), and
> I think the count-objects change in patch 16 is a nice general debugging
> tool.
Yea there are a *lot* of cleanups here.
>
> The rest of it is "just" cleanup, but I'll note that it clears up some
> hairy allocation code. These were bits that I noticed in my big
> allocation-cleanup series last year, but were too nasty to fit any of
> the more general fixes. I think the end result is much better.
>
Definitely agreed. I read through all the patches, and each one seemed
reasonable.
> The number of patches is a little intimidating, but I tried hard to
> break the refactoring down into a sequence of obviously-correct steps.
> You can be the judge of my success.
>
I read through them once. I'm going to re-read through them again and
leave any comments I had.
Regards,
Jake
> [01/18]: t5613: drop reachable_via function
> [02/18]: t5613: drop test_valid_repo function
> [03/18]: t5613: use test_must_fail
> [04/18]: t5613: whitespace/style cleanups
> [05/18]: t5613: do not chdir in main process
> [06/18]: t5613: clarify "too deep" recursion tests
> [07/18]: link_alt_odb_entry: handle normalize_path errors
> [08/18]: link_alt_odb_entry: refactor string handling
> [09/18]: alternates: provide helper for adding to alternates list
> [10/18]: alternates: provide helper for allocating alternate
> [11/18]: alternates: encapsulate alt->base munging
> [12/18]: alternates: use a separate scratch space
> [13/18]: fill_sha1_file: write "boring" characters
> [14/18]: alternates: store scratch buffer as strbuf
> [15/18]: fill_sha1_file: write into a strbuf
> [16/18]: count-objects: report alternates via verbose mode
> [17/18]: sha1_file: always allow relative paths to alternates
> [18/18]: alternates: use fspathcmp to detect duplicates
>
> Documentation/git-count-objects.txt | 5 +
> builtin/count-objects.c | 12 +++
> builtin/fsck.c | 10 +-
> builtin/submodule--helper.c | 11 +-
> cache.h | 36 ++++++-
> sha1_file.c | 179 ++++++++++++++++++--------------
> sha1_name.c | 17 +--
> strbuf.c | 20 ++++
> strbuf.h | 8 ++
> submodule.c | 23 +---
> t/t5613-info-alternate.sh | 202 ++++++++++++++++++++----------------
> transport.c | 4 +-
> 12 files changed, 305 insertions(+), 222 deletions(-)
>
next prev parent reply other threads:[~2016-10-04 5:47 UTC|newest]
Thread overview: 84+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-03 20:33 [PATCH 0/18] alternate object database cleanups Jeff King
2016-10-03 20:33 ` [PATCH 01/18] t5613: drop reachable_via function Jeff King
2016-10-04 5:48 ` Jacob Keller
2016-10-04 13:43 ` Jeff King
2016-10-03 20:33 ` [PATCH 02/18] t5613: drop test_valid_repo function Jeff King
2016-10-04 5:50 ` Jacob Keller
2016-10-03 20:34 ` [PATCH 03/18] t5613: use test_must_fail Jeff King
2016-10-04 5:51 ` Jacob Keller
2016-10-03 20:34 ` [PATCH 04/18] t5613: whitespace/style cleanups Jeff King
2016-10-04 5:52 ` Jacob Keller
2016-10-04 13:47 ` Jeff King
2016-10-04 20:41 ` Jacob Keller
2016-10-03 20:34 ` [PATCH 05/18] t5613: do not chdir in main process Jeff King
2016-10-04 5:54 ` Jacob Keller
2016-10-04 21:00 ` Junio C Hamano
2016-10-03 20:34 ` [PATCH 06/18] t5613: clarify "too deep" recursion tests Jeff King
2016-10-04 5:57 ` Jacob Keller
2016-10-04 13:48 ` Jeff King
2016-10-04 20:44 ` Jacob Keller
2016-10-04 20:49 ` Jeff King
2016-10-04 20:52 ` Jacob Keller
2016-10-04 20:55 ` Jeff King
2016-10-04 20:58 ` Stefan Beller
2016-10-04 21:00 ` Jeff King
2016-10-05 13:58 ` Jakub Narębski
2016-10-05 14:40 ` Jeff King
2016-10-05 16:14 ` Junio C Hamano
2016-10-05 16:47 ` Jacob Keller
2016-10-04 21:43 ` Jacob Keller
2016-10-04 21:49 ` Jeff King
2016-10-04 21:50 ` Jacob Keller
2016-10-03 20:34 ` [PATCH 07/18] link_alt_odb_entry: handle normalize_path errors Jeff King
2016-10-04 6:01 ` Jacob Keller
2016-10-04 21:08 ` Junio C Hamano
2016-10-05 18:47 ` René Scharfe
2016-10-05 19:04 ` Jeff King
2016-11-07 23:42 ` Bryan Turner
2016-11-08 0:30 ` Jeff King
2016-11-08 1:12 ` Bryan Turner
2016-11-08 5:33 ` Jeff King
2016-11-08 19:27 ` Bryan Turner
2016-10-03 20:34 ` [PATCH 08/18] link_alt_odb_entry: refactor string handling Jeff King
2016-10-04 6:05 ` Jacob Keller
2016-10-04 13:53 ` Jeff King
2016-10-04 20:46 ` Jacob Keller
2016-10-04 21:18 ` Junio C Hamano
2016-10-03 20:35 ` [PATCH 09/18] alternates: provide helper for adding to alternates list Jeff King
2016-10-04 6:07 ` Jacob Keller
2016-10-03 20:35 ` [PATCH 10/18] alternates: provide helper for allocating alternate Jeff King
2016-10-04 6:09 ` Jacob Keller
2016-10-03 20:35 ` [PATCH 11/18] alternates: encapsulate alt->base munging Jeff King
2016-10-03 20:35 ` [PATCH 12/18] alternates: use a separate scratch space Jeff King
2016-10-04 6:12 ` Jacob Keller
2016-10-04 21:29 ` Junio C Hamano
2016-10-04 21:32 ` Jeff King
2016-10-04 21:49 ` Junio C Hamano
2016-10-04 21:51 ` Jeff King
2016-10-03 20:35 ` [PATCH 13/18] fill_sha1_file: write "boring" characters Jeff King
2016-10-04 6:13 ` Jacob Keller
2016-10-04 21:46 ` Junio C Hamano
2016-10-04 21:48 ` Jeff King
2016-10-04 21:49 ` Jacob Keller
2016-10-05 19:35 ` Junio C Hamano
2016-10-03 20:36 ` [PATCH 14/18] alternates: store scratch buffer as strbuf Jeff King
2016-10-03 20:36 ` [PATCH 15/18] fill_sha1_file: write into a strbuf Jeff King
2016-10-04 6:44 ` Jacob Keller
2016-10-03 20:36 ` [PATCH 16/18] count-objects: report alternates via verbose mode Jeff King
2016-10-04 6:46 ` Jacob Keller
2016-10-04 13:56 ` Jeff King
2016-10-05 14:23 ` Jakub Narębski
2016-10-05 18:47 ` René Scharfe
2016-10-03 20:36 ` [PATCH 17/18] sha1_file: always allow relative paths to alternates Jeff King
2016-10-04 6:50 ` Jacob Keller
2016-10-04 14:00 ` Jeff King
2016-10-03 20:36 ` [PATCH 18/18] alternates: use fspathcmp to detect duplicates Jeff King
2016-10-04 6:51 ` Jacob Keller
2016-10-04 14:10 ` Jeff King
2016-10-04 21:42 ` Junio C Hamano
2016-10-05 2:34 ` Aaron Schrab
2016-10-05 3:54 ` Jeff King
2016-10-04 5:47 ` Jacob Keller [this message]
2016-10-04 13:41 ` [PATCH 0/18] alternate object database cleanups Jeff King
2016-10-04 20:40 ` Jacob Keller
2016-10-05 18:47 ` René Scharfe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CA+P7+xob7ohj1MxuLGGLwwJyi4RfqUTeLkbw86u+VvbU=uEyAw@mail.gmail.com' \
--to=jacob.keller@gmail.com \
--cc=git@vger.kernel.org \
--cc=l.s.r@web.de \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).