git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Stefan Beller <sbeller@google.com>
To: Pranit Bauva <pranit.bauva@gmail.com>
Cc: "git@vger.kernel.org" <git@vger.kernel.org>
Subject: Re: [PATCH] don't use test_must_fail with grep
Date: Tue, 3 Jan 2017 09:52:35 -0800	[thread overview]
Message-ID: <CAGZ79kYbJuujDpT-3Dj6AFkZUaKUrj8NJ=WgBbT1YbgwTibc=Q@mail.gmail.com> (raw)
In-Reply-To: <20161231114412.23439-1-pranit.bauva@gmail.com>

On Sat, Dec 31, 2016 at 3:44 AM, Pranit Bauva <pranit.bauva@gmail.com> wrote:
> test_must_fail should only be used for testing git commands. To test the
> failure of other commands use `!`.
>
> Reported-by: Stefan Beller <sbeller@google.com>
> Signed-off-by: Pranit Bauva <pranit.bauva@gmail.com>

Thanks for writing up such a patch!
I had put it on my todo list, but you
were faster on actually going through.

Thanks,
Stefan

      parent reply	other threads:[~2017-01-03 17:52 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-31 11:44 [PATCH] don't use test_must_fail with grep Pranit Bauva
2017-01-01 14:23 ` Luke Diamand
2017-01-01 14:50   ` Johannes Sixt
2017-01-01 15:24     ` Luke Diamand
2017-01-02 13:40     ` Pranit Bauva
2017-01-07 21:18       ` Junio C Hamano
2017-01-08 16:53         ` Pranit Bauva
2017-01-02 18:45 ` [PATCH v2 1/2] " Pranit Bauva
2017-01-03 19:57   ` [PATCH v3 " Pranit Bauva
2017-01-08 16:55     ` [PATCH v4 " Pranit Bauva
2017-01-08 16:55       ` [PATCH v4 2/2] t9813: avoid using pipes Pranit Bauva
2017-01-09  9:11         ` Luke Diamand
2017-01-09  9:54           ` Junio C Hamano
2017-01-03 19:57   ` [PATCH v3 " Pranit Bauva
2017-01-04  9:11     ` Luke Diamand
2017-01-04 11:49       ` Pranit Bauva
2017-01-02 18:45 ` [PATCH v2 " Pranit Bauva
2017-01-03 17:58   ` Stefan Beller
2017-01-03 19:44     ` Pranit Bauva
2017-01-03 19:48       ` Stefan Beller
2017-01-03 17:52 ` Stefan Beller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAGZ79kYbJuujDpT-3Dj6AFkZUaKUrj8NJ=WgBbT1YbgwTibc=Q@mail.gmail.com' \
    --to=sbeller@google.com \
    --cc=git@vger.kernel.org \
    --cc=pranit.bauva@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).