From: Pranit Bauva <pranit.bauva@gmail.com>
To: Johannes Sixt <j6t@kdbg.org>
Cc: Luke Diamand <luke@diamand.org>, Git Users <git@vger.kernel.org>,
Stefan Beller <sbeller@google.com>
Subject: Re: [PATCH] don't use test_must_fail with grep
Date: Mon, 2 Jan 2017 19:10:12 +0530 [thread overview]
Message-ID: <CAFZEwPNbtamFfFy7vYXurpEWBDmRMyPB9+Ep-hm4uZVMREbq5Q@mail.gmail.com> (raw)
In-Reply-To: <285ed013-5c59-0b98-7dc0-8f729587a313@kdbg.org>
Hey Johannes,
On Sun, Jan 1, 2017 at 8:20 PM, Johannes Sixt <j6t@kdbg.org> wrote:
> which makes me wonder: Is the message that we do expect not to occur
> actually printed on stdout? It sounds much more like an error message, i.e.,
> text that is printed on stderr. Wouldn't we need this?
>
> git p4 commit >actual 2>&1 &&
> ! grep "git author.*does not match" actual &&
>
> -- Hannes
This seems better! Since I am at it, I can remove the traces of pipes
in an another patch.
Regards,
Pranit Bauva
next prev parent reply other threads:[~2017-01-02 13:40 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-31 11:44 [PATCH] don't use test_must_fail with grep Pranit Bauva
2017-01-01 14:23 ` Luke Diamand
2017-01-01 14:50 ` Johannes Sixt
2017-01-01 15:24 ` Luke Diamand
2017-01-02 13:40 ` Pranit Bauva [this message]
2017-01-07 21:18 ` Junio C Hamano
2017-01-08 16:53 ` Pranit Bauva
2017-01-02 18:45 ` [PATCH v2 1/2] " Pranit Bauva
2017-01-03 19:57 ` [PATCH v3 " Pranit Bauva
2017-01-08 16:55 ` [PATCH v4 " Pranit Bauva
2017-01-08 16:55 ` [PATCH v4 2/2] t9813: avoid using pipes Pranit Bauva
2017-01-09 9:11 ` Luke Diamand
2017-01-09 9:54 ` Junio C Hamano
2017-01-03 19:57 ` [PATCH v3 " Pranit Bauva
2017-01-04 9:11 ` Luke Diamand
2017-01-04 11:49 ` Pranit Bauva
2017-01-02 18:45 ` [PATCH v2 " Pranit Bauva
2017-01-03 17:58 ` Stefan Beller
2017-01-03 19:44 ` Pranit Bauva
2017-01-03 19:48 ` Stefan Beller
2017-01-03 17:52 ` [PATCH] don't use test_must_fail with grep Stefan Beller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFZEwPNbtamFfFy7vYXurpEWBDmRMyPB9+Ep-hm4uZVMREbq5Q@mail.gmail.com \
--to=pranit.bauva@gmail.com \
--cc=git@vger.kernel.org \
--cc=j6t@kdbg.org \
--cc=luke@diamand.org \
--cc=sbeller@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).