git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Duy Nguyen <pclouds@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: "Git Mailing List" <git@vger.kernel.org>,
	"Eric Wong" <e@80x24.org>, "Torsten Bögershausen" <tboegi@web.de>
Subject: Re: [PATCH v2] t7063: work around FreeBSD's lazy mtime update feature
Date: Wed, 3 Aug 2016 18:25:09 +0200	[thread overview]
Message-ID: <CACsJy8C3xuCj-2=8B18qpDhbRtW=S2UQ1zFLTaeqRqgXYSeyBw@mail.gmail.com> (raw)
In-Reply-To: <xmqqmvktakvt.fsf@gitster.mtv.corp.google.com>

On Wed, Aug 3, 2016 at 6:16 PM, Junio C Hamano <gitster@pobox.com> wrote:
> Nguyễn Thái Ngọc Duy  <pclouds@gmail.com> writes:
>
>>  v2 goes with Junio's suggestion (good one!).
>
> Ehh, have you even read what you copied and pasted?  "this and that"
> and "blah" are meant to be placeholders for you to fill in.

I did. But after a bit of consideration, I think the confusion caused
by "this and that" would force the reader to blame and read the entire
commit message.

> I am not sure if "-exec ls -ld" is a good idea.  Doesn't "find" by
> itself does enough lstat(2) call to work already?

Hmm.. because in some cases we could have dtype from readdir()?

> Even if it were
> necessary to trigger a separate stat(2) call, wouldn't "-ls" be
> sufficient?

Yep. Let me run some tests before sending v3.
-- 
Duy

  reply	other threads:[~2016-08-03 16:27 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-18 22:30 t7063 failure on FreeBSD 10.3 i386/amd64 Eric Wong
2016-07-18 22:54 ` Eric Wong
2016-07-19 16:12   ` Duy Nguyen
2016-07-20  3:02     ` Eric Wong
2016-07-20 14:57       ` Duy Nguyen
2016-07-27 17:33     ` Duy Nguyen
2016-07-30 13:31       ` Duy Nguyen
2016-07-30 13:54         ` Duy Nguyen
2016-07-30 18:20 ` [PATCH] t7063: work around FreeBSD's lazy mtime update feature Nguyễn Thái Ngọc Duy
2016-07-31  0:15   ` Eric Wong
2016-07-31  1:07     ` Eric Wong
2016-07-31 14:30       ` Duy Nguyen
2016-08-01  1:37   ` Torstem Bögershausen
2016-08-01 17:10     ` Duy Nguyen
2016-08-01 21:04       ` Junio C Hamano
2016-08-02 15:37         ` Duy Nguyen
2016-08-02 17:17           ` Junio C Hamano
2016-08-03 16:05   ` [PATCH v2] " Nguyễn Thái Ngọc Duy
2016-08-03 16:16     ` Junio C Hamano
2016-08-03 16:25       ` Duy Nguyen [this message]
2016-08-03 17:45     ` [PATCH v3] " Nguyễn Thái Ngọc Duy
2016-08-03 17:52       ` Junio C Hamano
2016-08-03 19:07         ` Junio C Hamano
2016-08-04 15:46           ` Duy Nguyen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CACsJy8C3xuCj-2=8B18qpDhbRtW=S2UQ1zFLTaeqRqgXYSeyBw@mail.gmail.com' \
    --to=pclouds@gmail.com \
    --cc=e@80x24.org \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=tboegi@web.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).