From: Duy Nguyen <pclouds@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: "Torstem Bögershausen" <tboegi@web.de>,
"git@vger.kernel.org" <git@vger.kernel.org>,
"e@80x24.org" <e@80x24.org>
Subject: Re: [PATCH] t7063: work around FreeBSD's lazy mtime update feature
Date: Tue, 2 Aug 2016 17:37:15 +0200 [thread overview]
Message-ID: <20160802153715.GA25286@duynguyen> (raw)
In-Reply-To: <xmqq4m74i4k3.fsf@gitster.mtv.corp.google.com>
On Mon, Aug 01, 2016 at 02:04:44PM -0700, Junio C Hamano wrote:
> Duy Nguyen <pclouds@gmail.com> writes:
>
> > On Mon, Aug 1, 2016 at 3:37 AM, Torstem Bögershausen <tboegi@web.de> wrote:
> >> the term FREEBSD may be too generic to point out a single feature
> >> in an OS distributution.
> >> Following your investigations, it may even be possible that
> >> other systems adapt this "feature"?
> >>
> >> How about
> >> LAZY_DIR_MTIME_UPDATE
> >> (or similar)
> >
> > This feature was added in 1998, so yes there's a chance it has spread
> > to a few fbsd derivatives (not sure if openbsd or netbsd is close
> > enough and they ever exchange changes). But I'd rather wait for the
> > second OS to expose the same feature before renaming it.
>
> I think a name based on the observed behaviour ("feature") would be
> more appropriate because I'd be more worried about us finding other
> glitches we see (initially) only on FBSD. People who need to adjust
> tests that use the same FBSD prereq would have to wonder which
> prereq-skip is due to which glitch.
OK how about this squashed in? The name was taken from fbsd definition
IN_LAZYMOD.
Off topic. Since I found this macro defined twice, in ext2 and ufs,
but not in zfs (found its source!), I assume zfs does not have this
particular feature (but I didn't test it). Untracked cache may be more
effecient there.
-- 8< --
diff --git a/t/t7063-status-untracked-cache.sh b/t/t7063-status-untracked-cache.sh
index 08fc586..8bb048a 100755
--- a/t/t7063-status-untracked-cache.sh
+++ b/t/t7063-status-untracked-cache.sh
@@ -419,7 +419,7 @@ test_expect_success 'create/modify files, some of which are gitignored' '
rm base
'
-test_expect_success FREEBSD 'Work around lazy mtime update' '
+test_expect_success LAZYMOD 'Work around lazy mtime update' '
ls -ld . >/dev/null
'
diff --git a/t/test-lib.sh b/t/test-lib.sh
index 3c730a2..1fc5266 100644
--- a/t/test-lib.sh
+++ b/t/test-lib.sh
@@ -962,7 +962,7 @@ case $(uname -s) in
test_set_prereq GREP_STRIPS_CR
;;
*FreeBSD*)
- test_set_prereq FREEBSD
+ test_set_prereq LAZYMOD
test_set_prereq POSIXPERM
test_set_prereq BSLASHPSPEC
test_set_prereq EXECKEEPSPID
-- 8< --
--
Duy
next prev parent reply other threads:[~2016-08-02 15:38 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-18 22:30 t7063 failure on FreeBSD 10.3 i386/amd64 Eric Wong
2016-07-18 22:54 ` Eric Wong
2016-07-19 16:12 ` Duy Nguyen
2016-07-20 3:02 ` Eric Wong
2016-07-20 14:57 ` Duy Nguyen
2016-07-27 17:33 ` Duy Nguyen
2016-07-30 13:31 ` Duy Nguyen
2016-07-30 13:54 ` Duy Nguyen
2016-07-30 18:20 ` [PATCH] t7063: work around FreeBSD's lazy mtime update feature Nguyễn Thái Ngọc Duy
2016-07-31 0:15 ` Eric Wong
2016-07-31 1:07 ` Eric Wong
2016-07-31 14:30 ` Duy Nguyen
2016-08-01 1:37 ` Torstem Bögershausen
2016-08-01 17:10 ` Duy Nguyen
2016-08-01 21:04 ` Junio C Hamano
2016-08-02 15:37 ` Duy Nguyen [this message]
2016-08-02 17:17 ` Junio C Hamano
2016-08-03 16:05 ` [PATCH v2] " Nguyễn Thái Ngọc Duy
2016-08-03 16:16 ` Junio C Hamano
2016-08-03 16:25 ` Duy Nguyen
2016-08-03 17:45 ` [PATCH v3] " Nguyễn Thái Ngọc Duy
2016-08-03 17:52 ` Junio C Hamano
2016-08-03 19:07 ` Junio C Hamano
2016-08-04 15:46 ` Duy Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160802153715.GA25286@duynguyen \
--to=pclouds@gmail.com \
--cc=e@80x24.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=tboegi@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).