From: Erlend Aasland <Erlend-A@innova.no>
To: Junio C Hamano <gitster@pobox.com>
Cc: Jeff King <peff@peff.net>,
Abhishek Kumar <abhishekkumar8222@gmail.com>,
Eric Sunshine <sunshine@sunshineco.com>,
"git@vger.kernel.org" <git@vger.kernel.org>
Subject: Re: [RFC PATCH] Make rev-parse -q and --is-* quiet
Date: Fri, 13 Mar 2020 19:10:23 +0000 [thread overview]
Message-ID: <CAB5DABE-BBBE-4E1A-83FE-E2840714CA7C@innova.no> (raw)
In-Reply-To: <xmqqa74kce4t.fsf@gitster.c.googlers.com>
Thank you all for your thorough reviews and constructive comments.
Many of you comment on the same flaws in my patch; I’ll address all of
them in the event of a second version of this patch, if you all this this
feature is worth it.
Issue 1) Naming
I’ll rename the is_set variables according to Abhishek’s proposal (is_inline,
is_shallow, etc.)
Issue 2) Premature return
Yes, I chose the easiest way out, since this was a RFC :) One
possibility could be to AND or OR the —is-* options together, but I think
going with Junio’s proposal is the most sane thing to do:
On 13 Mar 2020, at 19:18, Junio C Hamano <gitster@pobox.com> wrote:
> - when --quiet is in use, make --is-* mutually exclusive and die
> when more than one of them is given. I think any of the --is-*,
> when used with --quiet, should also be an error if there are revs
> on the command line (e.g. "git rev-parse --is-inside-git-dir
> HEAD" is OK, but not with "--quiet").
Issue 3) Exit code
I think going with Junio’s proposal (0 => true, 1 => false, 2 => error) is ok.
I’ll have another go at it, if you all think it’s worth it. If so, I’ll also add docs
and unit tests.
Erlend
> On 13 Mar 2020, at 19:18, Junio C Hamano <gitster@pobox.com> wrote:
>
> Jeff King <peff@peff.net> writes:
>
>> I'm not sure if returning a single is_set makes sense, though. It
>> effectively becomes an OR, and you wouldn't know which flag triggered
>> it. It would make more sense to me for the invocation above to simply be
>> an error, reminding the caller that they need to handle it more
>> carefully.
>>
>> We _could_ encode each value into the exit code (e.g., set bit 1 if the
>> first condition was true, and so on). But checking that becomes as much
>> hassle as reading stdout, so there's little value.
>
> None of the above excites me. I do not think it makes much sense to
> combine -q with --is-* for the reasons you stated already (i.e. the
> caller cannot tell between "failure" and "false") in the first
> place, but if we must do this:
>
> - reserve 0 (true) and 1 (false) for successful exit and use 2 (or
> above) for other failures;
>
> - when --quiet is in use, make --is-* mutually exclusive and die
> when more than one of them is given. I think any of the --is-*,
> when used with --quiet, should also be an error if there are revs
> on the command line (e.g. "git rev-parse --is-inside-git-dir
> HEAD" is OK, but not with "--quiet").
>
> is the minimum that makes me feel that we have semi-reasonable
> behaviour that can be explained to end users.
next prev parent reply other threads:[~2020-03-13 19:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-13 17:30 [RFC PATCH] Make rev-parse -q and --is-* quiet Abhishek Kumar
2020-03-13 17:47 ` Jeff King
2020-03-13 18:18 ` Junio C Hamano
2020-03-13 19:10 ` Erlend Aasland [this message]
2020-03-13 17:50 ` Eric Sunshine
-- strict thread matches above, loose matches on Subject: below --
2020-03-13 12:13 Erlend Aasland
2020-03-13 17:52 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAB5DABE-BBBE-4E1A-83FE-E2840714CA7C@innova.no \
--to=erlend-a@innova.no \
--cc=abhishekkumar8222@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).