From: Erlend Aasland <Erlend-A@innova.no>
To: "git@vger.kernel.org" <git@vger.kernel.org>
Subject: [RFC PATCH] Make rev-parse -q and --is-* quiet
Date: Fri, 13 Mar 2020 12:13:52 +0000 [thread overview]
Message-ID: <4B2A0C64-FD4A-457C-A7CF-5B680AF38BC9@innova.no> (raw)
If rev-parse is called with both -q and an --is-* option, the result is
provided as the return code of the command, iso. printed to stdout.
This simplifies using these queries in shell scripts:
git rev-parse --is-bare-repository && do_stuff
git rev-parse --is-shallow-repository && do_stuff
Signed-off-by: Erlend E. Aasland <erlend.aasland@innova.no>
---
builtin/rev-parse.c | 25 ++++++++++++++++---------
1 file changed, 16 insertions(+), 9 deletions(-)
diff --git a/builtin/rev-parse.c b/builtin/rev-parse.c
index 7a00da8203..5a8b404ec7 100644
--- a/builtin/rev-parse.c
+++ b/builtin/rev-parse.c
@@ -874,24 +874,31 @@ int cmd_rev_parse(int argc, const char **argv, const char *prefix)
continue;
}
if (!strcmp(arg, "--is-inside-git-dir")) {
- printf("%s\n", is_inside_git_dir() ? "true"
- : "false");
+ int is_set = is_inside_git_dir();
+ if (quiet)
+ return is_set ? 0 : 1;
+ printf("%s\n", is_set ? "true" : "false");
continue;
}
if (!strcmp(arg, "--is-inside-work-tree")) {
- printf("%s\n", is_inside_work_tree() ? "true"
- : "false");
+ int is_set = is_inside_work_tree();
+ if (quiet)
+ return is_set ? 0 : 1;
+ printf("%s\n", is_set ? "true" : "false");
continue;
}
if (!strcmp(arg, "--is-bare-repository")) {
- printf("%s\n", is_bare_repository() ? "true"
- : "false");
+ int is_set = is_bare_repository();
+ if (quiet)
+ return is_set ? 0 : 1;
+ printf("%s\n", is_set ? "true" : "false");
continue;
}
if (!strcmp(arg, "--is-shallow-repository")) {
- printf("%s\n",
- is_repository_shallow(the_repository) ? "true"
- : "false");
+ int is_set = is_repository_shallow(the_repository);
+ if (quiet)
+ return is_set ? 0 : 1;
+ printf("%s\n", is_set ? "true" : "false");
continue;
}
if (!strcmp(arg, "--shared-index-path")) {
--
2.25.1
next reply other threads:[~2020-03-13 12:13 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-13 12:13 Erlend Aasland [this message]
2020-03-13 17:52 ` [RFC PATCH] Make rev-parse -q and --is-* quiet Jeff King
-- strict thread matches above, loose matches on Subject: below --
2020-03-13 17:30 Abhishek Kumar
2020-03-13 17:47 ` Jeff King
2020-03-13 18:18 ` Junio C Hamano
2020-03-13 19:10 ` Erlend Aasland
2020-03-13 17:50 ` Eric Sunshine
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B2A0C64-FD4A-457C-A7CF-5B680AF38BC9@innova.no \
--to=erlend-a@innova.no \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).