git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <junkio@cox.net>
To: git@vger.kernel.org
Cc: Petr Baudis <pasky@suse.cz>,
	Johannes Schindelin <Johannes.Schindelin@gmx.de>
Subject: Re: [PATCH] Introduce Git.pm (v3)
Date: Fri, 23 Jun 2006 18:07:14 -0700	[thread overview]
Message-ID: <7vzmg35pkt.fsf@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: <7vejxf74e3.fsf@assigned-by-dhcp.cox.net> (Junio C. Hamano's message of "Fri, 23 Jun 2006 18:01:56 -0700")

Junio C Hamano <junkio@cox.net> writes:

>> It should be enough to -I../perl/blib/lib -I../perl/blib/arch/auto/Git.
>
> -- >8 --
> [PATCH] Perl interface: add build-time configuration to allow building with -fPIC
>
> On x86-64 it seems that Git.xs does not link without compiling
> the main git objects with -fPIC.
>
> Signed-off-by: Junio C Hamano <junkio@cox.net>

Eh, sorry this was in response to this part of Pasky's message:

>> Well, for the .xs you do need an .so and for that you apparently need
>> -fPIC on most architectures, so there's no way around it.
>> 
>> There's a patch to build libgit.so, would you take it as an excuse to
>> always compile with -fPIC? ;-)

By the way, I noticed NO_ACCURATE_DIFF is a compile time option
to cause git-apply to accept diff output from implementations
that botch "\No newline at the end of file", and I think it is
wrong -- it should be a run time option to git-apply if we would
want to support it, because the version of diff you have does
not have much to do with which implementations of diff were used
to generate patches you would receive and apply.

Thoughts?

  reply	other threads:[~2006-06-24  1:07 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-06-22 22:02 [PATCH] Introduce Git.pm (v3) Petr Baudis
2006-06-22 23:18 ` Junio C Hamano
2006-06-22 23:50   ` Petr Baudis
2006-06-23  0:22     ` Junio C Hamano
2006-06-23  1:12       ` Petr Baudis
2006-06-23  4:41         ` Junio C Hamano
2006-06-23  6:03           ` Jakub Narebski
2006-06-23  6:34             ` Nguyễn Thái Ngọc Duy
2006-06-23 12:45             ` Petr Baudis
2006-06-26 23:20               ` Jakub Narebski
2006-06-23  8:57         ` Junio C Hamano
2006-06-23 12:04           ` Eric W. Biederman
2006-06-23 12:39     ` Petr Baudis
2006-06-24  0:39       ` Junio C Hamano
2006-06-24  1:01       ` Junio C Hamano
2006-06-24  1:07         ` Junio C Hamano [this message]
2006-06-24 20:10           ` Johannes Schindelin
2006-06-25  1:20             ` Junio C Hamano
2006-06-25  1:54               ` Johannes Schindelin
2006-06-24  1:04       ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vzmg35pkt.fsf@assigned-by-dhcp.cox.net \
    --to=junkio@cox.net \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=git@vger.kernel.org \
    --cc=pasky@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).