From: Junio C Hamano <junkio@cox.net>
To: Petr Baudis <pasky@suse.cz>
Cc: <git@vger.kernel.org>
Subject: Re: [PATCH] Introduce Git.pm (v3)
Date: Thu, 22 Jun 2006 16:18:10 -0700 [thread overview]
Message-ID: <7vlkrohj9p.fsf@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: <20060622220201.19132.67536.stgit@machine.or.cz> (Petr Baudis's message of "Fri, 23 Jun 2006 00:02:01 +0200")
Petr Baudis <pasky@suse.cz> writes:
> * Added hash_object() and Git.xs providing the fast implementation
> * Better error reporting
> * Plenty of random minor stuff
>
> It's a good thing v2 didn't make it to the list since it contained a huge
> file which turns out that can be autogenerated at the build time, so v3
> just changes that (and adds .gitignore file and makes some other minor
> changes).
>
> I consider this patch "stable" now. Further enhancements will be posted
> as patches on top of this.
Eek. It does not compile for me -- maybe there is more
dependencies that need to be listed in INSTALL file?
make -C perl
make[1]: Entering directory `/opt/git/git.git/perl'
cc -c -I. -I.. -D_REENTRANT -D_GNU_SOURCE -DTHREADS_HAVE_PIDS -DDEBIAN -fno-strict-aliasing -pipe -I/usr/local/include -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -O2 -DVERSION=\"0.01\" -DXS_VERSION=\"0.01\" -fPIC "-I/usr/lib/perl/5.8/CORE" -O2 -Wall -Wdeclaration-after-statement -g -DSHA1_HEADER='<openssl/sha.h>' Git.c
Git.xs: In function 'XS_Git_xs_hash_object':
Git.xs:27: warning: ISO C90 forbids mixed declarations and code
Git.xs:44: warning: passing argument 1 of 'Perl_io_close' from incompatible pointer type
Git.xs:44: warning: passing argument 2 of 'Perl_io_close' makes pointer from integer without a cast
Git.xs:44: error: too few arguments to function 'Perl_io_close'
make[1]: *** [Git.o] Error 1
make[1]: Leaving directory `/opt/git/git.git/perl'
make: *** [all] Error 2
next prev parent reply other threads:[~2006-06-22 23:18 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-22 22:02 [PATCH] Introduce Git.pm (v3) Petr Baudis
2006-06-22 23:18 ` Junio C Hamano [this message]
2006-06-22 23:50 ` Petr Baudis
2006-06-23 0:22 ` Junio C Hamano
2006-06-23 1:12 ` Petr Baudis
2006-06-23 4:41 ` Junio C Hamano
2006-06-23 6:03 ` Jakub Narebski
2006-06-23 6:34 ` Nguyễn Thái Ngọc Duy
2006-06-23 12:45 ` Petr Baudis
2006-06-26 23:20 ` Jakub Narebski
2006-06-23 8:57 ` Junio C Hamano
2006-06-23 12:04 ` Eric W. Biederman
2006-06-23 12:39 ` Petr Baudis
2006-06-24 0:39 ` Junio C Hamano
2006-06-24 1:01 ` Junio C Hamano
2006-06-24 1:07 ` Junio C Hamano
2006-06-24 20:10 ` Johannes Schindelin
2006-06-25 1:20 ` Junio C Hamano
2006-06-25 1:54 ` Johannes Schindelin
2006-06-24 1:04 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vlkrohj9p.fsf@assigned-by-dhcp.cox.net \
--to=junkio@cox.net \
--cc=git@vger.kernel.org \
--cc=pasky@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).