git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <junkio@cox.net>
To: Linus Torvalds <torvalds@osdl.org>
Cc: git@vger.kernel.org, Petr Baudis <pasky@suse.cz>
Subject: Re: PPC SHA-1 Updates in "pu"
Date: Sat, 24 Jun 2006 16:59:16 -0700	[thread overview]
Message-ID: <7vd5cyt8a3.fsf@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: <Pine.LNX.4.64.0606241338370.6483@g5.osdl.org> (Linus Torvalds's message of "Sat, 24 Jun 2006 13:42:25 -0700 (PDT)")

Linus Torvalds <torvalds@osdl.org> writes:

> Don't everybody see them?

No.  But I see it now.

> how does that compile for anybody else, when -DSHA1_HEADER isn't set 
> correctly? The quotes have gone missing:
>
> 	-DSHA1_HEADER='ppc/sha1.h' 
>
> don't ask me why.

That is, as usual, caused by careless shell quoting.

        : gitster; PPC_SHA1=YesPlease Meta/Make perl/Makefile
        GIT_VERSION = 1.4.1.rc1.g9adbe
        (cd perl && /usr/bin/perl Makefile.PL \
                        PREFIX="/home/junio/git-test" \
                        DEFINE="-O2 -Wall -Wdeclaration-after-statement
                        -g -fPIC -DSHA1_HEADER='"ppc/sha1.h"'
                        -DGIT_VERSION=\\\"1.4.1.rc1.g9adbe\\\"" \
                        LIBS="libgit.a xdiff/lib.a -lz")
        Unrecognized argument in LIBS ignored: 'libgit.a'
        Unrecognized argument in LIBS ignored: 'xdiff/lib.a'
        Writing Makefile for Git

All options but to use OpenSSL SHA-1 implementation share the
same problem (Meta/Make is a thin "make" wrapper to give USE_PIC
and other C compilation flags):

        : gitster; ARM_SHA1=YesPlease Meta/Make perl/Makefile
        (cd perl && /usr/bin/perl Makefile.PL \
                        PREFIX="/home/junio/git-test" \
                        DEFINE="-O2 -Wall -Wdeclaration-after-statement
                        -g -fPIC -DSHA1_HEADER='"arm/sha1.h"'
                        -DGIT_VERSION=\\\"1.4.1.rc1.g9adbe\\\"" \
                        LIBS="libgit.a xdiff/lib.a -lz")
        Unrecognized argument in LIBS ignored: 'libgit.a'
        Unrecognized argument in LIBS ignored: 'xdiff/lib.a'
        Writing Makefile for Git

        : gitster; MOZILLA_SHA1=YesPlease Meta/Make perl/Makefile
        (cd perl && /usr/bin/perl Makefile.PL \
                        PREFIX="/home/junio/git-test" \
                        DEFINE="-O2 -Wall -Wdeclaration-after-statement
                        -g -fPIC -DSHA1_HEADER='"mozilla-sha1/sha1.h"'
                        -DGIT_VERSION=\\\"1.4.1.rc1.g9adbe\\\"" \
                        LIBS="libgit.a xdiff/lib.a -lz")
        Unrecognized argument in LIBS ignored: 'libgit.a'
        Unrecognized argument in LIBS ignored: 'xdiff/lib.a'
        Writing Makefile for Git

  reply	other threads:[~2006-06-24 23:59 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-06-23 17:18 x86 asm SHA1 (draft) linux
2006-06-24  0:18 ` Junio C Hamano
2006-06-24  1:22   ` linux
2006-06-24  7:03     ` Junio C Hamano
2006-06-24  7:59       ` From b65bc21e7d8dc8cafc70dfa6354cb66b8874b2d9 Mon Sep 17 00:00:00 2001, [PATCH] Makefile: add framework to verify and bench sha1 implementations Junio C Hamano, Junio C Hamano
2006-06-24  9:29         ` From b65bc21e7d8dc8cafc70dfa6354cb66b8874b2d9 Mon Sep 17 00:00:00 2001 " linux
2006-06-24 19:47           ` Junio C Hamano
2006-06-24  9:20       ` x86 asm SHA1 (draft) linux
2006-06-24 10:03       ` PPC SHA-1 Updates in "pu" Junio C Hamano
2006-06-24 18:55         ` Linus Torvalds
2006-06-24 20:21           ` Junio C Hamano
2006-06-24 20:42             ` Linus Torvalds
2006-06-24 23:59               ` Junio C Hamano [this message]
2006-06-25  1:02                 ` Petr Baudis
2006-06-25  1:40                   ` [PATCH] Git.pm build: Fix quoting and missing GIT-CFLAGS dependency Petr Baudis
2006-06-25  3:03                     ` Junio C Hamano
2006-06-25 15:21                       ` Petr Baudis
2006-06-26  6:48                         ` Junio C Hamano
2006-07-01 23:59                           ` [POOL] Who likes running Git without make install? Petr Baudis
2006-07-02  0:05                             ` Junio C Hamano
2006-07-02  0:08                             ` Junio C Hamano
2006-07-02 11:30                               ` Petr Baudis
2006-07-02 17:19                                 ` Junio C Hamano
2006-07-03  6:54                             ` [POLL] " Junio C Hamano
2006-07-03  7:58                               ` Petr Baudis
2006-07-03  8:08                                 ` Junio C Hamano
2006-07-03  8:17                                   ` Petr Baudis
2006-07-03  8:37                                     ` Johannes Schindelin
2006-06-25  1:24             ` PPC SHA-1 Updates in "pu" Petr Baudis
2006-06-25  3:57               ` Junio C Hamano
2006-06-25  9:34                 ` Petr Baudis
2006-06-25 10:07                   ` Johannes Schindelin
2006-06-25 10:20                     ` Petr Baudis
2006-06-25 10:48                       ` Junio C Hamano
2006-06-25 13:44                         ` Johannes Schindelin
2006-06-25 18:46                           ` Randal L. Schwartz
2006-06-25 23:23                             ` Johannes Schindelin
2006-06-26  1:51                               ` perl profiling (was: PPC SHA-1 Updates in "pu") Jeff King
2006-06-26  6:49                           ` PPC SHA-1 Updates in "pu" Junio C Hamano
2006-06-30  1:28             ` GIt.xs merge status Junio C Hamano
2006-06-30  5:08               ` Pavel Roskin
2006-06-30  7:18                 ` Git.xs " Junio C Hamano
2006-06-30  7:28                   ` Pavel Roskin
2006-06-30  9:53               ` GIt.xs " Johannes Schindelin
2006-06-30 10:26                 ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vd5cyt8a3.fsf@assigned-by-dhcp.cox.net \
    --to=junkio@cox.net \
    --cc=git@vger.kernel.org \
    --cc=pasky@suse.cz \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).