From: Petr Baudis <pasky@suse.cz>
To: Junio C Hamano <junkio@cox.net>
Cc: Chris Wright <chrisw@osdl.org>,
Linus Torvalds <torvalds@osdl.org>,
git@vger.kernel.org
Subject: Re: [PATCH] Git.pm build: Fix quoting and missing GIT-CFLAGS dependency
Date: Sun, 25 Jun 2006 17:21:57 +0200 [thread overview]
Message-ID: <20060625152157.GG21864@pasky.or.cz> (raw)
In-Reply-To: <7vac82q6mb.fsf@assigned-by-dhcp.cox.net>
Dear diary, on Sun, Jun 25, 2006 at 05:03:24AM CEST, I got a letter
where Junio C Hamano <junkio@cox.net> said that...
> During our a handful piecemeal patch exchange back-and-forth on
> the list, most of the patches did not apply mechanically, so I
> rolled them up and have pushed out the result in "pu" and it
> will mirror out shortly. I am reasonably sure it is in much
> better shape than 24 hours ago; could you double check the
> result for me please?
It looks good; I don't like the makefile changes a lot but more on that
below.
Could you please also throw in these two?
[PATCH 3/7] Git.pm: Swap hash_object() parameters
[PATCH 4/7] Git.pm: Fix Git->repository("/somewhere/totally/elsewhere")
..snip..
> - RPM target -- we probably acquired a new build-dependency in
> which case the .spec file needs to be updated;
..snip..
> I think we have cleared SITELIBARCH, and Git.xs building is in
> testable state for wider audience. The remaining hurdles are to
> make sure the RPM target is still sensible, and fix the test
> scheme.
>
> Now, I am clueless about RPM, so help is very much appreciated.
Chris, could you help, please? Do we need to insert anything special
to builddeps if we build own Perl module?
> About the testsuite, I think with the way git-fmt-merge-msg (and
> other Perl scripts that will use Git.pm) is munged on the
> initial line "#!/usr/bin/perl -I$(installedpath)", the test
> scheme is seriously broken. To see how yourself, have a good
> working version of Git.pm and friends in the path your
> git-fmt-merge-msg's first line points at, apply the following
> patch to perl/Git.pm in your source tree and run "make test".
> It will pass t5700-clone-reference.sh test, which does "git
> pull" (and uses git-fmt-merge-msg) without problems X-<.
Yes, -I is very broken. I have abandoned it in:
Subject: Re: [PATCH 01/12] Introduce Git.pm (v4)
Date: Sat, 24 Jun 2006 13:52:27 +0200
The advantage to your approach is that it works properly without
requiring to make install even outside of the testsuite.
> The additional dependency to perl/Makefile is needed regardless
> of this tentative fix -- you cannot run make -C perl before
> building perl/Makefile.
Yes, that bit shall be Acked-by: Petr Baudis <pasky@suse.cz>
--
Petr "Pasky" Baudis
Stuff: http://pasky.or.cz/
A person is just about as big as the things that make them angry.
next prev parent reply other threads:[~2006-06-25 15:22 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-23 17:18 x86 asm SHA1 (draft) linux
2006-06-24 0:18 ` Junio C Hamano
2006-06-24 1:22 ` linux
2006-06-24 7:03 ` Junio C Hamano
2006-06-24 7:59 ` From b65bc21e7d8dc8cafc70dfa6354cb66b8874b2d9 Mon Sep 17 00:00:00 2001, [PATCH] Makefile: add framework to verify and bench sha1 implementations Junio C Hamano, Junio C Hamano
2006-06-24 9:29 ` From b65bc21e7d8dc8cafc70dfa6354cb66b8874b2d9 Mon Sep 17 00:00:00 2001 " linux
2006-06-24 19:47 ` Junio C Hamano
2006-06-24 9:20 ` x86 asm SHA1 (draft) linux
2006-06-24 10:03 ` PPC SHA-1 Updates in "pu" Junio C Hamano
2006-06-24 18:55 ` Linus Torvalds
2006-06-24 20:21 ` Junio C Hamano
2006-06-24 20:42 ` Linus Torvalds
2006-06-24 23:59 ` Junio C Hamano
2006-06-25 1:02 ` Petr Baudis
2006-06-25 1:40 ` [PATCH] Git.pm build: Fix quoting and missing GIT-CFLAGS dependency Petr Baudis
2006-06-25 3:03 ` Junio C Hamano
2006-06-25 15:21 ` Petr Baudis [this message]
2006-06-26 6:48 ` Junio C Hamano
2006-07-01 23:59 ` [POOL] Who likes running Git without make install? Petr Baudis
2006-07-02 0:05 ` Junio C Hamano
2006-07-02 0:08 ` Junio C Hamano
2006-07-02 11:30 ` Petr Baudis
2006-07-02 17:19 ` Junio C Hamano
2006-07-03 6:54 ` [POLL] " Junio C Hamano
2006-07-03 7:58 ` Petr Baudis
2006-07-03 8:08 ` Junio C Hamano
2006-07-03 8:17 ` Petr Baudis
2006-07-03 8:37 ` Johannes Schindelin
2006-06-25 1:24 ` PPC SHA-1 Updates in "pu" Petr Baudis
2006-06-25 3:57 ` Junio C Hamano
2006-06-25 9:34 ` Petr Baudis
2006-06-25 10:07 ` Johannes Schindelin
2006-06-25 10:20 ` Petr Baudis
2006-06-25 10:48 ` Junio C Hamano
2006-06-25 13:44 ` Johannes Schindelin
2006-06-25 18:46 ` Randal L. Schwartz
2006-06-25 23:23 ` Johannes Schindelin
2006-06-26 1:51 ` perl profiling (was: PPC SHA-1 Updates in "pu") Jeff King
2006-06-26 6:49 ` PPC SHA-1 Updates in "pu" Junio C Hamano
2006-06-30 1:28 ` GIt.xs merge status Junio C Hamano
2006-06-30 5:08 ` Pavel Roskin
2006-06-30 7:18 ` Git.xs " Junio C Hamano
2006-06-30 7:28 ` Pavel Roskin
2006-06-30 9:53 ` GIt.xs " Johannes Schindelin
2006-06-30 10:26 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060625152157.GG21864@pasky.or.cz \
--to=pasky@suse.cz \
--cc=chrisw@osdl.org \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).