From: "Philip Oakley" <philipoakley@iee.org>
To: "Duy Nguyen" <pclouds@gmail.com>
Cc: "Git Mailing List" <git@vger.kernel.org>,
"Junio C Hamano" <gitster@pobox.com>, "Jeff King" <peff@peff.net>,
"Sebastian Schuberth" <sschuberth@gmail.com>,
"Matthieu Moy" <Matthieu.Moy@grenoble-inp.fr>
Subject: Re: [PATCH v6 1/1] config: add conditional include
Date: Sun, 26 Feb 2017 12:27:24 -0000 [thread overview]
Message-ID: <744E670407404147B290392DAD79DF44@PhilipOakley> (raw)
In-Reply-To: CACsJy8Bq-P8Aw+f0omndCmQU54n_p7ZwDVDK9APuH_3vXDac2g@mail.gmail.com
From: "Duy Nguyen" <pclouds@gmail.com>
> On Sat, Feb 25, 2017 at 5:08 AM, Philip Oakley <philipoakley@iee.org>
> wrote:
>>> +Conditional includes
>>> +~~~~~~~~~~~~~~~~~~~~
>>> +
>>> +You can include one config file from another conditionally by setting
>>
>>
>> On first reading I thought this implied you can only have one `includeIf`
>> within the config file.
>> I think it is meant to mean that each `includeIf`could include one other
>> file, and that users can have multiple `includeIf` lines.
>
> Yes. Not sure how to put it better though (I basically copied the
> first paragraph from the unconditional include section above, which
> shares the same confusion). Perhaps just write "the variable can be
> specified multiple times"? Or "multiple variables include multiple
> times, the last variable does not override the previous ones"?
> --
My attempt, based on updating the `Includes` section would be something
like:
`You can include a config file from another by setting the special
`include.path` variable to the name of the file to be included. The variable
takes a pathname as its value, and is subject to tilde expansion.
`include.path` supports multiple key values.`
The subtle change was to s/one/a/ at the start, and then add the final short
sentence that states that the section's variables can have multiple key
values.
I copied the 'multiple key values' phrase from the man page intro for
consitency, though 'multivalued' could just as easily be used as it is the
term used by the 'Configuration File' section that this is part of
https://git-scm.com/docs/git-config#_configuration_file.
Even shorter may be:
`You can include a config file from another by setting the special
`include.path` variable to the name of the file to be included. The variable
(can be multivalued) takes a pathname as its value, and is subject to tilde
expansion.`
The Conditional Includes would follow suit.
Philip
next prev parent reply other threads:[~2017-02-26 12:28 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-23 12:23 [PATCH v5 0/1] Conditional config include Nguyễn Thái Ngọc Duy
2017-02-23 12:23 ` [PATCH v5 1/1] config: add conditional include Nguyễn Thái Ngọc Duy
2017-02-23 19:59 ` Junio C Hamano
2017-02-24 9:37 ` Duy Nguyen
2017-02-24 17:46 ` Junio C Hamano
2017-02-26 6:07 ` Jeff King
2017-02-27 18:42 ` Junio C Hamano
2017-03-06 22:44 ` Stefan Beller
2017-03-07 8:47 ` Jeff King
2017-03-07 18:39 ` Stefan Beller
2017-02-24 13:14 ` [PATCH v6 0/1] Conditional config include Nguyễn Thái Ngọc Duy
2017-02-24 13:14 ` [PATCH v6 1/1] config: add conditional include Nguyễn Thái Ngọc Duy
2017-02-24 18:35 ` Junio C Hamano
2017-02-24 19:48 ` Ramsay Jones
2017-02-24 22:08 ` Philip Oakley
2017-02-26 3:02 ` Duy Nguyen
2017-02-26 12:27 ` Philip Oakley [this message]
2017-02-24 13:14 ` [PATCH v6 0/1] Conditional config include Nguyễn Thái Ngọc Duy
2017-02-24 13:18 ` Duy Nguyen
2017-02-24 13:14 ` [PATCH v6 1/1] config: add conditional include Nguyễn Thái Ngọc Duy
2017-02-26 6:12 ` Jeff King
2017-03-01 11:26 ` [PATCH v7 0/3] Conditional config include Nguyễn Thái Ngọc Duy
2017-03-01 11:26 ` [PATCH v7 1/3] config.txt: clarify multiple key values in include.path Nguyễn Thái Ngọc Duy
2017-03-01 17:40 ` Junio C Hamano
2017-03-01 11:26 ` [PATCH v7 2/3] config.txt: reflow the second include.path paragraph Nguyễn Thái Ngọc Duy
2017-03-01 11:26 ` [PATCH v7 3/3] config: add conditional include Nguyễn Thái Ngọc Duy
2017-03-01 17:16 ` Ramsay Jones
2017-03-01 17:47 ` Junio C Hamano
2017-03-03 6:30 ` Jeff King
2017-03-03 19:05 ` Junio C Hamano
2017-03-03 22:24 ` Jeff King
2017-03-01 17:52 ` [PATCH v7 0/3] Conditional config include Junio C Hamano
2017-03-03 6:33 ` Jeff King
2017-03-03 9:52 ` Duy Nguyen
2017-03-03 19:13 ` Junio C Hamano
2017-03-03 21:08 ` Junio C Hamano
2017-03-03 18:24 ` Junio C Hamano
2017-03-03 22:22 ` Jeff King
2017-03-03 23:22 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=744E670407404147B290392DAD79DF44@PhilipOakley \
--to=philipoakley@iee.org \
--cc=Matthieu.Moy@grenoble-inp.fr \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=pclouds@gmail.com \
--cc=peff@peff.net \
--cc=sschuberth@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).