Re: test failure

[Lars Schneider <larsxschneider@gmail.com>]

> On 16 Dec 2016, at 21:32, Ramsay Jones <ramsay@ramsayjones.plus.com> wrote:
> 
> Hi Lars,
> 
> For the last two days, I've noticed t0021.15 on the 'pu' branch has been failing intermittently (well it fails with: 'make test >ptest-out', but
> when run by hand, it fails only say 1-in-6, 1-in-18, etc.).
> 
> [yes, it's a bit strange; this hasn't changed in a couple of weeks!]
> 
> I don't have time to investigate further tonight and, since I had not
> heard anyone else complain, I thought I should let you know.
> 
> See below for the output from a failing run. [Note: this is on Linux
> Mint 18, tonight's pu branch @7c7984401].

Thanks Ramsay! 

I was able to reproduce the problem with this test:

	test_expect_success 'ramsay-report' '
		test_config_global filter.protocol.clean cat &&
		git init &&
		echo "*.r filter=protocol" >.gitattributes &&
		echo "bla" >test.r &&
		git add . &&
		GIT_TRACE=1 git commit -m "test commit 2" > trace 2>&1 &&
		grep "run_command" trace
	'

It looks like as if Git occasionally forgets to run the clean filter.
I bisected the problem and I think the problem starts with "diff: do not 
reuse worktree files that need "clean" conversion" (06dec439a3) which
definitively sounds related.

Back in June I reported that Git invokes the clean process 4 times if a
single file is added. Peff took a closer look and suggested the patch
mentioned above to remove one unnecessary invocation. I re-read his comments
and everything sounds still reasonable to me:
http://public-inbox.org/git/1469134747-26785-1-git-send-email-larsxschneider@gmail.com/#t

Does anyone have a clue what is going on? 
I keep digging...

Thanks,
Lars