From: Beat Bolli <dev+git@drbeat.li>
To: git@vger.kernel.org
Cc: Git mailing list <git@vger.kernel.org>, Jeff King <peff@peff.net>
Subject: Re: [PATCH v3] coccicheck: process every source file at once
Date: Sun, 7 Oct 2018 13:36:27 +0200 [thread overview]
Message-ID: <4f705fbc-e1a3-8e27-02ed-39a5c3dcfdcc@drbeat.li> (raw)
In-Reply-To: <CA+P7+xoqKG84n5EMKbajuZoXrOKZMudZ6CT-OKzz8XYyTYaCWQ@mail.gmail.com>
On 02.10.18 22:18, Jacob Keller wrote:
> On Tue, Oct 2, 2018 at 1:07 PM Jacob Keller <jacob.e.keller@intel.com> wrote:
>>
>> From: Jacob Keller <jacob.keller@gmail.com>
>>
>> make coccicheck is used in order to apply coccinelle semantic patches,
>> and see if any of the transformations found within contrib/coccinelle/
>> can be applied to the current code base.
>>
>> Pass every file to a single invocation of spatch, instead of running
>> spatch once per source file.
>>
>> This reduces the time required to run make coccicheck by a significant
>> amount of time:
>>
>> Prior timing of make coccicheck
>> real 6m14.090s
>> user 25m2.606s
>> sys 1m22.919s
>>
>> New timing of make coccicheck
>> real 1m36.580s
>> user 7m55.933s
>> sys 0m18.219s
>>
>> This is nearly a 4x decrease in the time required to run make
>> coccicheck. This is due to the overhead of restarting spatch for every
>> file. By processing all files at once, we can amortize this startup cost
>> across the total number of files, rather than paying it once per file.
>>
>> Signed-off-by: Jacob Keller <jacob.keller@gmail.com>
>> ---
>
> Forgot to add what changed. I dropped the subshell and "||" bit around
> invoking spatch.
>
> Thanks,
> Jake
>
>
>> Makefile | 6 ++----
>> 1 file changed, 2 insertions(+), 4 deletions(-)
>>
>> diff --git a/Makefile b/Makefile
>> index df1df9db78da..da692ece9e12 100644
>> --- a/Makefile
>> +++ b/Makefile
>> @@ -2715,10 +2715,8 @@ endif
>> %.cocci.patch: %.cocci $(COCCI_SOURCES)
>> @echo ' ' SPATCH $<; \
>> ret=0; \
>> - for f in $(COCCI_SOURCES); do \
>> - $(SPATCH) --sp-file $< $$f $(SPATCH_FLAGS) || \
>> - { ret=$$?; break; }; \
>> - done >$@+ 2>$@.log; \
>> + $(SPATCH) --sp-file $< $(COCCI_SOURCES) $(SPATCH_FLAGS) >$@+ 2>$@.log; \
>> + ret=$$?; \
>> if test $$ret != 0; \
>> then \
>> cat $@.log; \
>> --
>> 2.18.0.219.gaf81d287a9da
>>
Wouldn't the following be even simpler?
diff --git a/Makefile b/Makefile
index 5c8307b7c479..a37b2724d526 100644
--- a/Makefile
+++ b/Makefile
@@ -2701,12 +2701,7 @@ endif
%.cocci.patch: %.cocci $(COCCI_SOURCES)
@echo ' ' SPATCH $<; \
- ret=0; \
- for f in $(COCCI_SOURCES); do \
- $(SPATCH) --sp-file $< $$f $(SPATCH_FLAGS) || \
- { ret=$$?; break; }; \
- done >$@+ 2>$@.log; \
- if test $$ret != 0; \
+ if ! $(SPATCH) --sp-file $< $(COCCI_SOURCES) $(SPATCH_FLAGS)
>$@+ 2>$@.log; \
then \
cat $@.log; \
exit 1; \
Cheers,
Beat
next prev parent reply other threads:[~2018-10-07 11:38 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-02 20:07 [PATCH v3] coccicheck: process every source file at once Jacob Keller
2018-10-02 20:18 ` Jacob Keller
2018-10-05 2:17 ` Jacob Keller
2018-10-05 12:40 ` SZEDER Gábor
2018-10-05 16:25 ` Jeff King
2018-10-05 16:53 ` Keller, Jacob E
2018-10-05 16:59 ` Jeff King
2018-10-05 18:50 ` SZEDER Gábor
2018-10-05 19:00 ` Jeff King
2018-10-05 23:10 ` Jacob Keller
2018-10-06 8:42 ` René Scharfe
2018-10-09 3:11 ` Jeff King
2018-10-05 18:39 ` SZEDER Gábor
2018-10-05 19:02 ` Jeff King
2018-10-05 19:54 ` SZEDER Gábor
2018-10-09 3:15 ` Jeff King
2018-10-10 11:44 ` SZEDER Gábor
2018-10-10 13:59 ` Jeff King
2018-10-07 11:36 ` Beat Bolli [this message]
2018-10-07 11:49 ` Beat Bolli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4f705fbc-e1a3-8e27-02ed-39a5c3dcfdcc@drbeat.li \
--to=dev+git@drbeat.li \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).