From: "SZEDER Gábor" <szeder.dev@gmail.com>
To: Jeff King <peff@peff.net>
Cc: Jacob Keller <jacob.keller@gmail.com>,
Jacob Keller <jacob.e.keller@intel.com>,
Git mailing list <git@vger.kernel.org>
Subject: Re: [PATCH v3] coccicheck: process every source file at once
Date: Wed, 10 Oct 2018 13:44:41 +0200 [thread overview]
Message-ID: <20181010114441.GD23446@szeder.dev> (raw)
In-Reply-To: <20181009031542.GD6250@sigill.intra.peff.net>
On Mon, Oct 08, 2018 at 11:15:42PM -0400, Jeff King wrote:
> On Fri, Oct 05, 2018 at 09:54:13PM +0200, SZEDER Gábor wrote:
>
> > Runtimes tend to fluctuate quite a bit more on Travis CI compared to
> > my machine, but not this much, and it seems to be consistent so far.
> >
> > After scripting/querying the Travis CI API a bit, I found that from
> > the last 100 static analysis build jobs 78 did actully run 'make
> > coccicheck' [1], avaraging 470s for the whole build job, with only 4
> > build job exceeding the 10min mark.
> >
> > I had maybe 6-8 build jobs running this patch over the last 2-3 days,
> > I think all of them were over 15min. (I restarted some of them, so I
> > don't have separate logs for all of them, hence the uncertainty.)
>
> So that's really weird and counter-intuitive, since we should be doing
> strictly less work. I know that spatch tries to parallelize itself,
> though from my tests, 1.0.4 does not. I wonder if the version in Travis
> differs in that respect and starts too many threads, and the extra time
> is going to contention and context switches.
I don't think it does any parallel work.
Here is the timing again from my previous email:
960.50user 22.59system 16:23.74elapsed 99%CPU (0avgtext+0avgdata 1606156maxresident)k
Notice that 16:23 is 983s, and that it matches the sum of the user and
system times. I usually saw this kind of timing with CPU-intensive
single-threaded programs, and if there were any parallelization, then I
would expect the elapsed time to be at least somewhat smaller than the
other two.
> Have you tried passing "-j1" to spatch? My 1.0.4 does not even recognize
> it.
I have just gave it a try, but the v1.0.0 on Travis CI errored out with
"unknown option `-j'.
https://travis-ci.org/szeder/git/jobs/439532822#L566
> That seems like a pretty unlikely explanation to me, but I am having
> trouble coming up with another one.
>
> I guess the other plausible thing is that the extra memory is forcing us
> into some slower path. E.g., a hypervisor may even be swapping,
> unbeknownst to the child OS, and it gets accounted in the child OS as
> "boy, that memory load was really slow", which becomes used CPU.
>
> That actually sounds more credible to me.
>
> -Peff
next prev parent reply other threads:[~2018-10-10 11:44 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-02 20:07 [PATCH v3] coccicheck: process every source file at once Jacob Keller
2018-10-02 20:18 ` Jacob Keller
2018-10-05 2:17 ` Jacob Keller
2018-10-05 12:40 ` SZEDER Gábor
2018-10-05 16:25 ` Jeff King
2018-10-05 16:53 ` Keller, Jacob E
2018-10-05 16:59 ` Jeff King
2018-10-05 18:50 ` SZEDER Gábor
2018-10-05 19:00 ` Jeff King
2018-10-05 23:10 ` Jacob Keller
2018-10-06 8:42 ` René Scharfe
2018-10-09 3:11 ` Jeff King
2018-10-05 18:39 ` SZEDER Gábor
2018-10-05 19:02 ` Jeff King
2018-10-05 19:54 ` SZEDER Gábor
2018-10-09 3:15 ` Jeff King
2018-10-10 11:44 ` SZEDER Gábor [this message]
2018-10-10 13:59 ` Jeff King
2018-10-07 11:36 ` Beat Bolli
2018-10-07 11:49 ` Beat Bolli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181010114441.GD23446@szeder.dev \
--to=szeder.dev@gmail.com \
--cc=git@vger.kernel.org \
--cc=jacob.e.keller@intel.com \
--cc=jacob.keller@gmail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).