From: "Torsten Bögershausen" <tboegi@web.de>
To: Lars Schneider <larsxschneider@gmail.com>,
Junio C Hamano <gitster@pobox.com>
Cc: Johannes Schindelin <Johannes.Schindelin@gmx.de>,
Johannes Sixt <j6t@kdbg.org>, git <git@vger.kernel.org>,
Jeff King <peff@peff.net>
Subject: Re: [PATCH] t0021, t5615: use $PWD instead of $(pwd) in PATH-like shell variables
Date: Mon, 14 Nov 2016 17:35:56 +0100 [thread overview]
Message-ID: <35d3a07d-5d2f-aedd-94bc-4d92e5aa4661@web.de> (raw)
In-Reply-To: <0BEC2674-20B5-4AD1-851A-97CA34C0CE7F@gmail.com>
On 14.11.16 10:11, Lars Schneider wrote:
>
>> On 13 Nov 2016, at 02:13, Junio C Hamano <gitster@pobox.com> wrote:
>>
>> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
>>
>>>> Thanks. Dscho, does this fix both of these issues to you?
>>>
>>> Apparently it does because the CI jobs for `master` and for `next` pass.
>>
>> OK, thanks for a quick confirmation.
>>
>>> The one for `pu` still times out, of course.
>>
>> Earlier you said 'pu' did even not build, but do we know where this
>> "still times out" comes from? As long as I don't merge anything
>> prematurely, which I need to be careful about, it shouldn't impact
>> the upcoming release, but we'd need to figure it out before moving
>> things forward post release.
>
> What is the goal for 'pu'?
>
> (1) Builds clean on all platforms + passes all tests
Yes
> (2) Builds clean on all platforms
Yes
> (3) Builds clean on Linux
Yes
> (4) Just makes new topics easily available to a broader audience
Yes
>
> My understanding was always (4) but the discussion above sounds
> more like (1) or (2)?
All commits should work on all platforms - in the ideal world there is no problem.
From time to time things sneak in, which are not portable.
(in the sense that not all "supported" compile/run tests without breakages)
And if everybody reports breakages and problems found on the pu
branch, there is a good chance that they don't reach next or master.
Does this make sense ?
>
> --
>
> Git 'pu' does not compile on macOS right now:
> builtin/bisect--helper.c:299:6: error: variable 'good_syn' is used uninitialized
> whenever 'if' condition is true [-Werror,-Wsometimes-uninitialized]
> ...
>
> More info here:
> https://api.travis-ci.org/jobs/175417712/log.txt?deansi=true
>
> --
>
> Cheers,
> Lars
>
next prev parent reply other threads:[~2016-11-14 16:36 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-11 16:29 [PATCH] mingw: hot-fix t5615 Johannes Schindelin
2016-11-11 17:06 ` Junio C Hamano
2016-11-11 17:11 ` Johannes Sixt
2016-11-11 17:31 ` [PATCH] t0021, t5615: use $PWD instead of $(pwd) in PATH-like shell variables Johannes Sixt
2016-11-11 18:16 ` Jeff King
2016-11-11 18:55 ` Junio C Hamano
2016-11-12 11:40 ` Johannes Schindelin
2016-11-13 1:13 ` Junio C Hamano
2016-11-14 9:11 ` Lars Schneider
2016-11-14 16:35 ` Torsten Bögershausen [this message]
2016-11-14 17:01 ` Jeff King
2016-11-14 19:45 ` Ramsay Jones
2016-11-14 17:21 ` Junio C Hamano
2016-11-15 16:54 ` Johannes Schindelin
2016-11-16 9:47 ` Johannes Schindelin
2016-11-16 21:51 ` Junio C Hamano
2016-11-11 18:12 ` [PATCH] mingw: hot-fix t5615 Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=35d3a07d-5d2f-aedd-94bc-4d92e5aa4661@web.de \
--to=tboegi@web.de \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=j6t@kdbg.org \
--cc=larsxschneider@gmail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).