From: Emily Shaffer <emilyshaffer@google.com>
To: Joey S <jgsal@protonmail.com>
Cc: "git@vger.kernel.org" <git@vger.kernel.org>
Subject: Re: [OUTREACHY][PATCH v1] t7006: Use test_path_is_* functions in test script
Date: Mon, 19 Oct 2020 17:11:03 -0700 [thread overview]
Message-ID: <20201020001103.GB2774782@google.com> (raw)
In-Reply-To: <ERmIkC3rLZ3BAyv2Nq_GK0CjWvEQw6ejl8V-HVvwCsyIv0guQV67nO8KMLi7eA9qO5mo_ZJ8XB360uP_LtP-LY1xsaRBXHsc0F1uSID-KPE=@protonmail.com>
On Mon, Oct 19, 2020 at 04:26:07AM +0000, Joey S wrote:
>
> Hi everyone,
Hi Joey and welcome.
>
> Signed-off-by: JoeyS <jgsal@yahoo.com>
One thing missed by other commenters: the Developer's Certificate of
Origin line - which is what this indicates - should have your "full
name". So in my case, I sign my patches 'Emily Shaffer
<emilyshaffer@google.com>'. If I'm wrong that's fine, but JoeyS sounds
like a name and initial rather than a full name.
The rest of the patch looks okay to me, though.
- Emily
next prev parent reply other threads:[~2020-10-20 0:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-19 4:26 [OUTREACHY][PATCH v1] t7006: Use test_path_is_* functions in test script Joey S
2020-10-19 11:28 ` Phillip Wood
2020-10-19 20:28 ` Taylor Blau
2020-10-20 0:11 ` Emily Shaffer [this message]
2020-10-20 1:59 ` Junio C Hamano
2020-10-20 7:24 ` Joey S
2020-10-20 12:19 ` Phillip Wood
2020-10-20 19:33 ` Joey S
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201020001103.GB2774782@google.com \
--to=emilyshaffer@google.com \
--cc=git@vger.kernel.org \
--cc=jgsal@protonmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).