From: Taylor Blau <me@ttaylorr.com>
To: phillip.wood@dunelm.org.uk
Cc: Joey S <jgsal@protonmail.com>,
"git@vger.kernel.org" <git@vger.kernel.org>
Subject: Re: [OUTREACHY][PATCH v1] t7006: Use test_path_is_* functions in test script
Date: Mon, 19 Oct 2020 16:28:07 -0400 [thread overview]
Message-ID: <20201019202807.GA47395@nand.local> (raw)
In-Reply-To: <ff9619cd-8a31-9ce4-f0e9-c7291a4141d2@talktalk.net>
On Mon, Oct 19, 2020 at 12:28:33PM +0100, Phillip Wood wrote:
> Hi Joey
>
> On 19/10/2020 05:26, Joey S wrote:
> > Hi everyone,
> >
> > This is my first contribution to Git's public repo and, after using Git for several years, I'm very looking forward to becoming an active member of the community.
>
> Welcome to the list
Indeed :-).
> > In this patch for test t7006-pager, I have:
> >
> > - ensured the guidelines[1] were followed
> > - used the helper function 'test_path_is_file()' to replace all found instances of 'test -e'
> >
> > Please find the output of 'git format-patch' below.
> >
> > Thank you all, looking forward to your feedback and observations,
> >
> > Joey
> >
> > [1] lore.kernel.org/git/CAPig+cQpUu2UO-+jWn1nTaDykWnxwuEitzVB7PnW2SS_b7V8Hg@mail.gmail.com/
> >
>
> All this text above is useful context for reviewers but appears as part of
> the commit message which is not what you want. If you add notes after the
> `---` line below then they will not end up in the commit message.
...Alternatively, this would fit just fine in a cover letter. Usually
cover letters are not necessary for single patches (where the patch
message itself conveys the full message, or a little bit of additional
context below the triple-dash line is all that's necessary to clarify
the intent). But, if you want to introduce yourself, a 0/1 cover letter
is fine, too.
> > test_expect_failure TTY 'pager runs from subdir' '
> > @@ -65,49 +65,49 @@ test_expect_success !MINGW,TTY 'LESS and LV envvars set by git-sh-setup' '
> > test_expect_success TTY 'some commands do not use a pager' '
> > rm -f paginated.out &&
> > test_terminal git rev-list HEAD &&
> > - ! test -e paginated.out
> > + ! test_path_is_file paginated.out
>
> It would be better to replace `! test -e` this with `test_path_is_missing`
> as the modified test will pass if paginated.out exists but is not a file.
> `test_path_is_missing` will print an appropriate diagnostic message as well.
Yup, great catch.
Thanks,
Taylor
next prev parent reply other threads:[~2020-10-19 20:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-19 4:26 [OUTREACHY][PATCH v1] t7006: Use test_path_is_* functions in test script Joey S
2020-10-19 11:28 ` Phillip Wood
2020-10-19 20:28 ` Taylor Blau [this message]
2020-10-20 0:11 ` Emily Shaffer
2020-10-20 1:59 ` Junio C Hamano
2020-10-20 7:24 ` Joey S
2020-10-20 12:19 ` Phillip Wood
2020-10-20 19:33 ` Joey S
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201019202807.GA47395@nand.local \
--to=me@ttaylorr.com \
--cc=git@vger.kernel.org \
--cc=jgsal@protonmail.com \
--cc=phillip.wood@dunelm.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).