From: Son Luong Ngoc <sluongng@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Son Luong Ngoc via GitGitGadget <gitgitgadget@gmail.com>,
git@vger.kernel.org
Subject: Re: [PATCH v3 1/3] midx: teach "git multi-pack-index repack" honor "git repack" configurations
Date: Sun, 10 May 2020 16:27:12 +0200 [thread overview]
Message-ID: <20200510142712.GA27407@C02YX140LVDN> (raw)
In-Reply-To: <xmqq7dxlvypv.fsf@gitster.c.googlers.com>
On Sat, May 09, 2020 at 09:51:08AM -0700, Junio C Hamano wrote:
> "Son Luong Ngoc via GitGitGadget" <gitgitgadget@gmail.com> writes:
>
> > From: Son Luong Ngoc <sluongng@gmail.com>
> >
> > Previously, when the "repack" subcommand of "git multi-pack-index" command
> > creates new packfile(s), it does not call the "git repack" command but
> > instead directly calls the "git pack-objects" command, and the
> > configuration variables meant for the "git repack" command, like
> > "repack.usedaeltabaseoffset", are ignored.
>
> When we talk about the current state of the code (i.e. before
> applying this patch), we do not say "previously". It's not like you
> are complaining about a recent breakage, e.g. "previously X worked
> like this but since change Y, it instead works like that, which
> breaks Z".
>
> > This patch ensured "git multi-pack-index" checks the configuration
> > variables used by "git repack" and passes the corresponding options to
> > the underlying "git pack-objects" command.
>
> We write this part in imperative mood, as if we are giving an order
> to the codebase to "become like so". We do not give an observation
> about the patch or the author ("This patch does X, this patch also
> does Y", "I do X, I do Y").
>
> Taking these two together, perhaps like:
>
> When the "repack" subcommand of "git multi-pack-index" command
> creates new packfile(s), it does not call the "git repack"
> command but instead directly calls the "git pack-objects"
> command, and the configuration variables meant for the "git
> repack" command, like "repack.usedaeltabaseoffset", are ignored.
>
> Check the configuration variables used by "git repack" ourselves
> in "git multi-index-pack" and pass the corresponding options to
> underlying "git pack-objects".
Thanks for this, it will take me a bit to adjust to this style of
writing but I do find it to be a lot clearer and practical.
Will update in next version.
>
> > Note that `repack.writeBitmaps` configuration is ignored, as the
> > pack bitmap facility is useful only with a single packfile.
>
> Good.
>
> > + int delta_base_offset = 1;
> > + int use_delta_islands = 0;
>
> These give the default values for two configurations and over there
> builtin/repack.c has these lines:
>
> 17 static int delta_base_offset = 1;
> 18 static int pack_kept_objects = -1;
> 19 static int write_bitmaps = -1;
> 20 static int use_delta_islands;
> 21 static char *packdir, *packtmp;
>
> When somebody is tempted to update these to change the default used
> by "git repack", it should be easy to notice that such a change must
> be accompanied by a matching change to the lines you are introducing
> in this patch, or we'll be out of sync.
>
> The easiest way to avoid such a problem may be to stop bypassing
> "git repack" and calling "pack-objects" ourselves. That is the
> reason why the configuration variables honored by "git repack" are
> ignored in this codepath in the first place. But that is not the
> approach we are taking, so we need a reasonable way to tell those
> who update this file and builtin/repack.c to make matching changes.
> At the very least, perhaps we should give a comment above these two
> lines in this file, e.g.
>
> /*
> * when updating the default for these configuration
> * variables in builtin/repack.c, these must be adjusted
> * to match.
> */
> int delta_base_offset = 1;
> int use_delta_islands = 0;
>
> or something like that.
Will add the comments in next version.
>
> With that, the rest of the patch makes sense.
>
> Thanks.
Cheers,
Son Luong
next prev parent reply other threads:[~2020-05-10 14:31 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-05 13:06 [PATCH] midx: apply gitconfig to midx repack Son Luong Ngoc via GitGitGadget
2020-05-05 13:50 ` Derrick Stolee
2020-05-05 16:03 ` Son Luong Ngoc
2020-05-06 8:56 ` Son Luong Ngoc
2020-05-06 9:43 ` [PATCH v2 0/2] " Son Luong Ngoc via GitGitGadget
2020-05-06 9:43 ` [PATCH v2 1/2] " Son Luong Ngoc via GitGitGadget
2020-05-06 12:03 ` Derrick Stolee
2020-05-06 17:03 ` Junio C Hamano
2020-05-07 7:29 ` Son Luong Ngoc
2020-05-06 9:43 ` [PATCH v2 2/2] multi-pack-index: respect repack.packKeptObjects=false Derrick Stolee via GitGitGadget
2020-05-06 16:18 ` Eric Sunshine
2020-05-06 16:36 ` Derrick Stolee
2020-05-09 14:24 ` [PATCH v3 0/3] midx: apply gitconfig to midx repack Son Luong Ngoc via GitGitGadget
2020-05-09 14:24 ` [PATCH v3 1/3] midx: teach "git multi-pack-index repack" honor "git repack" configurations Son Luong Ngoc via GitGitGadget
2020-05-09 16:51 ` Junio C Hamano
2020-05-10 14:27 ` Son Luong Ngoc [this message]
2020-05-09 14:24 ` [PATCH v3 2/3] multi-pack-index: respect repack.packKeptObjects=false Derrick Stolee via GitGitGadget
2020-05-09 16:11 ` Đoàn Trần Công Danh
2020-05-09 17:33 ` Junio C Hamano
2020-05-10 6:38 ` Đoàn Trần Công Danh
2020-05-10 15:52 ` Son Luong Ngoc
2020-05-09 14:24 ` [PATCH v3 3/3] Ensured t5319 follows arith expansion guideline Son Luong Ngoc via GitGitGadget
2020-05-09 16:55 ` Junio C Hamano
2020-05-10 16:07 ` [PATCH v4 0/2] midx: apply gitconfig to midx repack Son Luong Ngoc via GitGitGadget
2020-05-10 16:07 ` [PATCH v4 1/2] midx: teach "git multi-pack-index repack" honor "git repack" configurations Son Luong Ngoc via GitGitGadget
2020-05-10 16:07 ` [PATCH v4 2/2] multi-pack-index: respect repack.packKeptObjects=false Derrick Stolee via GitGitGadget
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200510142712.GA27407@C02YX140LVDN \
--to=sluongng@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).