From: "Đoàn Trần Công Danh" <congdanhqx@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Derrick Stolee via GitGitGadget <gitgitgadget@gmail.com>,
git@vger.kernel.org, Son Luong Ngoc <sluongng@gmail.com>,
Derrick Stolee <dstolee@microsoft.com>
Subject: Re: [PATCH v3 2/3] multi-pack-index: respect repack.packKeptObjects=false
Date: Sun, 10 May 2020 13:38:44 +0700 [thread overview]
Message-ID: <20200510063844.GA14311@danh.dev> (raw)
In-Reply-To: <xmqqlfm1ui6t.fsf@gitster.c.googlers.com>
On 2020-05-09 10:33:30-0700, Junio C Hamano <gitster@pobox.com> wrote:
> Đoàn Trần Công Danh <congdanhqx@gmail.com> writes:
>
> > On 2020-05-09 14:24:29+0000, Derrick Stolee via GitGitGadget <gitgitgadget@gmail.com> wrote:
> >> From: Derrick Stolee <dstolee@microsoft.com>
> >>
> >> +test_expect_success 'repack respects repack.packKeptObjects=false' '
> >> + test_when_finished rm -f dup/.git/objects/pack/*keep &&
> >> + (
> >> + cd dup &&
> >> + ls .git/objects/pack/*idx >idx-list &&
> >
> > I think ls(1) is an overkill.
> > I think:
> >
> > echo .git/objects/pack/*idx
> >
> > is more efficient.
>
> When there is no file whose name ends with idx, what happens?
>
> $ ls *idx && echo OK
> ls: cannot access '*idx': No such file or directory
> $ echo *idx && echo OK
> *idx
> OK
Yes, but I think the next line is checking for the number of lines.
This is better to fail faster.
(My suggestion was wrong anyway, it should be "printf "%s\\n" *idx)
> >> + test_line_count = 5 idx-list &&
> >> + for keep in $(cat keep-list)
> >> + do
> >> + touch $keep || return 1
> >
> > Is this intended?
> > Since touch(1) accepts multiple files as argument.
>
> Good suggestion, but doesn't .keep file record why the pack is kept
> in real life (i.e. not an empty file)?
Yes, in real life, we usually provide a reason in this .keep file.
But, we also allow empty file with git-index-pack --keep
I think simple touch is fine for this test.
Missing piece for my previous command:
if `keep-list` is empty, we may want to fail fast,
touch with empty list will error out (at least in my system).
--
Danh
next prev parent reply other threads:[~2020-05-10 6:38 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-05 13:06 [PATCH] midx: apply gitconfig to midx repack Son Luong Ngoc via GitGitGadget
2020-05-05 13:50 ` Derrick Stolee
2020-05-05 16:03 ` Son Luong Ngoc
2020-05-06 8:56 ` Son Luong Ngoc
2020-05-06 9:43 ` [PATCH v2 0/2] " Son Luong Ngoc via GitGitGadget
2020-05-06 9:43 ` [PATCH v2 1/2] " Son Luong Ngoc via GitGitGadget
2020-05-06 12:03 ` Derrick Stolee
2020-05-06 17:03 ` Junio C Hamano
2020-05-07 7:29 ` Son Luong Ngoc
2020-05-06 9:43 ` [PATCH v2 2/2] multi-pack-index: respect repack.packKeptObjects=false Derrick Stolee via GitGitGadget
2020-05-06 16:18 ` Eric Sunshine
2020-05-06 16:36 ` Derrick Stolee
2020-05-09 14:24 ` [PATCH v3 0/3] midx: apply gitconfig to midx repack Son Luong Ngoc via GitGitGadget
2020-05-09 14:24 ` [PATCH v3 1/3] midx: teach "git multi-pack-index repack" honor "git repack" configurations Son Luong Ngoc via GitGitGadget
2020-05-09 16:51 ` Junio C Hamano
2020-05-10 14:27 ` Son Luong Ngoc
2020-05-09 14:24 ` [PATCH v3 2/3] multi-pack-index: respect repack.packKeptObjects=false Derrick Stolee via GitGitGadget
2020-05-09 16:11 ` Đoàn Trần Công Danh
2020-05-09 17:33 ` Junio C Hamano
2020-05-10 6:38 ` Đoàn Trần Công Danh [this message]
2020-05-10 15:52 ` Son Luong Ngoc
2020-05-09 14:24 ` [PATCH v3 3/3] Ensured t5319 follows arith expansion guideline Son Luong Ngoc via GitGitGadget
2020-05-09 16:55 ` Junio C Hamano
2020-05-10 16:07 ` [PATCH v4 0/2] midx: apply gitconfig to midx repack Son Luong Ngoc via GitGitGadget
2020-05-10 16:07 ` [PATCH v4 1/2] midx: teach "git multi-pack-index repack" honor "git repack" configurations Son Luong Ngoc via GitGitGadget
2020-05-10 16:07 ` [PATCH v4 2/2] multi-pack-index: respect repack.packKeptObjects=false Derrick Stolee via GitGitGadget
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200510063844.GA14311@danh.dev \
--to=congdanhqx@gmail.com \
--cc=dstolee@microsoft.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=gitster@pobox.com \
--cc=sluongng@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).