From: "SZEDER Gábor" <szeder.dev@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: "Jeff King" <peff@peff.net>,
git@vger.kernel.org, "SZEDER Gábor" <szeder.dev@gmail.com>
Subject: [PATCHv3 4/4] clone: use free_refspec() to free refspec list
Date: Mon, 15 May 2017 13:05:57 +0200 [thread overview]
Message-ID: <20170515110557.11913-5-szeder.dev@gmail.com> (raw)
In-Reply-To: <20170515110557.11913-1-szeder.dev@gmail.com>
From: Jeff King <peff@peff.net>
Using free() on a refspec was always leaky, as its string
fields also need freed. But it became more so when ad00f128d
(clone: respect configured fetch respecs during initial
fetch, 2016-03-30) taught clone to create a list of
refspecs, each of which need to be freed.
[sg: adjusted the function parameters.]
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: SZEDER Gábor <szeder.dev@gmail.com>
---
builtin/clone.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/builtin/clone.c b/builtin/clone.c
index 4144190da..4bf28d7f5 100644
--- a/builtin/clone.c
+++ b/builtin/clone.c
@@ -1120,6 +1120,6 @@ int cmd_clone(int argc, const char **argv, const char *prefix)
strbuf_release(&value);
junk_mode = JUNK_LEAVE_ALL;
- free(refspec);
+ free_refspec(remote->fetch_refspec_nr + 1, remote->fetch);
return err;
}
--
2.13.0.35.g14b6294b1
next prev parent reply other threads:[~2017-05-15 11:06 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-15 11:05 [PATCHv3 0/4] clone: respect configured fetch respecs during initial fetch SZEDER Gábor
2017-05-15 11:05 ` [PATCHv3 1/4] clone: respect additional configured fetch refspecs " SZEDER Gábor
2017-05-15 23:07 ` Jeff King
2017-05-26 10:04 ` SZEDER Gábor
2017-05-26 13:30 ` Jeff King
2017-05-30 3:53 ` Junio C Hamano
2017-05-30 3:55 ` Jeff King
2017-05-30 7:11 ` SZEDER Gábor
2017-05-30 7:12 ` [PATCHv4 1/2] " SZEDER Gábor
2017-05-30 7:12 ` [PATCHv4 2/2] Documentation/clone: document ignored configuration variables SZEDER Gábor
2017-05-30 9:01 ` Ævar Arnfjörð Bjarmason
2017-05-31 8:50 ` SZEDER Gábor
2017-05-31 14:17 ` Ævar Arnfjörð Bjarmason
2017-06-13 23:24 ` Jonathan Nieder
2017-05-31 4:23 ` [PATCHv4 1/2] clone: respect additional configured fetch refspecs during initial fetch Jeff King
2017-05-31 9:34 ` SZEDER Gábor
2017-06-05 8:18 ` Jeff King
2017-06-06 18:19 ` SZEDER Gábor
2017-06-06 18:37 ` Jeff King
2017-06-07 11:17 ` SZEDER Gábor
2017-06-14 0:48 ` Jonathan Nieder
2017-06-14 9:50 ` Jeff King
2017-06-16 17:36 ` SZEDER Gábor
2017-06-16 17:38 ` [PATCHv5 0/2] " SZEDER Gábor
2017-06-16 17:38 ` [PATCHv5 1/2] " SZEDER Gábor
2017-06-16 20:37 ` Jonathan Nieder
2017-06-17 11:22 ` Jeff King
2017-06-22 22:23 ` Junio C Hamano
2017-08-12 0:48 ` Junio C Hamano
2017-06-16 17:38 ` [PATCHv5 2/2] Documentation/clone: document ignored configuration variables SZEDER Gábor
2017-06-16 18:23 ` Ævar Arnfjörð Bjarmason
2017-06-16 20:41 ` Jonathan Nieder
2017-06-16 21:10 ` Ævar Arnfjörð Bjarmason
2017-06-16 22:15 ` SZEDER Gábor
2017-06-16 20:38 ` Jonathan Nieder
2017-06-16 22:09 ` Junio C Hamano
2017-05-31 4:27 ` [PATCH] remote: drop free_refspecs() function Jeff King
2017-06-14 0:49 ` Jonathan Nieder
2017-05-15 11:05 ` [PATCHv3 2/4] Documentation/clone: document ignored configuration variables SZEDER Gábor
2017-05-26 14:01 ` SZEDER Gábor
2017-05-15 11:05 ` [PATCHv3 3/4] remote: drop free_refspecs() function SZEDER Gábor
2017-05-15 11:05 ` SZEDER Gábor [this message]
2017-05-15 11:29 ` [PATCHv3 4/4] clone: use free_refspec() to free refspec list SZEDER Gábor
2017-05-15 23:10 ` Jeff King
2017-05-23 7:38 ` Junio C Hamano
2017-05-23 11:27 ` Jeff King
2017-05-23 12:06 ` SZEDER Gábor
2017-05-15 22:46 ` [PATCHv3 0/4] clone: respect configured fetch respecs during initial fetch Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170515110557.11913-5-szeder.dev@gmail.com \
--to=szeder.dev@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).